diff mbox series

[-next] misc: eeprom/idt_89hpesx: Switch to memdup_user_nul() helper

Message ID 20230810121608.2110328-1-ruanjinjie@huawei.com
State New
Headers
Series [-next] misc: eeprom/idt_89hpesx: Switch to memdup_user_nul() helper |

Commit Message

Jinjie Ruan Aug. 10, 2023, 12:16 p.m. UTC 
  Use memdup_user_nul() helper instead of open-coding to simplify the code.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
 drivers/misc/eeprom/idt_89hpesx.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

Comments

Luca Ceresoli Aug. 11, 2023, 3:28 p.m. UTC | #1 
On Thu, 10 Aug 2023 20:16:08 +0800
Ruan Jinjie <ruanjinjie@huawei.com> wrote:

> Use memdup_user_nul() helper instead of open-coding to simplify the code.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
diff mbox series

Patch

diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
index 740c06382b83..433a4bc6b1c5 100644
--- a/drivers/misc/eeprom/idt_89hpesx.c
+++ b/drivers/misc/eeprom/idt_89hpesx.c
@@ -913,15 +913,9 @@  static ssize_t idt_dbgfs_csr_write(struct file *filep, const char __user *ubuf,
 		return 0;
 
 	/* Copy data from User-space */
-	buf = kmalloc(count + 1, GFP_KERNEL);
-	if (!buf)
-		return -ENOMEM;
-
-	if (copy_from_user(buf, ubuf, count)) {
-		ret = -EFAULT;
-		goto free_buf;
-	}
-	buf[count] = 0;
+	buf = memdup_user_nul(ubuf, count);
+	if (IS_ERR(buf))
+		return PTR_ERR(buf);
 
 	/* Find position of colon in the buffer */
 	colon_ch = strnchr(buf, count, ':');