diff mbox series

[net-next,1/2] dt-bindings: net: ethernet-controller: add PSGMII mode

Message ID 20230810102309.223183-1-robert.marko@sartura.hr
State New
Headers
Series [net-next,1/2] dt-bindings: net: ethernet-controller: add PSGMII mode |

Commit Message

Robert Marko Aug. 10, 2023, 10:22 a.m. UTC 
  Add a new PSGMII mode which is similar to QSGMII with the difference being
that it combines 5 SGMII lines into a single link compared to 4 on QSGMII.

It is commonly used by Qualcomm on their QCA807x PHY series.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring Aug. 10, 2023, 11:21 a.m. UTC | #1 
On Thu, 10 Aug 2023 12:22:54 +0200, Robert Marko wrote:
> Add a new PSGMII mode which is similar to QSGMII with the difference being
> that it combines 5 SGMII lines into a single link compared to 4 on QSGMII.
> 
> It is commonly used by Qualcomm on their QCA807x PHY series.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:


doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230810102309.223183-1-robert.marko@sartura.hr

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Robert Marko Aug. 10, 2023, 11:31 a.m. UTC | #2 
On Thu, Aug 10, 2023 at 1:21 PM Rob Herring <robh@kernel.org> wrote:
>
>
> On Thu, 10 Aug 2023 12:22:54 +0200, Robert Marko wrote:
> > Add a new PSGMII mode which is similar to QSGMII with the difference being
> > that it combines 5 SGMII lines into a single link compared to 4 on QSGMII.
> >
> > It is commonly used by Qualcomm on their QCA807x PHY series.
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > ---
> >  Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
>
>
> doc reference errors (make refcheckdocs):

I am not getting any errors, nor there are any listed here as well.
Is this a bot issue maybe?

Regards
Robert
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230810102309.223183-1-robert.marko@sartura.hr
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
Rob Herring Aug. 10, 2023, 4:27 p.m. UTC | #3 
On Thu, Aug 10, 2023 at 5:32 AM Robert Marko <robert.marko@sartura.hr> wrote:
>
> On Thu, Aug 10, 2023 at 1:21 PM Rob Herring <robh@kernel.org> wrote:
> >
> >
> > On Thu, 10 Aug 2023 12:22:54 +0200, Robert Marko wrote:
> > > Add a new PSGMII mode which is similar to QSGMII with the difference being
> > > that it combines 5 SGMII lines into a single link compared to 4 on QSGMII.
> > >
> > > It is commonly used by Qualcomm on their QCA807x PHY series.
> > >
> > > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > > ---
> > >  Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> >
> >
> > doc reference errors (make refcheckdocs):
>
> I am not getting any errors, nor there are any listed here as well.
> Is this a bot issue maybe?

Yes. Converting dtschema to pyproject.toml yesterday did not go well...

Rob
Rob Herring Aug. 10, 2023, 8:53 p.m. UTC | #4 
On Thu, 10 Aug 2023 12:22:54 +0200, Robert Marko wrote:
> Add a new PSGMII mode which is similar to QSGMII with the difference being
> that it combines 5 SGMII lines into a single link compared to 4 on QSGMII.
> 
> It is commonly used by Qualcomm on their QCA807x PHY series.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
index 6b0d359367da..9f6a5ccbcefe 100644
--- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
@@ -66,6 +66,7 @@  properties:
       - mii
       - gmii
       - sgmii
+      - psgmii
       - qsgmii
       - qusgmii
       - tbi