From patchwork Thu Aug 10 13:12:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 133996 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp421475vqi; Thu, 10 Aug 2023 06:30:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhhppKWL++9IAzo5eAfFKhrR5Qcrdo8EcO9Q9fldVmfaeJO+R0ldU2r88pz42USJOpCWoH X-Received: by 2002:a05:6a20:394a:b0:140:c6b1:78d7 with SMTP id r10-20020a056a20394a00b00140c6b178d7mr2934877pzg.26.1691674219887; Thu, 10 Aug 2023 06:30:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691674219; cv=none; d=google.com; s=arc-20160816; b=SVw0SKrW/4y0c3mFXiH3PjG3mChQ7Jc5/S1zfahCdAPtciCB/STCbQQ2Fimw76eUnN Dh2k/DAmdRTqLKbYGxjZOT72X/hg5cbAowGjLnww1W/HDpe1IHqYn/D08gsSo514EjvA D630iKKpmsIiJsoxA8fW3MOWYtG3MToJAiRu2mVuOjFn+lGofOjcgZLdtSc77TGU728o Lf8hgF8aMtiN6qYVSKnuvoXCQrPLNR08ZJUb304kQVjg++1Ir5AyTCa2f0/X3sFcZlM0 UU6q+i017dd++fO6ik7mI6nghrpRIxFrLuqDiI8XiswvE926Iy1gpRMb0SoOIctxgHBR I+rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=3mQ50v3epXKjYfUc8cjFnME4b3yo90qJq/zLnCXIf4I=; fh=L/kRK60uddxNkRYPrHJT9HisR9iqwn7Y8kOlbgG+aXM=; b=g3GEzuUmR3J1Lhaxbu+/8SaO7VLRTs0zTChTd/TQO0L68772WodG+KFOZUBDs/XKLj RzbnCtYrixPKjUISiBK71WVKor2lygidaX2CstNu5Mb+DtMT9QPC/iil86CtGuOV1+Lv hj4SwL7JicD5aNSHI4w6VmSoXhwnBe2gKSTLUGGj2JaAUkOjotJwLmTDlXNZ0snQENod 3T49G8UzEpO7z8/xyrmvYdTJpSQ2Vdt8ucnMkO/EYR2RS0c6+UNZznYpUMuLwqu0nRqC pJCPrIo215rJUdLIdyQEmc0AD3ICl6ycQUt9t2FrEx2Jh+Quz9IZtOHrCPBk6ce1Xym/ 6cBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="N7x/taN4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i9-20020a63b309000000b0056387def1cfsi1486534pgf.48.2023.08.10.06.30.03; Thu, 10 Aug 2023 06:30:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="N7x/taN4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234559AbjHJNMT (ORCPT + 99 others); Thu, 10 Aug 2023 09:12:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233699AbjHJNMM (ORCPT ); Thu, 10 Aug 2023 09:12:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE76191; Thu, 10 Aug 2023 06:12:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 84AE062EE1; Thu, 10 Aug 2023 13:12:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5727DC433CA; Thu, 10 Aug 2023 13:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691673131; bh=sWnTCUjG/8VJ8vbCcrMecGrqt9k5P6DlV83pYz2Oy94=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=N7x/taN4/Vz2LHtz89xLrAuRlFkXnRDYaEWTg2eYgLJhwmJFX59yXTxQdOfAI0ONd 1hM/Q9E+YZMn70nTReoZGbro31vQGQ4oUhypoXrzcDG6BRx7jKUEHarZ6rFw2IDScy UkvioLq7puUHg6E2jZADC3CR/XYkbaxeVzSRNfKN2EGWeLLrm+87sZ+8uo/8Ni8lqB USzP1VZIbV/0soeWEA70+SI+01eJ10GsG7rRXvLkpDLmeFmxoYFTxTTBHfGjFEzeYq KS9xyCO6ZkKGMGFhUaZUcgDSH9XBd1erEZk8nXMk5Byqhe4NUf4Gmf8rgMqorSp6db WMJd90EK2a0vQ== From: Jeff Layton Date: Thu, 10 Aug 2023 09:12:05 -0400 Subject: [PATCH 2/2] fat: make fat_update_time get its own timestamp MIME-Version: 1.0 Message-Id: <20230810-ctime-fat-v1-2-327598fd1de8@kernel.org> References: <20230810-ctime-fat-v1-0-327598fd1de8@kernel.org> In-Reply-To: <20230810-ctime-fat-v1-0-327598fd1de8@kernel.org> To: Christian Brauner , OGAWA Hirofumi , Frank Sorenson , Jan Kara Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=824; i=jlayton@kernel.org; h=from:subject:message-id; bh=sWnTCUjG/8VJ8vbCcrMecGrqt9k5P6DlV83pYz2Oy94=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBk1OIoFsZaNNKC83Oz7ClMXf2h3TADk4VzazKCo yTo7933ROyJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZNTiKAAKCRAADmhBGVaC FUQMD/4uSUbtoyOw/8HxuFSZeAJrv4k7WqZJzPyEPIJQ3YYV9r8kbJnYM/K5GOEVKFxW1/CA/6W bfZ0CaEgZCvps13bbARi0eMuAjzOZs1FvyRMP39RxjoyjQufvWqlpg+sefj1YDCZ2PzsixtXagD XZ5b02Kj4SFWD0t2DIX+BgDmaZld3jz/1oWGg7p335WGiLnA7CIbBvAM24yQZsoGsjqwfz8DAtw Se+TJrDVLA/Rt/dPzLHpzz5gIA2tZ/W2htf6Q5Sd2Ty4H0waSx46qJDbNTqC469Xx8zsh0bf0qY DUzt1xfC+1UvAH6QapYSnn9UAYfYf+bFxtsepEVHB+gY6Ayhpn8RblARq4PIotKitjqsIHNTRHv oAT7ql5Em83p40vmawKCiY8yxn1TR/s8n3WJQ70M+pg2EDSAFMSnQvpN4CJWyG0rQhC92hBkUPd e5NXhr8zsPecE5upofGgBaW/IbwqeZV0U9+6Dh8chJ7u7/d6UTrSMFdfuHvQN2LGJ3ELcwRlHLk gwNxWPuFyS1DW+6TQ8mByh7xGSdq99+ynkC7mb1XI9pe1DUKESm8q2RJTGFB9wRbO0vc6StnvpT Orkn8jOhtB28yVotD84G4AoSeJBnHoHwElUQIZr59Zgs/zOhjxtdX0dGC6tVa/vuJRwcbCmkavC vhoEOHO7jj0vV8Q== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773848986456010120 X-GMAIL-MSGID: 1773848986456010120 In later patches, we're going to drop the "now" parameter from the update_time operation. Fix fat_update_time to fetch its own timestamp. It turns out that this is easily done by just passing a NULL timestamp pointer to fat_truncate_time. Signed-off-by: Jeff Layton Reviewed-by: Jan Kara Acked-by: OGAWA Hirofumi Reviewed-by:  Frank Sorenson --- fs/fat/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fat/misc.c b/fs/fat/misc.c index 37f4afb346af..f2304a1054aa 100644 --- a/fs/fat/misc.c +++ b/fs/fat/misc.c @@ -347,7 +347,7 @@ int fat_update_time(struct inode *inode, int flags) return 0; if (flags & (S_ATIME | S_CTIME | S_MTIME)) { - fat_truncate_time(inode, now, flags); + fat_truncate_time(inode, NULL, flags); if (inode->i_sb->s_flags & SB_LAZYTIME) dirty_flags |= I_DIRTY_TIME; else