Message ID | 20230809191054.2197963-3-bmasney@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp3033958vqr; Wed, 9 Aug 2023 12:46:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGRK3nVsf74f3InulpqJeNN3pg3ICau2+TObCP/ZbJFv2niMPtHCPD4GRWSUUSnpVaDKj44 X-Received: by 2002:a17:902:ea0a:b0:1b8:9195:1dd8 with SMTP id s10-20020a170902ea0a00b001b891951dd8mr92128plg.51.1691610407656; Wed, 09 Aug 2023 12:46:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691610407; cv=none; d=google.com; s=arc-20160816; b=tVhJkqzlyRw/O4/+arnbCRGJ/xZSiRAd3Xp0Mt8Vdj8VvlKiBvQq2GKjX2NAcgP1ch 5XtkTJ4r6aP01cq94OqM4g+Kya6mlHP0KyjpgI77QEgEp5rT5R9c3ujhk1wzNQZcAgym I8fzZPtcxb5xjB/tTkcvEliyiDjtycb1EwVHHaDwatBsyxfiHA9HPDK7zUJCw7qp8N+k BUw/Jt0GuEX15gLvCL5h/l0XssSvgTJ4U8GTJ8fxQZ1fEx6r0FoNMIpm/2nIU5Ps228J cJDHK7aSCefS6wJ5ft3OA9BQVW3iF563+YALIBfJG2EazsSJLJDU+TnKaDeEt7ai2igy 3tMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FJ/VTCVUVdAN9JEuI46HSpb8/BIcrmXf6cV+lu2tL0Y=; fh=hc5e8cLPeOSIpxJU4j4YYXOIXP2caYxrHNMZJhjGPQQ=; b=K8J6IJCeF5qNaZp5edTfUmcZBemXp6GNp21dWjF0WbuRNnkkElEcJLwsnlOm2XqLlT c4jR33HL5RkUJdSBBPOaWAXs1QucCpBJKavJnbB/DBGxghxbbamtpvDtMf169NPpEuVQ bSaBfc2R8bdtCn+FPKcf78JaMme/gqRCzlO1fTlGCYNDxTyaxG0etpzxlLaMiNU8ENT3 GfzEnb+imTomGclPLaWNmSIFRTmyF/XMu4glgBIKzgs5XIapUduPGAmwCaGvqH6vXp5F Vz7i/kvGKZ8qrG/97XoaYskJ9gTOTNxyLA9FFdQnvBmlc4MVW9DB8yba39QLYcY1Ch8z hY9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="h/dcFDIo"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x6-20020a170902a38600b001bd9ae2a3dfsi55546pla.237.2023.08.09.12.46.29; Wed, 09 Aug 2023 12:46:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="h/dcFDIo"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233190AbjHITMK (ORCPT <rfc822;craechal@gmail.com> + 99 others); Wed, 9 Aug 2023 15:12:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233313AbjHITMB (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 9 Aug 2023 15:12:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AF5C2127 for <linux-kernel@vger.kernel.org>; Wed, 9 Aug 2023 12:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691608273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FJ/VTCVUVdAN9JEuI46HSpb8/BIcrmXf6cV+lu2tL0Y=; b=h/dcFDIovAMCqt3iS50zJh4NB0P3EMrQSpLuvutY+53txNKFzYTSJlYQLdZE+aAqJgLAO2 iCYzBQY15DRxOGHRU741xjY4RDZo6FAIBQ9kaBFJl18Y+lGILPOF49rCy68x6/2AxOMCjZ whqrMWmvAH5SyywWTy7Hbpp6oT6jQXg= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-bL-Mnb2GNMm13z9rD9v3sw-1; Wed, 09 Aug 2023 15:11:10 -0400 X-MC-Unique: bL-Mnb2GNMm13z9rD9v3sw-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-5897d05e878so2946967b3.3 for <linux-kernel@vger.kernel.org>; Wed, 09 Aug 2023 12:11:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691608269; x=1692213069; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FJ/VTCVUVdAN9JEuI46HSpb8/BIcrmXf6cV+lu2tL0Y=; b=Ex3mvdbWsgFohmEFM7PX95KCVmt0HAsw0TFWP7OCLiyc6DMohW9iwy/PHVthxHrmGm Spg8lr1frbUtbrIhaNMGbYOThMOFeZ1dYcHnAMQGOTqevotVWQxbh9Jgt7oRpxvRTOG6 R1hPFncYcIjWX6+71lbMZQ52tBQwrBS6MhFAU/yZYx65sNj6Oiy9sq7aIrzysSlMnLwN D2h+q8GEQfxFYKuvowzGNuCp8FB2Wd5iJnIBVlllqAp+V8Hh5VEAVpuieKkvT8J0+fHF AeUhvIjhtoR2Pqj/R4ZzGiJdAXH69XwfL99CfBJXEQ9wuSZFbtA/SDIAbuqYV+DVK+Dv ku5w== X-Gm-Message-State: AOJu0YzYUgTTPDJWNPM+x7zO8ULbfBZxmjP85h3ND11fy6edNt9jYGpz 7fC3vwiAuny9l+D+i5Pa4jUmEXhIVjZivsw155AFVYn4gEGx5o3RscYiFA703Zha14ocdhDAuTE 4uudqfEXUZL8VfHFWUNBIw47P X-Received: by 2002:a0d:f1c1:0:b0:586:a689:d28a with SMTP id a184-20020a0df1c1000000b00586a689d28amr187553ywf.34.1691608269577; Wed, 09 Aug 2023 12:11:09 -0700 (PDT) X-Received: by 2002:a0d:f1c1:0:b0:586:a689:d28a with SMTP id a184-20020a0df1c1000000b00586a689d28amr187536ywf.34.1691608269344; Wed, 09 Aug 2023 12:11:09 -0700 (PDT) Received: from brian-x1.. (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id s84-20020a817757000000b005774338d039sm4172969ywc.96.2023.08.09.12.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 12:11:08 -0700 (PDT) From: Brian Masney <bmasney@redhat.com> To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hugo@hugovil.com Subject: [PATCH v2 2/2] scsi: ufs: host: convert to dev_err_probe() in pltfrm_init Date: Wed, 9 Aug 2023 15:10:54 -0400 Message-ID: <20230809191054.2197963-3-bmasney@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230809191054.2197963-1-bmasney@redhat.com> References: <20230809191054.2197963-1-bmasney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773782074688501118 X-GMAIL-MSGID: 1773782074688501118 |
Series |
scsi: ufs: convert probe to use dev_err_probe()
|
|
Commit Message
Brian Masney
Aug. 9, 2023, 7:10 p.m. UTC
Convert ufshcd_pltfrm_init() over to use dev_err_probe() to avoid
the following log message on bootup due to an -EPROBE_DEFER return
code:
ufshcd-qcom 1d84000.ufs: Initialization failed
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
No changes since v1
drivers/ufs/host/ufshcd-pltfrm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 8/9/2023 12:10 PM, Brian Masney wrote: > Convert ufshcd_pltfrm_init() over to use dev_err_probe() to avoid > the following log message on bootup due to an -EPROBE_DEFER return > code: > > ufshcd-qcom 1d84000.ufs: Initialization failed > > Signed-off-by: Brian Masney <bmasney@redhat.com> > --- > No changes since v1 > > drivers/ufs/host/ufshcd-pltfrm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd-pltfrm.c > index 0b7430033047..f2c50b78efbf 100644 > --- a/drivers/ufs/host/ufshcd-pltfrm.c > +++ b/drivers/ufs/host/ufshcd-pltfrm.c > @@ -373,7 +373,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev, > > err = ufshcd_init(hba, mmio_base, irq); > if (err) { > - dev_err(dev, "Initialization failed\n"); > + dev_err_probe(dev, err, "Initialization failed\n"); Hi Brian, Can you pls add the error code to the print? > goto dealloc_host; > } >
diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd-pltfrm.c index 0b7430033047..f2c50b78efbf 100644 --- a/drivers/ufs/host/ufshcd-pltfrm.c +++ b/drivers/ufs/host/ufshcd-pltfrm.c @@ -373,7 +373,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev, err = ufshcd_init(hba, mmio_base, irq); if (err) { - dev_err(dev, "Initialization failed\n"); + dev_err_probe(dev, err, "Initialization failed\n"); goto dealloc_host; }