From patchwork Wed Aug 9 13:27:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Herve Codina X-Patchwork-Id: 133263 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp2814862vqr; Wed, 9 Aug 2023 06:54:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwQ4c9WScDLtAP0x6z/3slIQVNRWjk9VmlSQbxRygAr02j2zhIUN0pSDiR3G73EV3hZWqp X-Received: by 2002:a05:6a20:9154:b0:13e:14f9:294d with SMTP id x20-20020a056a20915400b0013e14f9294dmr2650895pzc.58.1691589252692; Wed, 09 Aug 2023 06:54:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691589252; cv=none; d=google.com; s=arc-20160816; b=XOh8CjBoY+d98/BAXAb1mG77sI/mAI9nSFK3hYfkRMjeFueY8Ej+nMWvfYLIdYAbI/ PvwuL94DiFr+AgSlHjQKl/s6O/pxXiojqTh3ZMvSqCs5z27gTehrxG14zvFQmMJTzl+T 5Jv1BXHU0Ig4YSap0Bohe2XF9/x119c14rKYzMXSW3N2rR4q2iF0wn30XOnAtWaRu8PM 4sXir5JkKE1NJuA1ScJg/kuXmXLo3GgVTN7DumqFxF7BftNZD0W4b9TTEDECMQ0t3yoZ wzesZfVgq2MY33eBI6f7vG+kduSth36+YIgCZHjawX+LRc772bxrqVOlfoWaT+zGODOI tB3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WKoPv036RC0ux4I34NtLKPGM96CkWE1vmgdCaUi+1T0=; fh=OtJVFpZ5Y8/ND7g8QcUIbRSFhG4LznwcYYtG4zWKevM=; b=w7nUmPKTvWo/pO0P3oRC1exfYct7qTALKD1BWLRUnX2DZwbMymkzWjR4C2rl+d1Yyt jCEcATSoeOKylBIoTCtahAv/e1KJjKh2SJdZHyOHtKOR3yef3Nb5BnnpeGaBULweJGWz z3ANd+HJVZtl4Zw9449JFC4VerdWnevFU9RM67qGoE1IcbqB0sUYByOv1FR6jnWu8Ncf GruqaBsdD0gKpX/yymhqqUO9oSFhiRqUwaMt4xa9zxo7CCZzXFQmvgd6KGzXEnow6pM3 R6o05HAMcDmDZDfaiHvmo82+HlERd40Y6O3SzwGTVMbsztoqvFEXk61Pi8pBUhRfLc3f RUbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=B2eJjBrD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s26-20020a056a00179a00b0066a4fe6ad99si9604371pfg.148.2023.08.09.06.53.58; Wed, 09 Aug 2023 06:54:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=B2eJjBrD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233086AbjHIN3w (ORCPT + 99 others); Wed, 9 Aug 2023 09:29:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233004AbjHIN3R (ORCPT ); Wed, 9 Aug 2023 09:29:17 -0400 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C87C530DA; Wed, 9 Aug 2023 06:28:46 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPA id 6B80D40014; Wed, 9 Aug 2023 13:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1691587725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WKoPv036RC0ux4I34NtLKPGM96CkWE1vmgdCaUi+1T0=; b=B2eJjBrDGWvPQpVXcbWXnlqYO0UN/zSBJaeSfKt/DOEq825FH6369L/vg1mXWt/dpQwxp2 3msa0SNzFxSPp3AQnv6fgpM8tej0z3Tr4Hi59w/eF6iUY0n7lFnTRZ8qTkZvaoi4tNhPkv 4zATom48wbuKKCY9xVf3wyasqy2T2KiIatlL6Xe48atCZx3oBovEkIeq9plrcD7cKQJMfC g6n82T/2qAY3acPNbyjoOymYvZhPX2IANgHUnzu7/+1VkrpvHrLqrrT8YX391qCWH7sqsu VGfj8eb3eUlnWY4si/j11ylF9rWLSPhG+p+Xd1B/ZuSEhmuA2axkQMTlDxrRVg== From: Herve Codina To: Herve Codina , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: [PATCH v3 18/28] soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan() Date: Wed, 9 Aug 2023 15:27:45 +0200 Message-ID: <20230809132757.2470544-19-herve.codina@bootlin.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230809132757.2470544-1-herve.codina@bootlin.com> References: <20230809132757.2470544-1-herve.codina@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773759892165580734 X-GMAIL-MSGID: 1773759892165580734 Timeslots setting is done at channel start() and stop(). There is no more need to do that during setup_chan(). Simply remove timeslot setting from setup_chan(). Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy --- drivers/soc/fsl/qe/qmc.c | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c index 00408da14cb4..b67e73ad7c1a 100644 --- a/drivers/soc/fsl/qe/qmc.c +++ b/drivers/soc/fsl/qe/qmc.c @@ -723,30 +723,6 @@ static int qmc_chan_setup_tsa_rx(struct qmc_chan *chan, bool enable) return qmc_chan_setup_tsa_32rx(chan, &info, enable); } -static int qmc_chan_setup_tsa(struct qmc_chan *chan, bool enable) -{ - struct tsa_serial_info info; - int ret; - - /* Retrieve info from the TSA related serial */ - ret = tsa_serial_get_info(chan->qmc->tsa_serial, &info); - if (ret) - return ret; - - /* - * Setup one common 64 entries table or two 32 entries (one for Tx - * and one for Tx) according to assigned TS numbers. - */ - if (chan->qmc->is_tsa_64rxtx) - return qmc_chan_setup_tsa_64rxtx(chan, &info, enable); - - ret = qmc_chan_setup_tsa_32rx(chan, &info, enable); - if (ret) - return ret; - - return qmc_chan_setup_tsa_32tx(chan, &info, enable); -} - static int qmc_chan_command(struct qmc_chan *chan, u8 qmc_opcode) { return cpm_command(chan->id << 2, (qmc_opcode << 4) | 0x0E); @@ -1323,10 +1299,6 @@ static int qmc_setup_chan(struct qmc *qmc, struct qmc_chan *chan) chan->qmc = qmc; - ret = qmc_chan_setup_tsa(chan, true); - if (ret) - return ret; - /* Set channel specific parameter base address */ chan->s_param = qmc->dpram + (chan->id * 64); /* 16 bd per channel (8 rx and 8 tx) */