From patchwork Wed Aug 9 21:25:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Stitt X-Patchwork-Id: 133598 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp43014vqi; Wed, 9 Aug 2023 15:21:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1T4qlBNh0fHKd9+clPoKLb7Rq0BMZ/X0I88lBumVlya1HMT4KNH6+8XcaRUqYdZRDk19K X-Received: by 2002:a05:6830:14d3:b0:6bc:e2a8:6e3c with SMTP id t19-20020a05683014d300b006bce2a86e3cmr450577otq.27.1691619715839; Wed, 09 Aug 2023 15:21:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691619715; cv=none; d=google.com; s=arc-20160816; b=b88H+7SQ7vvKF57PdbKmn1JQdkK5WKQnMF7oM8WYtKKGhen/UWUFRRlLMpd4o31Wfn ThaMevXOsgP9T3y3c2ywK17hR3q1f2k6lG1ltmaR6JkI5YnqDzCD1u76A/1PIuXG920Q 0SDotsnG5HXyr9YjHscBtnMB3O7/h2MCWj8KKdwFJC1rVyXagiwlaaCVV2mzU3dxemQD EGZgB7Z0kZbdWTABt1GuvqDaXM5Ul4jLJqXKbMaXya80DAcIS8b65SKYB6FISyTH0e4u GU9wQyVpmGJdvUaZJo+rEdua9pSrYYlNcKyEBlg75nDmzeRxbh+yNTdXs6Vq3vDwmIKW 7BsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=xDx0Hy/g05LsgjXJunLNKRIVZ1PiGzjJ3aP3yYS1SPs=; fh=RJ1oGEP+ZGF11M//lho86SN4YwQjxHoIeZltZx6K1F4=; b=S93TZqqC8O4HnVme/OFaWY8Z3zFEp8xZXhWgusvRcupcd0kil1vxuQ49D39W58Ob/l 5s86wsvmJw2iVQezvHeONaL+3swui/0O2pqxMk6lR8pWNKsYFmsXm3iy+VxTDgTdvYdd D9J7rKnISQ+yd4nPFeJMgIHSkryinXS7Pg/u5+EGArWtSSaljNxsWvEgOOal6KVj3Pft StEacbAMyQHM4A/leV+cHWprI1J1J4z3KV3uF9ufCqV2suAHz32X14L1eYVqvZHFSP8t YabuKKT4uW8dNocXz/QRzT1OhNe0vP5XHVeCwHGJyr2XrACZhe/o57W0oWZDZcOlsijA maYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b="q95v/fDB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i189-20020a6387c6000000b0056467852fbesi153458pge.779.2023.08.09.15.21.41; Wed, 09 Aug 2023 15:21:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b="q95v/fDB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230501AbjHIVZu (ORCPT + 99 others); Wed, 9 Aug 2023 17:25:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230173AbjHIVZs (ORCPT ); Wed, 9 Aug 2023 17:25:48 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9E2E138 for ; Wed, 9 Aug 2023 14:25:45 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5897d05e878so4211777b3.3 for ; Wed, 09 Aug 2023 14:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691616345; x=1692221145; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=xDx0Hy/g05LsgjXJunLNKRIVZ1PiGzjJ3aP3yYS1SPs=; b=q95v/fDBA425ZRj8HB8knec/n4Wh3vXc8UbBeQ9+7ttjuOkZDgYRPpnfEmLqXf/K0c 9vUIwMzhWqcCXcQ3ORw3unREK+rNDPA94GFJB3geeKvjgleAH2TJzWdB4aiD1AgfKkI9 Z/bn4LDdalSqacEfSDlGVSB+SrKHJq+8AHxcNmoUPLE2evR/gffiSsW98OvDz7w+3DyV T8HJ4BVxsFz1/VC2CZS3v9TY2Ew85MTPbGOCkMlUSQk0LvyVWCWPQ6Q0CKtwX4rYn4Mz Bzrx5iddUJRYh3HidSo+HrZFmOUe4x5eekX/x5QVelGZKMWymoP1yjh830Hf898C+unA TkHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691616345; x=1692221145; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xDx0Hy/g05LsgjXJunLNKRIVZ1PiGzjJ3aP3yYS1SPs=; b=QIjTJ5M7iYC5z64Rr5HB8HIh9R/nJsoMG5j/ODO+nIgf2ayZ/p0L1AMEDWGPOfy51G UDb9kPwannnkAtT/OKykGo+dv/z2ad7iIDDvPSoigsM86ZbtbZ2A/pTEE+v1lsK/xFJz c+YxxeT63o6FJZjaTc9cKIfBz/saZ4Ga84uRUNft+7c2EBqCC1IyX1K8S8cozfRhxt1b 6q8KXpDxB93kpR9Le7+M/tUtxFQqTPW4jr73PGxDD0tHCmq7Iu+sRcbdgQTzp7QVDPVL R6UtudJKVnRzHKN+VFJGubdUL2F0Mw8CkNo9B9CWmrSbTmCe18elL4Q0y61L2nqOA3/Z T9xg== X-Gm-Message-State: AOJu0YzziKngpTvdLrRWVE62LUvxsIiLq4qugdQROsMgEalY0Bc7rXcl K+w5GM77Szke4iC4y2kswc6PeVH2QFfgK6KjMA== X-Received: from jstitt-linux1.c.googlers.com ([fda3:e722:ac3:cc00:2b:ff92:c0a8:23b5]) (user=justinstitt job=sendgmr) by 2002:a81:b718:0:b0:576:f61f:adbc with SMTP id v24-20020a81b718000000b00576f61fadbcmr8718ywh.1.1691616345223; Wed, 09 Aug 2023 14:25:45 -0700 (PDT) Date: Wed, 09 Aug 2023 21:25:35 +0000 In-Reply-To: <20230809-cbl-1903-v1-0-df9d66a3ba3e@google.com> Mime-Version: 1.0 References: <20230809-cbl-1903-v1-0-df9d66a3ba3e@google.com> X-Developer-Key: i=justinstitt@google.com; a=ed25519; pk=tC3hNkJQTpNX/gLKxTNQKDmiQl6QjBNCGKJINqAdJsE= X-Developer-Signature: v=1; a=ed25519-sha256; t=1691616343; l=1671; i=justinstitt@google.com; s=20230717; h=from:subject:message-id; bh=1jpubBEYs5G/kONM8KXG1tjVjaf45XD96u1TgLGh88c=; b=HD13U7Lf7gLBUJgdxnwIDWUS5iUmJBBrEtQkf3kdA3nIJwjjfZ/thVFMV1IjFQZf6I2y84s5B 9rseL9CjIuVBaaF60aQ2gvWP/yFSYM2Erz2oCmo8XTvy/PYDz3u5bej X-Mailer: b4 0.12.3 Message-ID: <20230809-cbl-1903-v1-1-df9d66a3ba3e@google.com> Subject: [PATCH 1/2] i2c: i2c-bcm-iproc: fix -Wvoid-pointer-to-enum-cast warning From: Justin Stitt To: Andi Shyti , Ray Jui , Scott Branden , Broadcom internal kernel review list Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Nathan Chancellor , Justin Stitt X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773791834941010545 X-GMAIL-MSGID: 1773791834941010545 When building with W=1 we see the following warning: | drivers/i2c/busses/i2c-bcm-iproc.c:1039:3: error: cast to smaller \ | integer type 'enum bcm_iproc_i2c_type' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] | 1039 | (enum bcm_iproc_i2c_type)of_device_get_match_data(&pdev->dev); | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This is due to the fact that the `bcm_iproc_i2c_type` enum members are int-width and a cast from pointer-width down to int will cause truncation and possible data loss. Although in this case `bcm_iproc_i2c_type` has only a few enumerated fields and thus there is likely no data loss occurring. Nonetheless, this patch is necessary to the goal of promoting this warning out of W=1. Link: https://github.com/ClangBuiltLinux/linux/issues/1903 Signed-off-by: Justin Stitt --- drivers/i2c/busses/i2c-bcm-iproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index 2d8342fdc25d..3464f3a376a5 100644 --- a/drivers/i2c/busses/i2c-bcm-iproc.c +++ b/drivers/i2c/busses/i2c-bcm-iproc.c @@ -1036,7 +1036,7 @@ static int bcm_iproc_i2c_probe(struct platform_device *pdev) platform_set_drvdata(pdev, iproc_i2c); iproc_i2c->device = &pdev->dev; iproc_i2c->type = - (enum bcm_iproc_i2c_type)of_device_get_match_data(&pdev->dev); + (unsigned long) of_device_get_match_data(&pdev->dev); init_completion(&iproc_i2c->done); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);