From patchwork Tue Aug 8 23:26:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 132988 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp2470892vqr; Tue, 8 Aug 2023 17:09:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFlH9FpC1ZZRVnfD6QtzZsgjO9RYo63Q2apr38bTxvfl/g3Op4zKv+7SEcQke4lFBdxMt8m X-Received: by 2002:a17:902:ed93:b0:1ae:50cc:455 with SMTP id e19-20020a170902ed9300b001ae50cc0455mr1102550plj.39.1691539746009; Tue, 08 Aug 2023 17:09:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691539745; cv=none; d=google.com; s=arc-20160816; b=x6NuU1fVwxYdPftOzltLH0nsGawAqNGiaGMqXNnfS3VVdX+wWF1akzWEqBzU0Za6at i4jCuCtkRe41WwOr3E4/eAJCJ5XMeQ9RCAg6u+cI8SXq/X3AVTibhEx5Gr6UlXAtZbBE dmpEh6xz47Z85htzKgBolQjeHDuGabGpEtT3YAJJl23Nue52BcG7lS9WbUmxM5Bib+KY C8IxhVAGQW1qYk7VDRNWz3QwBvfrTPTl0IL0ore+lndTHSRilYBkR8OXXXJ17l9Wwd07 s3nAivtvLLvDoyQyY4XmPZE423I43JrKQBvWj5UwHU20ttteV+9p3lYu1s+JhbGuc31b xDJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=NsaIqfpGRHhuu1KEMbWRWbIrElmncZ2eWcE/szEec0U=; fh=ZTWsksgTy0CSMc0CkkquEZG8kImELaC4LkT8sHq9kzQ=; b=0IYS08brLSeKHWpHMj19z8JVKN+9KE+g/MR8Lxq4WVTtYmCi9zkK/0PoIImXgTSCfg eJ8CUMlAg2WT/6XZ+IW9U/Bku3f6B2xRKyYvl8r9hsKT/mzGf2lT+rMFXwMVAdyY1rkU OxY+2CgLPjcQpiHO+ijTpi2Tnq4cDMNgj+8aeibtCQCeSHcy/UKLqVodmuYeb0kp7KmO sxY2OCCclAtpY4LSqvtWSmEWxYJLfgkOvfLbHaiOQoGugN5QzvqlcyjZ3hX6FMYV1EUV J9ZDiKTrOykkWvaWgqbYJsBJPUfVcI6VsAOPqamOiVl7erTjstvEBzOz6EYgKdDHOnOj jHrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=lRAlkGHw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m18-20020a170902d19200b001b9eb349550si7970133plb.391.2023.08.08.17.08.51; Tue, 08 Aug 2023 17:09:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=lRAlkGHw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229740AbjHHX0d (ORCPT + 99 others); Tue, 8 Aug 2023 19:26:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjHHX0c (ORCPT ); Tue, 8 Aug 2023 19:26:32 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CDBC19BF for ; Tue, 8 Aug 2023 16:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=NsaIqfpGRHhuu1KEMbWRWbIrElmncZ2eWcE/szEec0U=; b=lRAlkGHwHqRqhYDz5CZ6wQhW1H IcmI41Bxr7NnXFiRhoKeqFA8t692165C+ej5ZKP0u3OfaLp5LY5bJiMLZGisVNf1IBP0cFgTBQASI kPidY1gp0VUmAibD2pa7QSVzyCZ1kvNKbo+Kq9m9/SmReKR1Tv5HC74QhsGv1VpN7A4HjrlECX7WI zTccirgNLlkJhEeX6x3+QiiVQV26hVVIpbH/AjjA+LUNRylTtSqnGbfRg21IXEDOthv1Lb6E4WZMZ sIGP2ykAktnq2/yUbhINhqWsz+OCugd519yqsh//OO3phvFUVHUpi5swgNeBpAIihP6NHNfZaWn1o EYPeKDGQ==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qTW5s-003fom-2j; Tue, 08 Aug 2023 23:26:29 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Bhawanpreet Lakha , Harry Wentland , Alex Deucher , Leo Li , Rodrigo Siqueira , amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , dri-devel@lists.freedesktop.org Subject: [PATCH] drm/amd/display: dmub_replay: don't use kernel-doc markers Date: Tue, 8 Aug 2023 16:26:26 -0700 Message-ID: <20230808232627.21168-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773707980848801102 X-GMAIL-MSGID: 1773707980848801102 These functions don't use kernel-doc notation for comments so don't begin each comment block with the "/**" kernel-doc marker. This prevents a bunch of kernel-doc warnings: dmub_replay.c:37: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst dmub_replay.c:37: warning: missing initial short description on line: * Get Replay state from firmware. dmub_replay.c:66: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst dmub_replay.c:66: warning: missing initial short description on line: * Enable/Disable Replay. dmub_replay.c:116: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst dmub_replay.c:116: warning: missing initial short description on line: * Set REPLAY power optimization flags. dmub_replay.c:134: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst dmub_replay.c:134: warning: missing initial short description on line: * Setup Replay by programming phy registers and sending replay hw context values to firmware. and 10 more similar warnings. Fixes: c7ddc0a800bc ("drm/amd/display: Add Functions to enable Freesync Panel Replay") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Link: lore.kernel.org/r/202308081459.US5rLYAY-lkp@intel.com Cc: Bhawanpreet Lakha Cc: Harry Wentland Cc: Alex Deucher Cc: Leo Li Cc: Rodrigo Siqueira Cc: amd-gfx@lists.freedesktop.org Cc: Christian König Cc: "Pan, Xinhui" Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c | 18 ++++++------- 1 file changed, 9 insertions(+), 9 deletions(-) diff -- a/drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c @@ -33,7 +33,7 @@ #define MAX_PIPES 6 -/** +/* * Get Replay state from firmware. */ static void dmub_replay_get_state(struct dmub_replay *dmub, enum replay_state *state, uint8_t panel_inst) @@ -62,7 +62,7 @@ static void dmub_replay_get_state(struct } } -/** +/* * Enable/Disable Replay. */ static void dmub_replay_enable(struct dmub_replay *dmub, bool enable, bool wait, uint8_t panel_inst) @@ -112,7 +112,7 @@ static void dmub_replay_enable(struct dm } -/** +/* * Set REPLAY power optimization flags. */ static void dmub_replay_set_power_opt(struct dmub_replay *dmub, unsigned int power_opt, uint8_t panel_inst) @@ -130,7 +130,7 @@ static void dmub_replay_set_power_opt(st dm_execute_dmub_cmd(dc, &cmd, DM_DMUB_WAIT_TYPE_WAIT); } -/** +/* * Setup Replay by programming phy registers and sending replay hw context values to firmware. */ static bool dmub_replay_copy_settings(struct dmub_replay *dmub, @@ -215,7 +215,7 @@ static bool dmub_replay_copy_settings(st return true; } -/** +/* * Set coasting vtotal. */ static void dmub_replay_set_coasting_vtotal(struct dmub_replay *dmub, @@ -234,7 +234,7 @@ static void dmub_replay_set_coasting_vto dm_execute_dmub_cmd(dc, &cmd, DM_DMUB_WAIT_TYPE_WAIT); } -/** +/* * Get Replay residency from firmware. */ static void dmub_replay_residency(struct dmub_replay *dmub, uint8_t panel_inst, @@ -267,7 +267,7 @@ static const struct dmub_replay_funcs re .replay_residency = dmub_replay_residency, }; -/** +/* * Construct Replay object. */ static void dmub_replay_construct(struct dmub_replay *replay, struct dc_context *ctx) @@ -276,7 +276,7 @@ static void dmub_replay_construct(struct replay->funcs = &replay_funcs; } -/** +/* * Allocate and initialize Replay object. */ struct dmub_replay *dmub_replay_create(struct dc_context *ctx) @@ -293,7 +293,7 @@ struct dmub_replay *dmub_replay_create(s return replay; } -/** +/* * Deallocate Replay object. */ void dmub_replay_destroy(struct dmub_replay **dmub)