From patchwork Tue Aug 8 12:38:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Yingliang X-Patchwork-Id: 132893 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp2413291vqr; Tue, 8 Aug 2023 14:47:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHsOQTC3Pa+ogEzcMs5F6sjMAZYcAuM+E2NjwI51y8Nhnbs9ywjnTzpi9msuXpbN3EGK3B6 X-Received: by 2002:a05:6a00:178c:b0:682:93ce:4825 with SMTP id s12-20020a056a00178c00b0068293ce4825mr14298189pfg.3.1691531267328; Tue, 08 Aug 2023 14:47:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691531267; cv=none; d=google.com; s=arc-20160816; b=Htd5Bq99ZsD+91IkWkssXISs+QutLnwCiKLjl6e+KxCUrXV21Q1czJoGUr7JLGQ15A L3j+0mYXMJGyylNXBCh3z5ywiENhrfaMvmSE/hqsw+1cZ4+uOQ2Ob0kI2+BxQhe3sqK/ Yd5QvSjumXLFzV7uA+i5h/U2S4JnKxS3CptF/c6rqJtku0BOIuPWMqcWQHNUatRww4qT 7HzTn0BOhY0HcwWF/P4+XLvGUpmz7XEYJTRwSguXF84lYwIrdNSfPuep6zYl0pSFW53u +HWLqb3E7ijxcFJAi0qelM3OGjv6De7zaa3ykAnJE27rBM9WF5Z77d6KFyQMNo9iSiA+ Mnxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=a5lsZQ234WNa7vRHKOAh4iXTi2fQTrK+A/ZOJXKqNKg=; fh=S1Cv0Bb0BN2FOhf9YKuttPTBTb+BZYxR/Cjh8KEYS5U=; b=zunOL5ZIRKIVmbM7prrmvJekGrbq2sZRtinIs/M9lE31m5cYvfIkROYzLvRMHUXCBh 9pSgUcb5+gE6+lbh5DAKDLZQq9y7kEN4/0xIX0U0HbEv+ZfBKEQ2SgsS0w2OnSHoWnHu GjXeVTvSeMp8SgKKCMD9UAF+KWHecxyD0MEWO8AK0VKJ5DzXfNMiEaTHzFrJQqgok+oi ELRkwGSF6rE/qG8mUIylYxQATZSqxJK2T8p2MkbG7k1AWLtwDeXQmwC3mozdKX6Y8lPi g0jDf6J6GJnatrAL8iosWF7Ft86vFHbPq9PdsqI2XHVl/ihHqe4KjqqJ5DfexAy7UpIY A2rA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v13-20020a056a00148d00b0068717825fc9si7794180pfu.405.2023.08.08.14.47.35; Tue, 08 Aug 2023 14:47:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232118AbjHHUmv (ORCPT + 99 others); Tue, 8 Aug 2023 16:42:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234353AbjHHUmE (ORCPT ); Tue, 8 Aug 2023 16:42:04 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4FEE7A99 for ; Tue, 8 Aug 2023 10:31:21 -0700 (PDT) Received: from dggpemm100010.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RKt503fjbzNmtq; Tue, 8 Aug 2023 20:37:56 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm100010.china.huawei.com (7.185.36.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 20:41:24 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 20:41:24 +0800 From: Yang Yingliang To: CC: , , Subject: [PATCH -next] uio: pruss: fix missing iounmap() in pruss_probe() Date: Tue, 8 Aug 2023 20:38:27 +0800 Message-ID: <20230808123827.560603-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773699090142631717 X-GMAIL-MSGID: 1773699090142631717 platform_get_irq() is called after ioremap(), if it fails, iounmap() needs be called in error the path. Fixes: 2fd84b9b839c ("uio: pruss: fix to check return value of platform_get_irq() in pruss_probe()") Signed-off-by: Yang Yingliang --- drivers/uio/uio_pruss.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/uio/uio_pruss.c b/drivers/uio/uio_pruss.c index 122c38e2fbbd..77e2dc404885 100644 --- a/drivers/uio/uio_pruss.c +++ b/drivers/uio/uio_pruss.c @@ -177,7 +177,7 @@ static int pruss_probe(struct platform_device *pdev) ret = platform_get_irq(pdev, 0); if (ret < 0) - goto err_free_ddr_vaddr; + goto err_unmap; gdev->hostirq_start = ret; gdev->pintc_base = pdata->pintc_base; @@ -215,6 +215,7 @@ static int pruss_probe(struct platform_device *pdev) for (i = 0, p = gdev->info; i < cnt; i++, p++) { uio_unregister_device(p); } +err_unmap: iounmap(gdev->prussio_vaddr); err_free_ddr_vaddr: dma_free_coherent(dev, extram_pool_sz, gdev->ddr_vaddr,