From patchwork Tue Aug 8 09:16:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 132626 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp2291325vqr; Tue, 8 Aug 2023 10:49:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFd86X1/4EWD3HWhGKsshHDMhU4W6NafTj9b3SjQISr1omMCUEYVIeKqnGSxWCDBXiW2QFX X-Received: by 2002:a05:6a21:3d89:b0:13e:aede:f380 with SMTP id bj9-20020a056a213d8900b0013eaedef380mr205556pzc.34.1691516995242; Tue, 08 Aug 2023 10:49:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691516995; cv=none; d=google.com; s=arc-20160816; b=qL5OdSRzcp3OISMAUQ1q0xUAJrwkxbTOORfEnst409MFIZq+xAyt7FIUar8R0V5vrh MgHs3D5bSeNH46PD8VW6LnayQCGRT/AD3oHBFCRmAk2WBhvx/mbGzk8QIsFdqWiBXtb6 pJxWFEq7i03P8xlo3m/oG2vc0jIIhtbb4a3rZVSuQTVN+P3n1d2B74M1+evE4+p61vDh KIn/SIOKmqCnkX03eXLGDPLfjfsW8KA4aa8cwnFTGjWUhe1o9j8a0m25q2Z6X3g23OEb r9t2fxJiWby9nHysSLAt5f7xn+LmAmEgKda4PqS88RSJRgCyqdG65ZQ7ohLVQT0KmApq yxCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zVp3M31c37kLYiGmaeC20+BXLjRO//z0S3c6b/SZbSc=; fh=WFFiO7tMrl9GCu5CPGkJANwahmVnp1C/K4RUVlAyzx0=; b=Z0loFyM+lnxpvPZ2aVFXKH4v1VLn++5af3NjwSgyX5T4wZvSk7Dqddk0deabia4sHh kfiheisvF9vFOIKjWGq2SJeFXfr2CQfLIld/KiND5GelZxaTnuh2J4YpSrcCLSzq6Vpp l+N+yAjDuHJklWaQbKpGO0E1rBZ9A8u6+vbbCNWh2bTaPnCOmxvVVe/KZAlMZuXsu03y 4QvqUDQaMAYbbl4VPCQUsLNYETWWUNw5/dmlwCbIr613KFZHDO4TzsOPpKUjyp05dVRi o0UskdngeeYLasCDhMgxIj9n9qpasGrVC4B/Rd5kVZV1R4zAqwdwhzbM0slEopWOWag4 QJ/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NKqxWYiY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c37-20020a631c65000000b0055c868268f9si7512347pgm.462.2023.08.08.10.49.42; Tue, 08 Aug 2023 10:49:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NKqxWYiY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233381AbjHHQoi (ORCPT + 99 others); Tue, 8 Aug 2023 12:44:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233311AbjHHQnp (ORCPT ); Tue, 8 Aug 2023 12:43:45 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06DFE91AE; Tue, 8 Aug 2023 08:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691510156; x=1723046156; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rne6Z00MCR3wZ1vIjFslt4JG7P23DQ8pQjYdbPRS0Vg=; b=NKqxWYiY/dDpd3UGIOTjWlIeFzZCm7VI7Kbu4GKD5wOnd2QQQKB2fKnA 3PrbEQi+4mRjDRkSzd8s9Y0yGfKXvKHLHqPdrJpi7DN5uaw71DyU84CdZ fD3gOxWt6gQeVhb+fxjkA8IiH8pzzsXcv7lv0XszozlKo8j2hINIvcl2V ioDCS6rRG3YNzs/wS/qxx/J0bSGCJI14MphXf7gorodIMvDSQC6t3Ktue A9JYCl67rMRi1vZnRSHZKveqQrbjNxC2/EOY7SHvFhJKM/3ZLHPDaSYeU HGtiHUhqHuI2pP9uOlDoz4No0IIWjX6dvT3BPwSXFylso/f5/eoI5djKH Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="437097780" X-IronPort-AV: E=Sophos;i="6.01,263,1684825200"; d="scan'208";a="437097780" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2023 02:16:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="977776813" X-IronPort-AV: E=Sophos;i="6.01,263,1684825200"; d="scan'208";a="977776813" Received: from mtofeni-mobl.ger.corp.intel.com (HELO ijarvine-mobl2.ger.corp.intel.com) ([10.252.48.21]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2023 02:16:41 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: Shuah Khan , linux-kselftest@vger.kernel.org, Shuah Khan , Reinette Chatre , Maciej Wieczor-Retman , Fenghua Yu , Sai Praneeth Prakhya , Babu Moger , linux-kernel@vger.kernel.org Cc: Shaopeng Tan , =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH 1/7] selftests/resctrl: Ensure the benchmark commands fits to its array Date: Tue, 8 Aug 2023 12:16:19 +0300 Message-Id: <20230808091625.12760-2-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230808091625.12760-1-ilpo.jarvinen@linux.intel.com> References: <20230808091625.12760-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773684125086567417 X-GMAIL-MSGID: 1773684125086567417 Benchmark command is copied into an array in the stack. The array is BENCHMARK_ARGS items long but the command line could try to provide a longer command. Return error in case the benchmark command does not fit to its array. Fixes: ecdbb911f22d ("selftests/resctrl: Add MBM test") Signed-off-by: Ilpo Järvinen --- tools/testing/selftests/resctrl/resctrl_tests.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c index d511daeb6851..eef9e02516ad 100644 --- a/tools/testing/selftests/resctrl/resctrl_tests.c +++ b/tools/testing/selftests/resctrl/resctrl_tests.c @@ -255,6 +255,9 @@ int main(int argc, char **argv) return ksft_exit_skip("Not running as root. Skipping...\n"); if (has_ben) { + if (argc - ben_ind >= BENCHMARK_ARGS - 1) + ksft_exit_fail_msg("Too long benchmark command"); + /* Extract benchmark command from command line. */ for (i = ben_ind; i < argc; i++) { benchmark_cmd[i - ben_ind] = benchmark_cmd_area[i];