From patchwork Tue Aug 8 08:32:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sandor Yu X-Patchwork-Id: 132711 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp2325755vqr; Tue, 8 Aug 2023 11:49:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBdrZVN6d/nyY0svi4snRUXSXe+lxDOb/Gc5ieaSYPFuiV+dDj+QHjaxrADyZOP6LB5GBF X-Received: by 2002:a05:6a20:324d:b0:133:b3a9:90d with SMTP id hm13-20020a056a20324d00b00133b3a9090dmr349617pzc.36.1691520564652; Tue, 08 Aug 2023 11:49:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1691520564; cv=pass; d=google.com; s=arc-20160816; b=HlQFv1KK59aBWeIB0nG6IhzIQDsLxaJZuHCrZnuy2ZGG1IL0O/c5YRqmjDaTyzpef/ rUFhc7LkXcR+9FrHGbVX6DbWLgKL29m3tPPvkawgFI2rWoT+NMcN3FDDeHAyTGa0y5FA mZQeBZWm6t1ZiWY0VaczWlexd9O9zCdjr7TL1bx/O5232aMdoP7/HneMr+lAvaUoiJmG wO66NQ9B2h5hbcFDnjGxnmuXL6zHOzRH/6rVgdp9Yhffpf3rZS0rVJyt+BMIHsBknP3L cgDGcknMwIKA7npLIFqo9l7XxGpauy98HF7W4EePAwPaw4gWtMtbgjbc43edoGLmP0zT ZCKg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ijwdeyLNa08NSnsUKg5AfgNvRzY4Cu80iQJCRRRMXtk=; fh=PUBVPucWc8lRluY+e+5uvxRpT/FpFBsE6bTTCuvGxf8=; b=r7L8QPriUTXzEs4CVMk8pHg2zMkB+R8Q5RD+wFHKx/FNUHiPmBjhe8HV0Y2SmzBoT4 FdapTan/i7Qz+M1bj63B3hbeN8/TXOHR3dqwWRT4F6501bdFy1HkAjhxhyVEm0it6TZK aTA8/wGvkTdjHzvfbixA2zAZ9OLcdCWqrm6CLXhMX2R8d7/kcjeRK4F6oJdyb7fzMqvU PsRZon/5rSCkc61HJVmRP3WTMyzTXvZHVjGmEaTQTOXrDpUyt7eSg/eCdu8A/YQMcJFD HhUTT5t9gYVN4wxDS7cwys39io4uqILTlyAJS+sbZ1hsTCdJV9x5R9UTiB6RuT3blVFk t/jA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=jHHBGKHs; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a24-20020a637058000000b005649958b6basi4650216pgn.318.2023.08.08.11.49.11; Tue, 08 Aug 2023 11:49:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=jHHBGKHs; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232473AbjHHQXn (ORCPT + 99 others); Tue, 8 Aug 2023 12:23:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232697AbjHHQWQ (ORCPT ); Tue, 8 Aug 2023 12:22:16 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2049.outbound.protection.outlook.com [40.107.22.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79A129EF2; Tue, 8 Aug 2023 08:49:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iJJ98+15Zdp9N8BeNjzMO5+cg48Z5FQr15qiaHM9A+l8+BXkxtVGz0Pni87dtJbNTAovl0jONXm6P/glnQZ6PSj+q/QBD8+OKyULDW7PyRjAKrODsaTxQM1ohO/Lh640bNB8W9g/Fi3jVnuL4bmAPWeM1XeZENShR4TYBINn0Wb/N49S/EiHTVAHuMapFXee22gZ2J5t8OHLNnEZABQETMvN6/9mfPOeMTGPaWxn5UZW/zvAXyUNTJDzriH8ZLrxj1UAySY4qaHxPyPLO18rW2lYZRh3JFugbTafmOqrwZ3SewlQufta7I7d9Brg2m1xhnkzWLS9maiaQKehUnHOpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ijwdeyLNa08NSnsUKg5AfgNvRzY4Cu80iQJCRRRMXtk=; b=Yw+jSDcQRvB+OYJn5WlJkv8EczI/RWAZ4p80gupv3bF9zB2vXKqRrUDBLvAUeAoh4Hxcxjm7mQzGXmSIOFVsfMTCY0DgBLfdCl5FIv1HuLh6RKQSN7mR42eqv1/CHweVA0p0TDX9xEXfQM1uIF9H8CTtRga3AcIhTy7DRkJE9rl19FcPLqnn65mNck4JA3hOd0NUdukYMHCWu8FVGsPK8PeC4vb6pyh2nc54En9i/fRSmP5A2HtmTSo1ZKY5nkLlP05Ar8pyhCb6V3xAx1wtFzNKJVic/C4krKE99O3+7/1ncZlEMYG5d4HYJabekH/TVs1vutgQAOqhQ4yGQ19whA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ijwdeyLNa08NSnsUKg5AfgNvRzY4Cu80iQJCRRRMXtk=; b=jHHBGKHs93JgIz6D26rza8m1WkN/5oiRvXXJWAk3KT8H5yqHas57qd3RcCEdK4EKkWRpxhi+pMhsvBl9BPV4ucuEAtPuDwychtEn2o8H+wVdjZCfkbrtAH3NyZq2/gbEKiyEeNNPE75IJtwKY+f6h4CbXPufjtS+aPE2MRclA3Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9448.eurprd04.prod.outlook.com (2603:10a6:102:2b1::21) by VE1PR04MB7296.eurprd04.prod.outlook.com (2603:10a6:800:1aa::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 08:33:38 +0000 Received: from PAXPR04MB9448.eurprd04.prod.outlook.com ([fe80::3505:c499:96d4:1429]) by PAXPR04MB9448.eurprd04.prod.outlook.com ([fe80::3505:c499:96d4:1429%4]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 08:33:38 +0000 From: Sandor Yu To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, vkoul@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org Cc: kernel@pengutronix.de, linux-imx@nxp.com, Sandor.yu@nxp.com, oliver.brown@nxp.com, alexander.stein@ew.tq-group.com, sam@ravnborg.org Subject: [PATCH v8 1/7] drm: bridge: Cadence: convert mailbox functions to macro functions Date: Tue, 8 Aug 2023 16:32:37 +0800 Message-Id: <20230808083243.3113192-2-Sandor.yu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808083243.3113192-1-Sandor.yu@nxp.com> References: <20230808083243.3113192-1-Sandor.yu@nxp.com> X-ClientProxiedBy: SI1PR02CA0010.apcprd02.prod.outlook.com (2603:1096:4:1f7::17) To PAXPR04MB9448.eurprd04.prod.outlook.com (2603:10a6:102:2b1::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9448:EE_|VE1PR04MB7296:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d441f7a-a141-4585-2047-08db97ea29e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pkLE7ZRspfOPpxZLGczaDqmOCW/7q7/ZzPSDszSnhl0AUekgdh6niUVvR8tO8XpyUdcmGZDOktr6cpqR5PMtDwz04A/xJx3c92YduqTx2oZg1AZ+bIir07LsJWe8MbPNqEkchnf3IIMoreEofkON1RVgwAWZi8+uQeRJV0Z024ZmMD+OH5n3ksWd6iVs45YyUQceAt87KfTK4/Uf+JAwg9UYBnS+BVKhrG0OVzeLERlpzyeYuU3/le21hW8fEWC6a6ZFr0MXnnOZjA7SPVRFkLDxav0/5hAI2iMVXBUjBDWgo89kEcUqBjIDlUBG3mVcP9oHUhzVAHAMlLMu+qh6In+WnqbrOtgkxJFhkztgBxXSPft/xdUcNRvf6miT3q55BmZed1pxNRl0dMl9l2FyYCAYr34MJjej8Rp8Y3+2XWwFvLosIv8Hv9hE4YI7R9thppH8TCgyzaVnLTmnmK49oLPfUj0ZwyuCbcsNfttRY6q8gpbOiXAqe0jod0T97rHWADsTw9tJ22XJS+tB+fydilQjR8BK63+BvXpKaVnmsbqLBNTsW3bO32yP9lDpy05jdCG9m8ra1pw0ow0ITE8qJiJBJSZsEIMOZnHZdMioqs1aKowh/913vtuBi0guFi96 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9448.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(376002)(39860400002)(366004)(346002)(451199021)(1800799003)(186006)(83380400001)(36756003)(2906002)(5660300002)(2616005)(30864003)(15650500001)(38100700002)(52116002)(38350700002)(6486002)(66476007)(66556008)(921005)(66946007)(6512007)(4326008)(316002)(41300700001)(86362001)(8676002)(26005)(7416002)(1076003)(8936002)(6506007)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ypEshae1EHEVoLqndjt/f55A+ps+ki9J+vE97iPwc3xj4q+MtG3x4TRZPmvge82RpRXC/JjG+Zy2qlz73uv5YTscnkrZexOyMpkVZ2bPZL9Vsp9n9M80wAAr7VPDQ/AVwYyhsqyt+EtZA9wUWsi+cSrLCeGXei2US3uIU2ZevrCpqyZFhKjwBBUmdPWJa8A0+q8SE1n3HIdBfZSuG8Yc5u6aGLUqB6UgjYdoK3LL6HhJ/KT/w3VAqxDSZw1DOHztUyjpOGq4p3eUbSe8AkmwC35ak8tUrmFgO9na94/QSXCAKt458P3dSmcyD0/bAVErgh5fW5LKpZHJA4iWYNd6YE+6FD0cz4huV9BX6g8Wv3P2toAdie15LBrUrtn7C2DbPI8ZdrVS9n8pzecXQ2Pdzmi25XHQUWmhK1gZ6u4Vta6EmE1dxsYtcjLz0XR5w0RMhRHm2L3KiDBAPLRiDJSTdy4iVgvi7+VTqCQukN7h4eytewAT8sFqKFviOsxr8yors+tJW3k7rJKx7B8iMatXpC2xIguKXihLsgTz6dWQg3L5VdjhTMTBNC/fR+8JIo3Q01erjnXqSFP3PhcPExMYyUniOv+isIJY2U7SDaGfaKecKobQNeaaTjy1VNhsgzg5xbGEVOVeatx6goe4g5ujhII7euyUfCBOSIXgK9dcsoI/6Wr9NL9aBO5paNcLy0Fc5g9bVLnv9w77t+vFXde+X/XjRWmsskSGBHkQGaXt8Hm3qUlgTC3i+x1tP7IqiTe0Fqkgy9hv7/pXYEn6oTTqw4XgEKkrguwNyjY2e+Mz2QxaOjvxn1TtlAwMYiliEb54M3NPf/ni3diAs0md3S0jFBJe71WRp0JNGHqpE/do+uu0JXCarJ6EYDSOg5q2YpKjYZ1HyenKuUFOydjfIEb+fndGS+Qoh0n/U5RVA92hlyEfiuLJWCQ4M5JJzej/lqpQ/9q7h8ZheICcojcZ3mSEXXiH/yj4Rs/Fl3hApOAHQC2WxwCrs/lE3sWwnIXx6yZAIKTcG4zcmfedwGY1ZeoC6L3je4UyApGoT5uGKL/MGK7epLj9GXuBb9oeBANUpy+Q+tcFAhLVRMtK00743Gd0m2fulYXLu3kmasZtxRwMft60ancBMRyaHGhUNTaVIIGyzKJU3xjnlaNdWL1T8i5ngmk7vD/qbNqbsdoDUEQkLvdgeAcsjzm2Q7kPG5aGDVRdOekaVAk0U6utVwrlUp018faqzmlKbs5ArBCxBNUNqiu+M3x9mB7xzYajPiNH14uXzeevofeDaKtLeOOLKRy7amdGaWdu7TWM8tLX3qovPvdfP+GyiEjLpbmOJznEkXUlH1z2kSh1xcyHSeaA95Wd1gKs/nYOuMfn1P5HMDRY9rK9su9dy1tK/4k5i7Sk3zaOSAaYULUJ+mlceS2Tm4R3S5W9bvIZGywfwnxl4VM5KDoP2mCfSrXfB1Kf0nPAmFilt1E3IxOKy1jYfCAQkSzJrshiDQb+inBBOXrDCVSDoRyHCfkyGyYjnA0iGprLhot/YgbRmrtscDkGPf70WLrJdXraMQNoNOJdP5aT8CjJZ7AGkIkNrWq8t8tJYqyt4h10 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d441f7a-a141-4585-2047-08db97ea29e3 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9448.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 08:33:38.6527 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ny6IV4ggq+h5jT+hhq2RRZ3vkOBVGx9Q+zdE9zbfVFw6jbBT+6IjFpL6m8/+f7hha/yiTLRos5rczgV1mZ0BiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7296 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773687867624561581 X-GMAIL-MSGID: 1773687867624561581 MHDP8546 mailbox access functions will be share to other mhdp driver and Cadence HDP-TX HDMI/DP PHY drivers. Move those functions to head file include/drm/bridge/cdns-mhdp-mailbox.h and convert them to macro functions. Signed-off-by: Sandor Yu --- .../drm/bridge/cadence/cdns-mhdp8546-core.c | 195 +------------- .../drm/bridge/cadence/cdns-mhdp8546-core.h | 1 - include/drm/bridge/cdns-mhdp-mailbox.h | 240 ++++++++++++++++++ 3 files changed, 241 insertions(+), 195 deletions(-) create mode 100644 include/drm/bridge/cdns-mhdp-mailbox.h diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c index f6822dfa3805..ddd3c633c7bf 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c @@ -36,6 +36,7 @@ #include #include +#include #include #include #include @@ -54,200 +55,6 @@ #include "cdns-mhdp8546-hdcp.h" #include "cdns-mhdp8546-j721e.h" -static int cdns_mhdp_mailbox_read(struct cdns_mhdp_device *mhdp) -{ - int ret, empty; - - WARN_ON(!mutex_is_locked(&mhdp->mbox_mutex)); - - ret = readx_poll_timeout(readl, mhdp->regs + CDNS_MAILBOX_EMPTY, - empty, !empty, MAILBOX_RETRY_US, - MAILBOX_TIMEOUT_US); - if (ret < 0) - return ret; - - return readl(mhdp->regs + CDNS_MAILBOX_RX_DATA) & 0xff; -} - -static int cdns_mhdp_mailbox_write(struct cdns_mhdp_device *mhdp, u8 val) -{ - int ret, full; - - WARN_ON(!mutex_is_locked(&mhdp->mbox_mutex)); - - ret = readx_poll_timeout(readl, mhdp->regs + CDNS_MAILBOX_FULL, - full, !full, MAILBOX_RETRY_US, - MAILBOX_TIMEOUT_US); - if (ret < 0) - return ret; - - writel(val, mhdp->regs + CDNS_MAILBOX_TX_DATA); - - return 0; -} - -static int cdns_mhdp_mailbox_recv_header(struct cdns_mhdp_device *mhdp, - u8 module_id, u8 opcode, - u16 req_size) -{ - u32 mbox_size, i; - u8 header[4]; - int ret; - - /* read the header of the message */ - for (i = 0; i < sizeof(header); i++) { - ret = cdns_mhdp_mailbox_read(mhdp); - if (ret < 0) - return ret; - - header[i] = ret; - } - - mbox_size = get_unaligned_be16(header + 2); - - if (opcode != header[0] || module_id != header[1] || - req_size != mbox_size) { - /* - * If the message in mailbox is not what we want, we need to - * clear the mailbox by reading its contents. - */ - for (i = 0; i < mbox_size; i++) - if (cdns_mhdp_mailbox_read(mhdp) < 0) - break; - - return -EINVAL; - } - - return 0; -} - -static int cdns_mhdp_mailbox_recv_data(struct cdns_mhdp_device *mhdp, - u8 *buff, u16 buff_size) -{ - u32 i; - int ret; - - for (i = 0; i < buff_size; i++) { - ret = cdns_mhdp_mailbox_read(mhdp); - if (ret < 0) - return ret; - - buff[i] = ret; - } - - return 0; -} - -static int cdns_mhdp_mailbox_send(struct cdns_mhdp_device *mhdp, u8 module_id, - u8 opcode, u16 size, u8 *message) -{ - u8 header[4]; - int ret, i; - - header[0] = opcode; - header[1] = module_id; - put_unaligned_be16(size, header + 2); - - for (i = 0; i < sizeof(header); i++) { - ret = cdns_mhdp_mailbox_write(mhdp, header[i]); - if (ret) - return ret; - } - - for (i = 0; i < size; i++) { - ret = cdns_mhdp_mailbox_write(mhdp, message[i]); - if (ret) - return ret; - } - - return 0; -} - -static -int cdns_mhdp_reg_read(struct cdns_mhdp_device *mhdp, u32 addr, u32 *value) -{ - u8 msg[4], resp[8]; - int ret; - - put_unaligned_be32(addr, msg); - - mutex_lock(&mhdp->mbox_mutex); - - ret = cdns_mhdp_mailbox_send(mhdp, MB_MODULE_ID_GENERAL, - GENERAL_REGISTER_READ, - sizeof(msg), msg); - if (ret) - goto out; - - ret = cdns_mhdp_mailbox_recv_header(mhdp, MB_MODULE_ID_GENERAL, - GENERAL_REGISTER_READ, - sizeof(resp)); - if (ret) - goto out; - - ret = cdns_mhdp_mailbox_recv_data(mhdp, resp, sizeof(resp)); - if (ret) - goto out; - - /* Returned address value should be the same as requested */ - if (memcmp(msg, resp, sizeof(msg))) { - ret = -EINVAL; - goto out; - } - - *value = get_unaligned_be32(resp + 4); - -out: - mutex_unlock(&mhdp->mbox_mutex); - if (ret) { - dev_err(mhdp->dev, "Failed to read register\n"); - *value = 0; - } - - return ret; -} - -static -int cdns_mhdp_reg_write(struct cdns_mhdp_device *mhdp, u16 addr, u32 val) -{ - u8 msg[6]; - int ret; - - put_unaligned_be16(addr, msg); - put_unaligned_be32(val, msg + 2); - - mutex_lock(&mhdp->mbox_mutex); - - ret = cdns_mhdp_mailbox_send(mhdp, MB_MODULE_ID_DP_TX, - DPTX_WRITE_REGISTER, sizeof(msg), msg); - - mutex_unlock(&mhdp->mbox_mutex); - - return ret; -} - -static -int cdns_mhdp_reg_write_bit(struct cdns_mhdp_device *mhdp, u16 addr, - u8 start_bit, u8 bits_no, u32 val) -{ - u8 field[8]; - int ret; - - put_unaligned_be16(addr, field); - field[2] = start_bit; - field[3] = bits_no; - put_unaligned_be32(val, field + 4); - - mutex_lock(&mhdp->mbox_mutex); - - ret = cdns_mhdp_mailbox_send(mhdp, MB_MODULE_ID_DP_TX, - DPTX_WRITE_FIELD, sizeof(field), field); - - mutex_unlock(&mhdp->mbox_mutex); - - return ret; -} - static int cdns_mhdp_dpcd_read(struct cdns_mhdp_device *mhdp, u32 addr, u8 *data, u16 len) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h index bedddd510d17..10c878bf0e63 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h @@ -212,7 +212,6 @@ struct phy; #define MB_MODULE_ID_HDCP_TX 0x07 #define MB_MODULE_ID_HDCP_RX 0x08 #define MB_MODULE_ID_HDCP_GENERAL 0x09 -#define MB_MODULE_ID_GENERAL 0x0a /* firmware and opcodes */ #define FW_NAME "cadence/mhdp8546.bin" diff --git a/include/drm/bridge/cdns-mhdp-mailbox.h b/include/drm/bridge/cdns-mhdp-mailbox.h new file mode 100644 index 000000000000..9f551bf956a1 --- /dev/null +++ b/include/drm/bridge/cdns-mhdp-mailbox.h @@ -0,0 +1,240 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Cadence MHDP Firmware Access API function by Malibox. + * + * Copyright (C) 2022 NXP Semiconductor, Inc. + * + */ +#ifndef CDNS_MHDP_MAILBOX_H +#define CDNS_MHDP_MAILBOX_H + +#include +#include + +/* mailbox regs offset */ +#define CDNS_MAILBOX_FULL 0x00008 +#define CDNS_MAILBOX_EMPTY 0x0000c +#define CDNS_MAILBOX_TX_DATA 0x00010 +#define CDNS_MAILBOX_RX_DATA 0x00014 + +#define MAILBOX_RETRY_US 1000 +#define MAILBOX_TIMEOUT_US 2000000 + +/* Module ID Code */ +#define MB_MODULE_ID_GENERAL 0x0A +#define MB_MODULE_ID_DP_TX 0x01 + +/* General Commands */ +#define GENERAL_REGISTER_WRITE 0x05 +#define GENERAL_REGISTER_READ 0x07 + +/* DP TX Command */ +#define DPTX_WRITE_FIELD 0x08 + +/* MHDP Firmware access functions by Mailbox */ +#define cdns_mhdp_mailbox_read(_mhdp) \ +({ \ + int ret, empty, val; \ +\ + WARN_ON(!mutex_is_locked(&(_mhdp)->mbox_mutex)); \ +\ + do { \ + ret = readx_poll_timeout(readl, (_mhdp)->regs + CDNS_MAILBOX_EMPTY, \ + empty, !empty, MAILBOX_RETRY_US, \ + MAILBOX_TIMEOUT_US); \ + if (ret < 0) \ + break; \ +\ + val = readl((_mhdp)->regs + CDNS_MAILBOX_RX_DATA) & 0xff; \ + } while (0); \ +\ + (ret < 0) ? ret : val; \ +}) + +#define cdns_mhdp_mailbox_write(_mhdp, _val) \ +({ \ + int ret, full; \ +\ + WARN_ON(!mutex_is_locked(&(_mhdp)->mbox_mutex)); \ +\ + do { \ + ret = readx_poll_timeout(readl, (_mhdp)->regs + CDNS_MAILBOX_FULL, \ + full, !full, MAILBOX_RETRY_US, \ + MAILBOX_TIMEOUT_US); \ + if (ret < 0) \ + break; \ +\ + writel((_val), (_mhdp)->regs + CDNS_MAILBOX_TX_DATA); \ + } while (0); \ +\ + ret; \ +}) + +#define cdns_mhdp_mailbox_recv_header(_mhdp, _module_id, _opcode, _req_size) \ +({ \ + u32 mbox_size, i; \ + u8 header[4]; \ + int ret; \ +\ + do { \ + /* read the header of the message */ \ + for (i = 0; i < sizeof(header); i++) { \ + ret = cdns_mhdp_mailbox_read(_mhdp); \ + if (ret < 0) \ + break; \ +\ + header[i] = ret; \ + } \ +\ + mbox_size = get_unaligned_be16(header + 2); \ +\ + if ((_opcode) != header[0] || (_module_id) != header[1] || \ + (_req_size) != mbox_size) { \ + /* If the message in mailbox is not what we want, we need to + * clear the mailbox by reading its contents. */ \ + for (i = 0; i < mbox_size; i++) \ + if (cdns_mhdp_mailbox_read(_mhdp) < 0) \ + break; \ +\ + ret = -EINVAL; \ + } \ +\ + ret = 0; \ +\ + } while (0); \ +\ + ret; \ +}) + +#define cdns_mhdp_mailbox_recv_data(_mhdp, _buff, _buff_size) \ +({ \ + u32 i; \ + int ret; \ +\ + do { \ + for (i = 0; i < (_buff_size); i++) { \ + ret = cdns_mhdp_mailbox_read(_mhdp); \ + if (ret < 0) \ + break; \ +\ + ((u8 *)_buff)[i] = ret; \ + } \ +\ + ret = 0; \ +\ + } while (0); \ +\ + ret; \ +}) + +#define cdns_mhdp_mailbox_send(_mhdp, _module_id, _opcode, _size, _message) \ +({ \ + u8 header[4]; \ + int ret, i; \ +\ + header[0] = _opcode; \ + header[1] = _module_id; \ + put_unaligned_be16(_size, header + 2); \ +\ + do { \ + for (i = 0; i < sizeof(header); i++) { \ + ret = cdns_mhdp_mailbox_write(_mhdp, header[i]); \ + if (ret < 0) \ + break; \ + } \ +\ + for (i = 0; i < _size; i++) { \ + ret = cdns_mhdp_mailbox_write(_mhdp, ((u8 *)_message)[i]); \ + if (ret < 0) \ + break;; \ + } \ + ret = 0; \ + } while (0); \ +\ + ret; \ +}) + +#define cdns_mhdp_reg_read(_mhdp, _addr, _value) \ +({ \ + u8 msg[4], resp[8]; \ + int ret; \ +\ + put_unaligned_be32(_addr, msg); \ +\ + mutex_lock(&(_mhdp)->mbox_mutex); \ +\ + do { \ + ret = cdns_mhdp_mailbox_send(_mhdp, MB_MODULE_ID_GENERAL, \ + GENERAL_REGISTER_READ, \ + sizeof(msg), msg); \ + if (ret < 0) \ + break; \ +\ + ret = cdns_mhdp_mailbox_recv_header(_mhdp, MB_MODULE_ID_GENERAL, \ + GENERAL_REGISTER_READ, \ + sizeof(resp)); \ + if (ret < 0) \ + break; \ +\ + ret = cdns_mhdp_mailbox_recv_data(_mhdp, resp, sizeof(resp)); \ + if (ret < 0) \ + break; \ +\ + /* Returned address value should be the same as requested */ \ + if (memcmp(msg, resp, sizeof(msg))) { \ + ret = -EINVAL; \ + break; \ + } \ +\ + *((u32 *)_value) = get_unaligned_be32(resp + 4); \ + ret = 0; \ + } while (0); \ +\ + mutex_unlock(&(_mhdp)->mbox_mutex); \ + if (ret < 0) { \ + dev_err((_mhdp)->dev, "Failed to read register\n"); \ + *((u32 *)_value) = 0; \ + } \ +\ + ret; \ +}) + +#define cdns_mhdp_reg_write(_mhdp, _addr, _val) \ +({ \ + u8 msg[8]; \ + int ret; \ +\ + put_unaligned_be32(_addr, msg); \ + put_unaligned_be32(_val, msg + 4); \ +\ + mutex_lock(&(_mhdp)->mbox_mutex); \ +\ + ret = cdns_mhdp_mailbox_send(_mhdp, MB_MODULE_ID_GENERAL, \ + GENERAL_REGISTER_WRITE, sizeof(msg), msg); \ +\ + mutex_unlock(&(_mhdp)->mbox_mutex); \ +\ + ret; \ +}) + +#define cdns_mhdp_reg_write_bit(_mhdp, _addr, _start_bit, _bits_no, _val) \ +({ \ + u8 field[8]; \ + int ret; \ +\ + put_unaligned_be16(_addr, field); \ + field[2] = _start_bit; \ + field[3] = _bits_no; \ + put_unaligned_be32(_val, field + 4); \ +\ + mutex_lock(&(_mhdp)->mbox_mutex); \ +\ + ret = cdns_mhdp_mailbox_send((_mhdp), MB_MODULE_ID_DP_TX, \ + DPTX_WRITE_FIELD, sizeof(field), field); \ +\ + mutex_unlock(&(_mhdp)->mbox_mutex); \ +\ + ret; \ +}) + +#endif