| Message ID | 20230808061150.81491-2-jiajie.ho@starfivetech.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp2241262vqr;
Tue, 8 Aug 2023 09:34:09 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IFvZfJ2hkaYewkt0v9aaItzEwrVpjWOODd7cbSGeLKfBBJP1cZBIo9QtrUgGbFGZlOLMXuI
X-Received: by 2002:a50:fa90:0:b0:522:1e24:afb6 with SMTP id
w16-20020a50fa90000000b005221e24afb6mr311994edr.0.1691512448948;
Tue, 08 Aug 2023 09:34:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1691512448; cv=none;
d=google.com; s=arc-20160816;
b=EJxFhQwKtNxr5TqFU/f4msGdX9aCaYKveeHPWjK7iNvl8MppBeSC+aUXBK1PSFHEgq
oOPKfh/Zi+sjbPuyyvGI8ZX5hJQoDCFs0bKaWZtpXiEELcOsR1CjI5w8FPpasZHrOOms
jymAyBcn2b+g1cTk9BbbnFvbHrpkW/5JyMelKYY6X4T7KMFeRUa0wbw2OuLqGC0mWifK
WkrzcarqtGN12ViEyIU98ep1w1gm71uuHAiBtvqgzDz8nMndl2oCRwE9JK41bqdHh7W/
XNzsiHrnBGWP1Gw+XyGUYPOW3LBTgJGtOfeJ9euF2OGPiDu999Dx36UKG0TcdKfy4+rM
JUVA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=2PxFRAixyGmV7E+dV3sZ8ziB/raY8Nuz20l0CsUneuc=;
fh=TXbY++qKaMPehpqjmCqcipr7y1LN1goAfRQSMbp5LiI=;
b=mWOmkGdI7bYqxHgFVrzCgdlNEVcPk3YM6ynVvAVFVmYj6VDLkLbk3dJiZCSsrrLRJe
tIppvB6FMyFoP77uDb61eMosgSVOS1IwHxDX8KFhAy4t5/W5FnXF+i6q1i/YV3c9KqvD
RCrK0MlKrfSqXZd1+fL1sa77NDPP9UnJPrulJ50IBUBbFHrPDQUVHTYrQF/J3+4lQTAr
SdZSwwWoZJP0NMrN1IVgCTZ5gt4U8enJI9tKNr53YPD0/JHWlpKYzb0s5xN+eHrpywGy
T44YxCLGrMU0ivgN1951Z3by7kPV68+mlsv3867CPoupP64+lMI/QYIi5hX33vlFLQCs
D0Fg==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
u24-20020a056402065800b005234dee720dsi270410edx.226.2023.08.08.09.33.45;
Tue, 08 Aug 2023 09:34:08 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229790AbjHHPkp convert rfc822-to-8bit (ORCPT
<rfc822;aaronkmseo@gmail.com> + 99 others);
Tue, 8 Aug 2023 11:40:45 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38464 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229491AbjHHPkg (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 8 Aug 2023 11:40:36 -0400
Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7544106;
Tue, 8 Aug 2023 08:36:28 -0700 (PDT)
Received: from EXMBX165.cuchost.com (unknown [175.102.18.54])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(Client CN "EXMBX165", Issuer "EXMBX165" (not verified))
by ex01.ufhost.com (Postfix) with ESMTP id 3F9E524E287;
Tue, 8 Aug 2023 14:12:03 +0800 (CST)
Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX165.cuchost.com
(172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 8 Aug
2023 14:12:03 +0800
Received: from ubuntu.localdomain (202.188.176.82) by EXMBX068.cuchost.com
(172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 8 Aug
2023 14:11:58 +0800
From: Jia Jie Ho <jiajie.ho@starfivetech.com>
To: Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
CC: <devicetree@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] riscv: dts: starfive - Add crypto and DMA node for JH7110
Date: Tue, 8 Aug 2023 14:11:49 +0800
Message-ID: <20230808061150.81491-2-jiajie.ho@starfivetech.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20230808061150.81491-1-jiajie.ho@starfivetech.com>
References: <20230808061150.81491-1-jiajie.ho@starfivetech.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [202.188.176.82]
X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX068.cuchost.com
(172.16.6.68)
X-YovoleRuleAgent: yovoleflag
Content-Transfer-Encoding: 8BIT
X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED,
SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1773679357408595996
X-GMAIL-MSGID: 1773679357408595996
|
| Series |
riscv: dts: starfive - Add crypto and trng node
|
|
Commit Message
JiaJie Ho
Aug. 8, 2023, 6:11 a.m. UTC
Add hardware crypto module and dedicated dma controller node to StarFive JH7110 SoC. Co-developed-by: Huan Feng <huan.feng@starfivetech.com> Signed-off-by: Huan Feng <huan.feng@starfivetech.com> Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com> Acked-by: Palmer Dabbelt <palmer@rivosinc.com> --- arch/riscv/boot/dts/starfive/jh7110.dtsi | 28 ++++++++++++++++++++++++ 1 file changed, 28 insertions(+)
Comments
On Tue, Aug 08, 2023 at 02:11:49PM +0800, Jia Jie Ho wrote: > Add hardware crypto module and dedicated dma controller node to StarFive > JH7110 SoC. > > Co-developed-by: Huan Feng <huan.feng@starfivetech.com> > Signed-off-by: Huan Feng <huan.feng@starfivetech.com> > Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com> > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > --- > arch/riscv/boot/dts/starfive/jh7110.dtsi | 28 ++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi > index a608433200e8..47cd12ccc988 100644 > --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi > +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi > @@ -821,6 +821,34 @@ watchdog@13070000 { > <&syscrg JH7110_SYSRST_WDT_CORE>; > }; > > + crypto: crypto@16000000 { > + compatible = "starfive,jh7110-crypto"; > + reg = <0x0 0x16000000 0x0 0x4000>; > + clocks = <&stgcrg JH7110_STGCLK_SEC_AHB>, > + <&stgcrg JH7110_STGCLK_SEC_MISC_AHB>; > + clock-names = "hclk", "ahb"; > + interrupts = <28>; > + resets = <&stgcrg JH7110_STGRST_SEC_AHB>; > + dmas = <&sdma 1 2>, <&sdma 0 2>; > + dma-names = "tx", "rx"; > + }; > + > + sdma: dma@16008000 { > + compatible = "arm,pl080", "arm,primecell"; > + arm,primecell-periphid = <0x00041080>; > + reg = <0x0 0x16008000 0x0 0x4000>; > + interrupts = <29>; > + clocks = <&stgcrg JH7110_STGCLK_SEC_AHB>, > + <&stgcrg JH7110_STGCLK_SEC_MISC_AHB>; > + clock-names = "hclk", "apb_pclk"; > + resets = <&stgcrg JH7110_STGRST_SEC_AHB>; > + lli-bus-interface-ahb1; > + mem-bus-interface-ahb1; > + memcpy-burst-size = <256>; > + memcpy-bus-width = <32>; > + #dma-cells = <2>; > + }; > + Against linux-next, I get these warnings: arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: $nodename:0: 'dma@16008000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: clocks: [[26, 15], [26, 16]] is too long from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: clock-names: ['hclk', 'apb_pclk'] is too long from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: Unevaluated properties are not allowed ('#dma-cells' was unexpected) from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: $nodename:0: 'dma@16008000' does not match '^dma-controller(@.*)?$' from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: clocks: [[26, 15], [26, 16]] is too long from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: clock-names: ['hclk', 'apb_pclk'] is too long from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: Unevaluated properties are not allowed ('#dma-cells' was unexpected) from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# Please fix these & submit a tested v2. Thanks, Conor.
On 8/8/2023 3:16 pm, Conor Dooley wrote: > On Tue, Aug 08, 2023 at 02:11:49PM +0800, Jia Jie Ho wrote: >> Add hardware crypto module and dedicated dma controller node to StarFive >> JH7110 SoC. >> >> Co-developed-by: Huan Feng <huan.feng@starfivetech.com> >> Signed-off-by: Huan Feng <huan.feng@starfivetech.com> >> Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com> >> Acked-by: Palmer Dabbelt <palmer@rivosinc.com> >> --- >> arch/riscv/boot/dts/starfive/jh7110.dtsi | 28 ++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi >> index a608433200e8..47cd12ccc988 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi >> @@ -821,6 +821,34 @@ watchdog@13070000 { >> <&syscrg JH7110_SYSRST_WDT_CORE>; >> }; >> >> + crypto: crypto@16000000 { >> + compatible = "starfive,jh7110-crypto"; >> + reg = <0x0 0x16000000 0x0 0x4000>; >> + clocks = <&stgcrg JH7110_STGCLK_SEC_AHB>, >> + <&stgcrg JH7110_STGCLK_SEC_MISC_AHB>; >> + clock-names = "hclk", "ahb"; >> + interrupts = <28>; >> + resets = <&stgcrg JH7110_STGRST_SEC_AHB>; >> + dmas = <&sdma 1 2>, <&sdma 0 2>; >> + dma-names = "tx", "rx"; >> + }; >> + >> + sdma: dma@16008000 { >> + compatible = "arm,pl080", "arm,primecell"; >> + arm,primecell-periphid = <0x00041080>; >> + reg = <0x0 0x16008000 0x0 0x4000>; >> + interrupts = <29>; >> + clocks = <&stgcrg JH7110_STGCLK_SEC_AHB>, >> + <&stgcrg JH7110_STGCLK_SEC_MISC_AHB>; >> + clock-names = "hclk", "apb_pclk"; >> + resets = <&stgcrg JH7110_STGRST_SEC_AHB>; >> + lli-bus-interface-ahb1; >> + mem-bus-interface-ahb1; >> + memcpy-burst-size = <256>; >> + memcpy-bus-width = <32>; >> + #dma-cells = <2>; >> + }; >> + > > Against linux-next, I get these warnings: > arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: $nodename:0: 'dma@16008000' does not match '^dma-controller(@.*)?$' > from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# > arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: clocks: [[26, 15], [26, 16]] is too long > from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# > arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: clock-names: ['hclk', 'apb_pclk'] is too long > from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# > arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: Unevaluated properties are not allowed ('#dma-cells' was unexpected) > from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# > arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: $nodename:0: 'dma@16008000' does not match '^dma-controller(@.*)?$' > from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# > arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: clocks: [[26, 15], [26, 16]] is too long > from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# > arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: clock-names: ['hclk', 'apb_pclk'] is too long > from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# > arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: Unevaluated properties are not allowed ('#dma-cells' was unexpected) > from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml# > > Please fix these & submit a tested v2. > Sorry, I missed testing the dma node. Will fix this in next version. Regards, Jia Jie
diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi index a608433200e8..47cd12ccc988 100644 --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi @@ -821,6 +821,34 @@ watchdog@13070000 { <&syscrg JH7110_SYSRST_WDT_CORE>; }; + crypto: crypto@16000000 { + compatible = "starfive,jh7110-crypto"; + reg = <0x0 0x16000000 0x0 0x4000>; + clocks = <&stgcrg JH7110_STGCLK_SEC_AHB>, + <&stgcrg JH7110_STGCLK_SEC_MISC_AHB>; + clock-names = "hclk", "ahb"; + interrupts = <28>; + resets = <&stgcrg JH7110_STGRST_SEC_AHB>; + dmas = <&sdma 1 2>, <&sdma 0 2>; + dma-names = "tx", "rx"; + }; + + sdma: dma@16008000 { + compatible = "arm,pl080", "arm,primecell"; + arm,primecell-periphid = <0x00041080>; + reg = <0x0 0x16008000 0x0 0x4000>; + interrupts = <29>; + clocks = <&stgcrg JH7110_STGCLK_SEC_AHB>, + <&stgcrg JH7110_STGCLK_SEC_MISC_AHB>; + clock-names = "hclk", "apb_pclk"; + resets = <&stgcrg JH7110_STGRST_SEC_AHB>; + lli-bus-interface-ahb1; + mem-bus-interface-ahb1; + memcpy-burst-size = <256>; + memcpy-bus-width = <32>; + #dma-cells = <2>; + }; + gmac0: ethernet@16030000 { compatible = "starfive,jh7110-dwmac", "snps,dwmac-5.20"; reg = <0x0 0x16030000 0x0 0x10000>;