| Message ID | 20230808034836.418485-1-xry111@xry111.site |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp2277584vqr;
Tue, 8 Aug 2023 10:26:44 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IG5k6StAxztRHywvQxPMyrO2EfgBRhY5Kp1a/Y1mNaC29jSa6rChQX9lKuih17ImWHydYBN
X-Received: by 2002:a17:902:7446:b0:1bb:b91b:2b3c with SMTP id
e6-20020a170902744600b001bbb91b2b3cmr416399plt.34.1691515603970;
Tue, 08 Aug 2023 10:26:43 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1691515603; cv=none;
d=google.com; s=arc-20160816;
b=bY7tt0X4QI9QSyH1uyGLNXe8gbRtr6IlqA9DX0/ZGkTrWl/GXwhkMwut5dJ4auoPOR
ipISrgfKXyAu05LEdt5QisR3fwWrjOvYOYa4PaWyLJeCP+JCqK121HvnWaILqYqRNuEE
qzjSP/3ihbOIekZ12rgv6wXODMJ6wEzxGwHXfjzDHw5N30v3XpcyF7YqfsIq3wB8Mlb7
2Wh5zpsHuiFoCDWMggpb1eUJyLhej3jK7vtKQG9in6sW/U/MrjaceMTnPgvKhZ9KzEYF
cPIseutjVFgkTEB0Zdsfw3It7E56NwWmciIahhcvSLfE1L8EXHKwbtwry0RcYBNI2CeE
FX9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=2dTMI+19/k5yIlj2JVq94dS9Fbd+6dEcghM3nWjgRRk=;
fh=6JKdsn9+I1AGKX4qQd3LK11YklM5TK/L2C9g34r10Pk=;
b=D2iouSaq/6VMkDNvE0VemhJxo45JjgGNAwEPdowNK5nTqbMQdUCmmX08lLvWhlzPTk
LbydVnBso9em9HROT61kjRpPYg26uiH19XYRTHOy7sqg5xRQkreAFmFHEd0lhGYdWEbJ
id15p6NugySHxLdcIVwq7f3rI0PLrYRSmjZ98hul26nKAdSuJ/YbISypijuqropKR/qZ
jElZwaxj9Vx54KuVD3Q+qqctnAIV+AVx0La9coP+ApuQ2+hoi/t1qb9XbCits7U3/6Ci
p4yGktzFvETT8USKvme72q91EZdUzkW7KVw+VVifHS4Dwmgm/G0U7wLlnC7fUy1N2p3Z
O1mw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@xry111.site header.s=default header.b=nmikUyo6;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=xry111.site
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
ku8-20020a170903288800b001b887c89a8dsi7343895plb.521.2023.08.08.10.25.40;
Tue, 08 Aug 2023 10:26:43 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@xry111.site header.s=default header.b=nmikUyo6;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=xry111.site
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231362AbjHHQCg (ORCPT <rfc822;aaronkmseo@gmail.com> + 99 others);
Tue, 8 Aug 2023 12:02:36 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57482 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231192AbjHHQAx (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 8 Aug 2023 12:00:53 -0400
Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 449D82722
for <linux-kernel@vger.kernel.org>;
Mon, 7 Aug 2023 20:49:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site;
s=default; t=1691466539;
bh=nrjRfO2+8JOw7uXLUstSS+xBnROqeg8OtCZsp2REDi8=;
h=From:To:Cc:Subject:Date:From;
b=nmikUyo6ANVQRpzNd5RQRw5eTFORUQs/zVrRNxOmjGfGT2LWUlo+kC3W9ZXC0wWRc
Pl0NemD2/IytDHtKN7m3q99IHP3MX60ZZIk8ZTg6+EgFJhMCokCXo7y7ySL5DmaWQV
rEPZkwceGYZ4QTYm+mw3HaltCbjOocDPPXjzMoOs=
Received: from stargazer.. (unknown
[IPv6:2409:8a0c:2a4:2170:40dc:a500:81f0:2])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature ECDSA (P-384) server-digest
SHA384)
(Client did not present a certificate)
(Authenticated sender: xry111@xry111.site)
by xry111.site (Postfix) with ESMTPSA id 4A2AD659C0;
Mon, 7 Aug 2023 23:48:55 -0400 (EDT)
From: Xi Ruoyao <xry111@xry111.site>
To: loongarch@lists.linux.dev
Cc: Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>, linux-kernel@vger.kernel.org,
Xi Ruoyao <xry111@xry111.site>
Subject: [PATCH] loongarch: Remove spurious "source drivers/firmware/Kconfig"
Date: Tue, 8 Aug 2023 11:48:36 +0800
Message-ID: <20230808034836.418485-1-xry111@xry111.site>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1773682665455557085
X-GMAIL-MSGID: 1773682665455557085
|
| Series |
loongarch: Remove spurious "source drivers/firmware/Kconfig"
|
|
Commit Message
Xi Ruoyao
Aug. 8, 2023, 3:48 a.m. UTC
In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all ports so
there is no need to source it in the port-specific Kconfig file. And
sourcing it here also caused the "Firmware Drivers" menu appeared two
times: once in the "Device Drivers" menu, another time in the toplevel
menu. This was really puzzling.
Signed-off-by: Xi Ruoyao <xry111@xry111.site>
---
arch/loongarch/Kconfig | 2 --
1 file changed, 2 deletions(-)
Comments
Hi, Ruoyao, I think the title should be "LoongArch: Remove redundant "source drivers/firmware/Kconfig""? Huacai On Tue, Aug 8, 2023 at 11:49 AM Xi Ruoyao <xry111@xry111.site> wrote: > > In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all ports so > there is no need to source it in the port-specific Kconfig file. And > sourcing it here also caused the "Firmware Drivers" menu appeared two > times: once in the "Device Drivers" menu, another time in the toplevel > menu. This was really puzzling. > > Signed-off-by: Xi Ruoyao <xry111@xry111.site> > --- > arch/loongarch/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig > index e71d5bf2cee0..465759f6b0ed 100644 > --- a/arch/loongarch/Kconfig > +++ b/arch/loongarch/Kconfig > @@ -662,5 +662,3 @@ source "kernel/power/Kconfig" > source "drivers/acpi/Kconfig" > > endmenu > - > -source "drivers/firmware/Kconfig" > -- > 2.41.0 >
On Tue, 2023-08-08 at 15:16 +0800, Huacai Chen wrote: > Hi, Ruoyao, > > I think the title should be "LoongArch: Remove redundant "source > drivers/firmware/Kconfig""? Yes, it looks better. I've sent v2 with the change. Thanks! > > Huacai > > On Tue, Aug 8, 2023 at 11:49 AM Xi Ruoyao <xry111@xry111.site> wrote: > > > > In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all > > ports so > > there is no need to source it in the port-specific Kconfig file. > > And > > sourcing it here also caused the "Firmware Drivers" menu appeared > > two > > times: once in the "Device Drivers" menu, another time in the > > toplevel > > menu. This was really puzzling. > > > > Signed-off-by: Xi Ruoyao <xry111@xry111.site> > > --- > > arch/loongarch/Kconfig | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig > > index e71d5bf2cee0..465759f6b0ed 100644 > > --- a/arch/loongarch/Kconfig > > +++ b/arch/loongarch/Kconfig > > @@ -662,5 +662,3 @@ source "kernel/power/Kconfig" > > source "drivers/acpi/Kconfig" > > > > endmenu > > - > > -source "drivers/firmware/Kconfig" > > -- > > 2.41.0 > >
diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig index e71d5bf2cee0..465759f6b0ed 100644 --- a/arch/loongarch/Kconfig +++ b/arch/loongarch/Kconfig @@ -662,5 +662,3 @@ source "kernel/power/Kconfig" source "drivers/acpi/Kconfig" endmenu - -source "drivers/firmware/Kconfig"