Message ID | 20230807213022.1862903-3-florian.fainelli@broadcom.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp1814478vqr; Mon, 7 Aug 2023 18:32:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG07qbCpj4WA3v/nuK5/8Su19xpjNrxcYUfybM3vA8SqEg0nZRA6q06JurBQnTfKv56JR56 X-Received: by 2002:aa7:d488:0:b0:522:1d47:2d81 with SMTP id b8-20020aa7d488000000b005221d472d81mr8419623edr.17.1691458323210; Mon, 07 Aug 2023 18:32:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691458323; cv=none; d=google.com; s=arc-20160816; b=mfKBsl4s9i80Dq2loGJypgMSVYxYoFajomCTLF9w2haNTooGrNHxHANh9NBMgD1MVV kQGMBsWJnYD7tFBOr8L64gISV5Ki4YjnwYfuVa00JdcuD7dn9HRqzNo5e4XAbLee8IUJ n8d++6jqrQkUBUU/aMo1Ch/dhpZz50v2Km0hlH2UjmGfBUfRGg2TNyyGo9AwoqmkE3iC OlyLMEgeXGeOKpMp/gWp19iFflT7MGWAXqK7wxD7cDzO1Oae79tNlMkE3o7MlwIZN9id RgUMOsXfAFQ2p1R+Vt0kLSxu0KV9NQAB81TXYv0FGIq2BmirH8ReCvBSw7QEyEGb/3qN tK6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=bYkvGAq30twZUVWObehdMKRp3ODz2c/dhPWL/IkwVhk=; fh=CmTQh04AEk7Drl8TN7pnRCnec2+PuPQa4e7Ris2/3aQ=; b=K9NpvmKiX0dsSPEVGjaOH5HapzRKwktwY4x1NtInYLZrDmvqETaysfL4MItCi+YbX+ 2Beir6lMKA6cU+4zOGjwZja2CGik3UmWM1M3P9fyfxjRTapvkWoM0yFwKnSsOJt0ADYL toD7f6YtKGjMtL6MMUnulbMbdNlAbWkghgMmumpNqPUWja81Rq0Jb5njl4/QEUtRETwU +mm08lh2bExXVI6ElvCaNZHNTrcxGd97M+bYRMreDZk4YPKeFKS9uRfypsc0gw5mY4k8 t4yfzzQHsg7yYW988BHRJ4M52VajcPrPYcx3SETAypXtxHcDgVYHODjulrDLTLyV4EkD pDsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b="Jclfoq/2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l11-20020aa7c30b000000b005233fd1111fsi329678edq.398.2023.08.07.18.31.39; Mon, 07 Aug 2023 18:32:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b="Jclfoq/2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230137AbjHGVal (ORCPT <rfc822;aaronkmseo@gmail.com> + 99 others); Mon, 7 Aug 2023 17:30:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbjHGVai (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 7 Aug 2023 17:30:38 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EE3E10CF for <linux-kernel@vger.kernel.org>; Mon, 7 Aug 2023 14:30:37 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6873a30d02eso3286123b3a.3 for <linux-kernel@vger.kernel.org>; Mon, 07 Aug 2023 14:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1691443836; x=1692048636; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=bYkvGAq30twZUVWObehdMKRp3ODz2c/dhPWL/IkwVhk=; b=Jclfoq/23WTYZUqIRCtEXXSgf1u79JKbzXgiSVjJR+yoJsZSmjFVe3qvYARH0xagEA 9vyU3XwcEitYFi91L6QICPwWH8VsbGue/Npx4JUo42dEslD4r3vh4g0j0Q/MVm6ShTO9 dJaAoC7Jv0lqnDZzpo9UEzoWt2SvBjN8pOmmo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691443836; x=1692048636; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bYkvGAq30twZUVWObehdMKRp3ODz2c/dhPWL/IkwVhk=; b=Dqy1CfPiGPRl8DaF7E3P7kex2MHFizz5g0FiBxrsFHwWMY9UP+f6pyYoTeyYGFcRFm qPPxBaRtpSYNvyhNocnaIjsR0DPj3+/QZw6Hg2ZGSz4cHTZMLlqorgY4VO7sV8gkC2Md AqQWDnBVRLzXHzcBcF5MQYMbf/Ycz5gp+r4GOQxhZ+v3vfxZYHQsXcI2rT80VzYioULG ttqVN5V4d12F0aGbrBGggATAHp8v25kOGdQY9LmOzfMclItFn3TWyV9QM5jM4SqhLeOS 4BT1sJmAX62LTVASWhxecF+tJazFH5zwNuElEolXrNTCMktu8pAWCuxo2kzC8ICkcwoK 3PJQ== X-Gm-Message-State: AOJu0YzOb5wV9zPMzdt75Enj+cKKMvNW5Op6xQ3eFxQ4lXqGaRUFAQRO BKpUpl8aKbjFzauyqp5xakBwjD1s9qK97zZQXr/8smtiZ3okht0j9JFkg3yxj0vGsDheO1whx06 jDt9MoDVGk5/lnuNYMvV+diYzXScHyjPKurMm3CM2hC0waTSJ/eC6dpXg/Nfr2DynmRww5IO1S6 StBIMSdY6IPAI5ifFyuw== X-Received: by 2002:a05:6a20:72ac:b0:13b:a4fd:3017 with SMTP id o44-20020a056a2072ac00b0013ba4fd3017mr10732055pzk.46.1691443836380; Mon, 07 Aug 2023 14:30:36 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id fm13-20020a056a002f8d00b0064fd4a6b306sm6571822pfb.76.2023.08.07.14.30.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 14:30:35 -0700 (PDT) From: Florian Fainelli <florian.fainelli@broadcom.com> To: linux-kernel@vger.kernel.org Cc: Florian Fainelli <florian.fainelli@broadcom.com>, Linus Walleij <linus.walleij@linaro.org>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE) Subject: [PATCH 2/2] pinctrl: nsp-gpio: Silence probe deferral messages Date: Mon, 7 Aug 2023 14:30:22 -0700 Message-Id: <20230807213022.1862903-3-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230807213022.1862903-1-florian.fainelli@broadcom.com> References: <20230807213022.1862903-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000000ca38606025bf549" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773622602766231194 X-GMAIL-MSGID: 1773622602766231194 |
Series |
pinctrl: bcm: Use dev_err_probe()
|
|
Commit Message
Florian Fainelli
Aug. 7, 2023, 9:30 p.m. UTC
We can have gpiochip_add_data() return -EPROBE_DEFER which will make
us produce the "unable to add GPIO chip" message which is confusing.
Use dev_err_probe() to silence probe deferral messages.
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, Aug 07, 2023 at 02:30:22PM -0700, Florian Fainelli wrote: > We can have gpiochip_add_data() return -EPROBE_DEFER which will make > us produce the "unable to add GPIO chip" message which is confusing. > Use dev_err_probe() to silence probe deferral messages. The same.
diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c index 5045a7e57f1d..e32901a92fcf 100644 --- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c +++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c @@ -687,7 +687,7 @@ static int nsp_gpio_probe(struct platform_device *pdev) ret = devm_gpiochip_add_data(dev, gc, chip); if (ret < 0) { - dev_err(dev, "unable to add GPIO chip\n"); + dev_err_probe(dev, ret, "unable to add GPIO chip\n"); return ret; }