Message ID | 20230807193507.6488-2-brgl@bgdev.pl |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp1727416vqr; Mon, 7 Aug 2023 14:45:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGd+WVN7uapRrAXs0eeMutPVTHD+ztojS2M54igXNuy7A+qR7oaRfd+qfBs9KtszElCVs5v X-Received: by 2002:a05:6a20:3219:b0:125:928d:6745 with SMTP id hl25-20020a056a20321900b00125928d6745mr7112385pzc.15.1691444713891; Mon, 07 Aug 2023 14:45:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691444713; cv=none; d=google.com; s=arc-20160816; b=Kp4y3g6Ahw6fsAhj6xMTktQMz/fcbIewy1fgu7TeJY+qItJqD4+r/0jw6gIiEKTmrp lSM/y4a6TCTPxESwipPjmwvJnwAPX/AdJp+0dYDM7edjJTV6BzNGdSgu2LQX9FCL3fyF AVRM4MfMo6sVFjNv4MGrfDMUeJkIdG9fJXRytmZ/B8iwyZzjrIjKcFFxOpw+fyc2KFHl DmFGkl8fmWGCzTakMGY6S5wX/8PNTdD5WbsimtI/Dj1cBrp7HwnN5W/nX00svQ2kINma QnEG/zuMkMk/iVZBbJBIjGPdd1OE2vYByDHY7BwnyWkc2uD83qfOGE5LLWnNfqSOr3yw 79QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XSsBSVLtrUYlv/MGrIezXmSe6WOfaa1FZe1kCeq6Zm8=; fh=v6UDtM1LG1pNigs7Y52IFg78NWSS5jq/R3uih93pXmc=; b=cNKxj5naBQJE+w33Qm6b9Np7I1xU0IKkPLwcyAy27QSKrYiIB9wKGhjCV28ZIuj4F6 MEgCa+KpUdRwQVlKQZ0XAt6wK+OIVnW3NXWM/ttpOayEyatIXXTJYH1dJv8Xk9JFHY27 RIJk5xLOYlBm4Y5OwBon8QOKFDRnCwNutpWEoo4BLX/z/nFwXqY1eKfkApJRgncs0pwC 92EFIDA36Yv1eD7OZtUi1LPbrPAcewAl8LyX7ZKY/FSsc5eh+XrCdbXWV1T6HkWFETbv WwDP8AYTEBjs1PeJdSHZlxfKUPUF27iHJnnbzeOl77nRXhyiZEfdxIwcWd5BHH1ewJbO aRQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20221208.gappssmtp.com header.s=20221208 header.b=L7uC2z1H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 85-20020a630058000000b0055b7319a311si6016591pga.356.2023.08.07.14.45.01; Mon, 07 Aug 2023 14:45:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20221208.gappssmtp.com header.s=20221208 header.b=L7uC2z1H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229809AbjHGTfZ (ORCPT <rfc822;aaronkmseo@gmail.com> + 99 others); Mon, 7 Aug 2023 15:35:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229696AbjHGTfX (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 7 Aug 2023 15:35:23 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B106172A for <linux-kernel@vger.kernel.org>; Mon, 7 Aug 2023 12:35:21 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3fbea14706eso41426635e9.2 for <linux-kernel@vger.kernel.org>; Mon, 07 Aug 2023 12:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20221208.gappssmtp.com; s=20221208; t=1691436920; x=1692041720; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XSsBSVLtrUYlv/MGrIezXmSe6WOfaa1FZe1kCeq6Zm8=; b=L7uC2z1HR78duqiRFC3J5QmDk0rcMFKv+OS9eicsmH1tv4MLrXE2uEgfPWWfUlB9CU 1y9fVJob1NzP2h6EsLC65fc+wae+BPL4KrjdW3lO6SjKS9Gs09G4sAo3f52or5ggzM+M kCe8y/iFwsHevNDhyQLdaYm0vKqp3xV8YfAVPHS/csMHyHWSAM5g8sqX0/rlMGI5KMzG ufaoABATQYUEjKP2z64V4fiRIX055xgNogypA+OeV63ZwwiT/nzcMjVF6U5ugu32LO8l KFMvQRgRNtT/1LlLViC56Yu1iwiVhtzPH0/0WbWnQd+Kg6g5lX1GvxDHpzz6c0MOiIuO rb3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691436920; x=1692041720; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XSsBSVLtrUYlv/MGrIezXmSe6WOfaa1FZe1kCeq6Zm8=; b=WgYKDsEaQ3lb1yxhKtJ9lYyM1XRMmCjh2/Sgj8zUrjyLM5KPRxx/R+rRs3JkeNeX/x nJHFYj44UxWoXCCKPYAAyzy+Bv5jMH9WrD9fFliBMSEe20yw5ALJUM9mqlGbwp+5yTXZ /OuZdwTS+GjDpaFHtkGoR2zK7WHnOeichC9wMK5zqX/McKuF+VMs2b3UzyAy5mBLOvQv yA5HnIHGgpnIbKlVIncwHCkxsmGdpxpZ96bON3KkcwxFZiBoyas/R63b0siB9a3SeqnI ZsGX9hPoih0SsNYK88Tym787gJYb/vlD2ErrzXbZ5crF2lAfBM0WOXAX05RY6q/fCrBu XYfw== X-Gm-Message-State: AOJu0Yx4OspDdYlDCa00BDxV3EjiN5CIFfPvEJQszhydj30ZOs8lKeCw DVJCoXoGMlbP3agfCx/ts4ISSg== X-Received: by 2002:a05:600c:2a50:b0:3fe:63ca:ccf2 with SMTP id x16-20020a05600c2a5000b003fe63caccf2mr11136wme.33.1691436919831; Mon, 07 Aug 2023 12:35:19 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:b3d6:9e6:79d9:37cd]) by smtp.gmail.com with ESMTPSA id q9-20020a1ce909000000b003fc04d13242sm16061488wmc.0.2023.08.07.12.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 12:35:19 -0700 (PDT) From: Bartosz Golaszewski <brgl@bgdev.pl> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Alex Elder <elder@linaro.org>, Srini Kandagatla <srinivas.kandagatla@linaro.org>, Andrew Halaney <ahalaney@redhat.com> Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Subject: [PATCH 1/9] arm64: dts: qcom: sa8775p: add a node for the second serdes PHY Date: Mon, 7 Aug 2023 21:34:59 +0200 Message-Id: <20230807193507.6488-2-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230807193507.6488-1-brgl@bgdev.pl> References: <20230807193507.6488-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773608332257515072 X-GMAIL-MSGID: 1773608332257515072 |
Series |
arm64: dts: qcom: enable EMAC1 on sa8775p
|
|
Commit Message
Bartosz Golaszewski
Aug. 7, 2023, 7:34 p.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Add a node for the SerDes PHY used by EMAC1 on sa8775p-ride. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)
Comments
On Mon, Aug 07, 2023 at 09:34:59PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add a node for the SerDes PHY used by EMAC1 on sa8775p-ride. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> FWIW this seems to match downstream sources. Reviewed-by: Andrew Halaney <ahalaney@redhat.com> > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 7b55cb701472..38d10af37ab0 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -1846,6 +1846,15 @@ serdes0: phy@8901000 { > status = "disabled"; > }; > > + serdes1: phy@8902000 { > + compatible = "qcom,sa8775p-dwmac-sgmii-phy"; > + reg = <0x0 0x08902000 0x0 0xe10>; > + clocks = <&gcc GCC_SGMI_CLKREF_EN>; > + clock-names = "sgmi_ref"; > + #phy-cells = <0>; > + status = "disabled"; > + }; > + > pdc: interrupt-controller@b220000 { > compatible = "qcom,sa8775p-pdc", "qcom,pdc"; > reg = <0x0 0x0b220000 0x0 0x30000>, > -- > 2.39.2 >
On Mon, Aug 07, 2023 at 04:10:34PM -0500, Andrew Halaney wrote: > On Mon, Aug 07, 2023 at 09:34:59PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Add a node for the SerDes PHY used by EMAC1 on sa8775p-ride. > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > FWIW this seems to match downstream sources. > > Reviewed-by: Andrew Halaney <ahalaney@redhat.com> Why does matching downstream make it correct and deserve a Reviewed-by? Did you actually review the change? Andrew
On Mon, Aug 07, 2023 at 11:28:15PM +0200, Andrew Lunn wrote: > On Mon, Aug 07, 2023 at 04:10:34PM -0500, Andrew Halaney wrote: > > On Mon, Aug 07, 2023 at 09:34:59PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > > > Add a node for the SerDes PHY used by EMAC1 on sa8775p-ride. > > > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > FWIW this seems to match downstream sources. > > > > Reviewed-by: Andrew Halaney <ahalaney@redhat.com> > > Why does matching downstream make it correct and deserve a > Reviewed-by? > > Did you actually review the change? > > Andrew > That wording of "match downstream sources" is amiguous, sorry. What I meant was that: 1. This looks like a properly formatted dtsi node, follows conventions in the file for ordering, etc 2. The downstream devicetree from Qualcomm uses the same MMIO region same dependencies for clocks, etc. I do not have documentation to further review past that I didn't suspect anyone else would cross check this information, so I did and thought it deserves a RB after that. Please let me know if you'd rather I just leave a comment saying such without any formal tags (but I thought since the whole patch looks proper and that information looks correct compared to the "documentation" I have access to it deserved such). In the rest of this series review I may have used similar phrasing with respect to downstream, but that expanded description is what I meant in those cases as well. Thanks, Andrew
> That wording of "match downstream sources" is amiguous, sorry. > > What I meant was that: > > 1. This looks like a properly formatted dtsi node, follows > conventions in the file for ordering, etc > 2. The downstream devicetree from Qualcomm uses the same MMIO region > same dependencies for clocks, etc. I do not have documentation > to further review past that O.K. This does make your reviews worthwhile. Vendor crap gets that name for a reason. So just saying it is the same as the vendor code is not really helpful. So i would avoid this ambiguous statement. And your later comment on a patch which points out real problems adds to my confidence you did a real review. Thanks Andrew
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 7b55cb701472..38d10af37ab0 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -1846,6 +1846,15 @@ serdes0: phy@8901000 { status = "disabled"; }; + serdes1: phy@8902000 { + compatible = "qcom,sa8775p-dwmac-sgmii-phy"; + reg = <0x0 0x08902000 0x0 0xe10>; + clocks = <&gcc GCC_SGMI_CLKREF_EN>; + clock-names = "sgmi_ref"; + #phy-cells = <0>; + status = "disabled"; + }; + pdc: interrupt-controller@b220000 { compatible = "qcom,sa8775p-pdc", "qcom,pdc"; reg = <0x0 0x0b220000 0x0 0x30000>,