| Message ID | 20230807185645.128751-2-a-nandan@ti.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp1671265vqr;
Mon, 7 Aug 2023 12:40:47 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IFRTqG44ir/PGnMHUJ8W7ZD7EsadWk+21yLACs0Lkc1jPHzL/2uQdK0H8BAzTF6yQMJw/4Z
X-Received: by 2002:aca:2b14:0:b0:3a7:22f0:1fc2 with SMTP id
i20-20020aca2b14000000b003a722f01fc2mr11909611oik.13.1691437247131;
Mon, 07 Aug 2023 12:40:47 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1691437247; cv=none;
d=google.com; s=arc-20160816;
b=KSVIgGqh7yxyPjkXv9iQSnBaqF65PvU0k8nlst0Hn786FU5YALWorgGimJhDXdd5mh
Qe09AME1NCUgDGBdpPEkLUhe0Va6JeMlePaAoKt87N/6kSEaEGTuKf/ysTmVvANXBqbg
c+zOFnuzFaBvUXD+96A56RPuyvDXY0EggZroiPRgbVoL0Tn6UUXY+Ps9kwe9OrjovCdC
jsblftYFwu20CvZg9jUVH3F1mddJ/dG82UF4d28PYpK0JnCqhhtIq5wqJP5VwPSB27n9
Yp57bWpzCQNCVREsyArj2MYkMVBMh9YQ9OXsLKxON9YaQPdOEU7wMzf2HsWhSGTuadLd
Wgmg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:to:from
:dkim-signature;
bh=L2n4DfbAo8bezZ1b7hOwwHKCzp1HrlAHRSvKRYqYQA0=;
fh=32MwQFC/OWOTTesZhIH/HSMNDNHEVSwT08x7vfzofjI=;
b=kuw7wrxegqFa8bplRKN3yUHvCYNpnBh1YvQjSwuNlxok/Z1IzCJFrcXbaFL4W8R6G2
hbd4mq+A9RpBpo9znni0baiPkInoDcRa/3vsGdjVVgmuql4ULzGVhn8+j7I6VUgzZTLI
SeLoy9S+91NMJHwXQMJAKqXX3w0b9SnMXIt6CAPpP8qsAvqfKslXBsgEtB2o66mXNxrU
rT2IgwcUaYq/fpRQlntsz79lZDLOnfaXGBm1UtHS0ylryUvgvxfNLb6532T8QEi20t5w
cnmBeyXf53gUkWJ8Gf6flgcotBh8C+3Qsy8uiC6XdlMtgXcHrtIRqE9dD3YaYan6duE2
p+/w==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=OASI09eU;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
a64-20020a639043000000b00564333541aasi5763643pge.1.2023.08.07.12.40.33;
Mon, 07 Aug 2023 12:40:47 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=OASI09eU;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230474AbjHGS5I (ORCPT <rfc822;aaronkmseo@gmail.com> + 99 others);
Mon, 7 Aug 2023 14:57:08 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42626 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230041AbjHGS5D (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 7 Aug 2023 14:57:03 -0400
Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 868E31730;
Mon, 7 Aug 2023 11:57:01 -0700 (PDT)
Received: from lelv0266.itg.ti.com ([10.180.67.225])
by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 377IusgM030807;
Mon, 7 Aug 2023 13:56:54 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;
s=ti-com-17Q1; t=1691434614;
bh=L2n4DfbAo8bezZ1b7hOwwHKCzp1HrlAHRSvKRYqYQA0=;
h=From:To:Subject:Date:In-Reply-To:References;
b=OASI09eUgahxm4TJYe9Z3G+lvd8bQbiUgXbBaOsqObSGffO74YheQDQdYl8712+cv
04eHtVPz1+g4jYN7heXnR6PtE2BMWEau1w29S5GhZN63YKx2XN+O814z6A1dMt9rdh
8LNGdTjB5i13sIEp82HuP5NmsVJBABuJGKS9Dl+g=
Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25])
by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 377IureJ091522
(version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
Mon, 7 Aug 2023 13:56:53 -0500
Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE104.ent.ti.com
(10.64.6.25) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 7
Aug 2023 13:56:53 -0500
Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE111.ent.ti.com
(10.64.6.32) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via
Frontend Transport; Mon, 7 Aug 2023 13:56:53 -0500
Received: from TI.dhcp.ti.com (ileaxei01-snat2.itg.ti.com [10.180.69.6])
by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 377Iuj1r013364;
Mon, 7 Aug 2023 13:56:50 -0500
From: Apurva Nandan <a-nandan@ti.com>
To: Apurva Nandan <a-nandan@ti.com>, Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Udit Kumar <u-kumar1@ti.com>, Hari Nagalla <hnagalla@ti.com>,
Dasnavis Sabiya <sabiya.d@mistralsolutions.com>
Subject: [PATCH v2 1/4] arm64: dts: ti: k3-j784s4-main: Add bootph-pre-ram
property for SPL nodes
Date: Tue, 8 Aug 2023 00:26:42 +0530
Message-ID: <20230807185645.128751-2-a-nandan@ti.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20230807185645.128751-1-a-nandan@ti.com>
References: <20230807185645.128751-1-a-nandan@ti.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1773600502756635117
X-GMAIL-MSGID: 1773600502756635117
|
| Series |
arm64: dts: ti: k3-j784s4: Add bootph-pre-ram property for SPL nodes
|
|
Commit Message
Apurva Nandan
Aug. 7, 2023, 6:56 p.m. UTC
Add bootph-pre-ram property for all the nodes used in SPL stage,
for syncing it later to u-boot j784s4 dts.
Signed-off-by: Apurva Nandan <a-nandan@ti.com>
---
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 3 +++
1 file changed, 3 insertions(+)
Comments
On 00:26-20230808, Apurva Nandan wrote: > Add bootph-pre-ram property for all the nodes used in SPL stage, > for syncing it later to u-boot j784s4 dts. > > Signed-off-by: Apurva Nandan <a-nandan@ti.com> > --- We need to rework this a little more: The approach taken in this series is enable pre-ram for everything. I am not sure that is the right direction. https://github.com/devicetree-org/dt-schema/blob/e87ba2f515392c2a4694642063efb43023331ff6/dtschema/schemas/bootph.yaml#L70 patch #1: board generic changes: patch #1 patch #2-: board specific change (per board) Make sure you use the correct property and document why this is needed in the section added as well - esp for board generic changes introduced into SoC.dtsi files. > arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > index 2ea0adae6832..aaec569fe91a 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > @@ -6,6 +6,7 @@ > */ > > &cbass_main { > + bootph-pre-ram; Is this better done where the node is defined? > msmc_ram: sram@70000000 { > compatible = "mmio-sram"; > reg = <0x00 0x70000000 0x00 0x800000>; > @@ -670,6 +671,7 @@ main_sdhci1: mmc@4fb0000 { > }; > > main_navss: bus@30000000 { > + bootph-pre-ram; > compatible = "simple-bus"; > #address-cells = <2>; > #size-cells = <2>; > @@ -705,6 +707,7 @@ main_udmass_inta: msi-controller@33d00000 { > }; > > secure_proxy_main: mailbox@32c00000 { > + bootph-pre-ram; > compatible = "ti,am654-secure-proxy"; > #mbox-cells = <1>; > reg-names = "target_data", "rt", "scfg"; > -- > 2.34.1 >
Hi Nishanth, On 08/08/23 00:37, Nishanth Menon wrote: > On 00:26-20230808, Apurva Nandan wrote: >> Add bootph-pre-ram property for all the nodes used in SPL stage, >> for syncing it later to u-boot j784s4 dts. >> >> Signed-off-by: Apurva Nandan <a-nandan@ti.com> >> --- > We need to rework this a little more: > > The approach taken in this series is enable pre-ram for everything. I am > not sure that is the right direction. These patches only enable bootph-pre-ram for the nodes, that already had bootph-pre-ram property in u-boot dts patches for j784s4. And these are selected after removing unnecessary nodes that had this property, so not added for everything. Are there a nodes which seem to have unnecessary bootph-pre-ram property according to you, need to remove? > https://github.com/devicetree-org/dt-schema/blob/e87ba2f515392c2a4694642063efb43023331ff6/dtschema/schemas/bootph.yaml#L70 > > patch #1: board generic changes: patch #1 > patch #2-: board specific change (per board) > > Make sure you use the correct property and document why this is needed > in the section added as well - esp for board generic changes introduced > into SoC.dtsi files. > I am little unclear about what nodes you refer with board generic vs board specific bootph-pre-ram. I have currently added bootph-pre-ram in board EVM dts files if the node is disabled in SoC dtsi and enabled in EVM dts (no point adding bootph-pre-ram in disabled node), or for pinmuxes, etc. What is the segregation you want in the patch, do you want some bootph-pre-ram to be moved from where they are? >> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> index 2ea0adae6832..aaec569fe91a 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> @@ -6,6 +6,7 @@ >> */ >> >> &cbass_main { >> + bootph-pre-ram; > Is this better done where the node is defined? Okay, this I will fix. > >> msmc_ram: sram@70000000 { >> compatible = "mmio-sram"; >> reg = <0x00 0x70000000 0x00 0x800000>; >> @@ -670,6 +671,7 @@ main_sdhci1: mmc@4fb0000 { >> }; >> >> main_navss: bus@30000000 { >> + bootph-pre-ram; >> compatible = "simple-bus"; >> #address-cells = <2>; >> #size-cells = <2>; >> @@ -705,6 +707,7 @@ main_udmass_inta: msi-controller@33d00000 { >> }; >> >> secure_proxy_main: mailbox@32c00000 { >> + bootph-pre-ram; >> compatible = "ti,am654-secure-proxy"; >> #mbox-cells = <1>; >> reg-names = "target_data", "rt", "scfg"; >> -- >> 2.34.1 >>
diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi index 2ea0adae6832..aaec569fe91a 100644 --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi @@ -6,6 +6,7 @@ */ &cbass_main { + bootph-pre-ram; msmc_ram: sram@70000000 { compatible = "mmio-sram"; reg = <0x00 0x70000000 0x00 0x800000>; @@ -670,6 +671,7 @@ main_sdhci1: mmc@4fb0000 { }; main_navss: bus@30000000 { + bootph-pre-ram; compatible = "simple-bus"; #address-cells = <2>; #size-cells = <2>; @@ -705,6 +707,7 @@ main_udmass_inta: msi-controller@33d00000 { }; secure_proxy_main: mailbox@32c00000 { + bootph-pre-ram; compatible = "ti,am654-secure-proxy"; #mbox-cells = <1>; reg-names = "target_data", "rt", "scfg";