| Message ID | 20230807121432.3970610-8-peng.fan@oss.nxp.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp1440651vqr;
Mon, 7 Aug 2023 06:15:56 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IEjIAW+q0JLjWUj+T7g37IAfa8V/UX/TtBD/Ti4cqVMXsnLrTktJCRugJhacEagGPdI5/tU
X-Received: by 2002:a17:907:2c42:b0:98e:2b01:ab97 with SMTP id
hf2-20020a1709072c4200b0098e2b01ab97mr7003487ejc.68.1691414155871;
Mon, 07 Aug 2023 06:15:55 -0700 (PDT)
ARC-Seal: i=2; a=rsa-sha256; t=1691414155; cv=pass;
d=google.com; s=arc-20160816;
b=uHOxLT13AMjSdmwpCzXdGl2iIv/1pdcZEANLDonWHH4v5pEmW5XO59dDOPKap12sc/
ZswyABwkLktup4R8WnMmpaqaNIkZ7FTY4wr+RfZ6cn6QORtnIg+tYs5OXjbgfvgq36+z
Zx7i4WcIUpVJsMgq2jjaEEeRkFm8v/4bbwy28cdHYyQ48hrwgERlvhbp31lbcOUNwhLv
AeeMzKSd0Z6U4Z8hxtkaQjgJXCcf/sgFBTjsk9xHTP7uiHqS0WarJ+X0evQN3ZXwLti0
uxubsqhFZd8CX7Uzsp0z+tTG7BgKm4A42VtsuphIuKhHX8nvkehRVS+MK3AFKKEZf61j
BnTg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:mime-version:content-transfer-encoding
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=QALHUzHVhQKD3fKu06vGPOUlJ4GnUotQExquzQP0wVA=;
fh=lMFpnJZCjkSvetl9tpFZk4oM1K582D2CBXvvYFGhgSk=;
b=ZoOpafX0QsXzcgt2Wm7yFLn3TVhf1QGDFqK1E5wuQRCBtTX4wsAuIngoCJfoTz9oUD
fOyxWKZ58of0rbgNoz9YvwdC09uMQRpN6CiLf3VLYKzbE1VDcbl5VwssahgePVTFUtba
lGcQj/Rxof8WBxKE3+vShODB7O1T7lKkR628oaCpUZ1ekvxihVeouEmL3054+BJwjem/
mTOfeTVHt1Be+1EmpljXOC9SoUesTR7ixV3BllCNG8G/BHgah9h1p2XGrXVNqklp7hRZ
Gx5rVLsdzb11RIrZl8hldDylGjszYorUXWg5I/om9VQfQRyTv2/q00ztnwOs9dAECm/u
Fuiw==
ARC-Authentication-Results: i=2; mx.google.com;
dkim=pass header.i=@NXP1.onmicrosoft.com
header.s=selector2-NXP1-onmicrosoft-com header.b=XfGYCZYY;
arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass
dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com);
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
e26-20020a17090681da00b00992feae388bsi4985073ejx.457.2023.08.07.06.15.30;
Mon, 07 Aug 2023 06:15:55 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@NXP1.onmicrosoft.com
header.s=selector2-NXP1-onmicrosoft-com header.b=XfGYCZYY;
arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass
dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com);
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229517AbjHGMLJ (ORCPT <rfc822;aaronkmseo@gmail.com> + 99 others);
Mon, 7 Aug 2023 08:11:09 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45238 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231387AbjHGMLH (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 7 Aug 2023 08:11:07 -0400
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
(mail-dbaeur03on2044.outbound.protection.outlook.com [40.107.104.44])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BFBB10FC
for <linux-kernel@vger.kernel.org>;
Mon, 7 Aug 2023 05:10:35 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=aNhHvCN95HFcaroFlsoY/hBuSb33rMXRHL/c1u8Y35TAAeMmLO3/0URruARf/xIZTTM1/Hcfhm11eAbcHwgMx1vGnDiX4qJ4bXdqjKn0dtZ4NXIs/atpna/XYEPilgTzD0biHu45l0PLc7WXJPFfBM6oEIx6jyoQh+8hygj9qU112ioBKcpIMWWN3i9wOWxZhqCt416ssUzohQfSsz8z+sZi5WCidxpPosZjRqy1bKS2RMOdrYhYNlgDlLsApSzwva3pjPqwCB1bhfZSh7mqS3kEuqJAdhiT6FiDcoERjPQ7BxwcHIiCy8LgIFfBIZ8VHVlsQrHBzZ/MYrc+yX+Ndw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=QALHUzHVhQKD3fKu06vGPOUlJ4GnUotQExquzQP0wVA=;
b=ZgktJeP+6/4NI2sMFre/x+AzPGSt5BemZwm84OAej8yiM92F/lageMhgWe6+CyuDaVZ9O66c2Q0iQIyKiWjBPJ5RzgCA5CgDpMhKnD3HcgmZ9qqlseejJCsSxzxlMIxU4YY3zPBuT1hdXY8Z55poW176wBzIgIilAbPp0MMvg+KwjfgccLbEVRlP45cid/5xe6SDU9Bj+O6EglUPwq/I0FhazttQ3iUaSF+4Z4AnBGw3KWs2I/8luyae7ekQ4clO/FlggWtpsmhoQla4EGsAd24lzwMvkLzdMamUI5H+QzG6ivJIbxqR5lXqOaYCcmMxmbo5iWZPAouzD1Gc7i6l4A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
s=selector2-NXP1-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=QALHUzHVhQKD3fKu06vGPOUlJ4GnUotQExquzQP0wVA=;
b=XfGYCZYYLuF/5FXMz/UOIyUgbw24YEZhOYKVLj1xBHVSXauRXTNb7MbVnCyhCcCGwpJJ9f/CwH58spvI1r/GZwmhIPf3nZbY5BiSmBhk89uC4t/DqzyUKc9jsVzavpU7hPX+V3OvwNgBHkxcXPcoui7XX+HYRYFd6+xB9y3lOQM=
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=oss.nxp.com;
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
by AM0PR04MB6897.eurprd04.prod.outlook.com (2603:10a6:208:184::13) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug
2023 12:10:18 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
([fe80::5d6a:ec53:f2a8:5b97]) by DU0PR04MB9417.eurprd04.prod.outlook.com
([fe80::5d6a:ec53:f2a8:5b97%6]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023
12:10:18 +0000
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com,
linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V6 7/8] firmware: imx: scu-irq: enlarge the
IMX_SC_IRQ_NUM_GROUP
Date: Mon, 7 Aug 2023 20:14:31 +0800
Message-Id: <20230807121432.3970610-8-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20230807121432.3970610-1-peng.fan@oss.nxp.com>
References: <20230807121432.3970610-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SG2PR01CA0158.apcprd01.prod.exchangelabs.com
(2603:1096:4:28::14) To DU0PR04MB9417.eurprd04.prod.outlook.com
(2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM0PR04MB6897:EE_
X-MS-Office365-Filtering-Correlation-Id: e352db2d-243e-4ecd-9991-08db973f4423
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
G6HhAO2H8iqme8Q+43z5+Jk2xftCLnK/TdJhy6F50dQdrRqrl9y6PwtTrcGigRgNNWP45LHsW++jEEmUhp0veMRGZu8+f1w+wKEljM3QHSkiKkac46YqxiqCTVgD03QliEdmo1FfPM6wrQL9I96sM53pIOY4Nlye24h0gn2mT33L3YBRjuTGOxEp6gnJ+KGg9Ocp1Bkt+9AGVOY0VHbHfDlKzqoaNHhH8jxTH5jUCt14ItX/wGwhhfakMtM5jrki6GhcqHC3SwhFghk4puZX6gSpju7tgyztK60M7KpCxgGCW/RkacoQHZh9S8SOqttkzN+To161kqJdzWhw/zshatQfR8Dsn3sqBB2e6xjuJyHH1voE0sIDKeNBrEfIzO/YCwuPwxBltig1pD50q8Qogv6979/dgDN+2W0kfAb09bWeRqd+ufWNTu6WzQ6Ie36e/A2LNjAVFEdxxv73oMAsxD+72ADUHLkbOYBEj5JaLoGHmqLRczD5+GiZQEWfEJiHJ1tVFZFrglMs4gcBQYFwi+zHS+wGKgeR17W9LQ0h/woh1NZTM1RwLPftnTzHrMGxZpGRNGlWnQqZ6GHzcwZ8gz4Akf4c29AIumiZC0lBL3Zv0ZiB86CIdtK4BXkEgHSOB/Fs885GEyT36AkgsZM7gQ==
X-Forefront-Antispam-Report:
CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(451199021)(1800799003)(186006)(2906002)(83380400001)(4744005)(5660300002)(2616005)(6666004)(52116002)(38100700002)(38350700002)(6486002)(66476007)(66556008)(66946007)(6512007)(4326008)(316002)(41300700001)(86362001)(8936002)(26005)(8676002)(1076003)(6506007)(478600001)(147533002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
7RXrWQY3u1BmxLF5+uTQpqmojjlzBFGZe6/FMvapUTzb65B5TGc4bHzmV+88qLVur7AY/UNvE5SYbKIqYlmSMtSD7S4wzKYa9l1tFVw+8oBGV9m/nlD4KkZBz7L/jVMDw3qOiSag0InHW2J8S6BVyclPMFjWGL/WZzoMWESjq9knOgcDudtH+XRqJD+seJ0YpOFTpKIBpFULXLzJvcu+QxkyYaT5wKKdY26ZSilE+dEyHBF/3WfKAx5fBpL6hG79tf/TWnZtvrVXvuy0zyPDIeutCpiP5+xOqr2hY710I5KPe3iNqGUc0DJjgBjPzDyUD/GQ31Z4cCIGd9mjXXC4mCNnXRzo49p8gGkZDZY5tuI76jf5ClYh25FiZ6ExTwOlfV8A3i/BWJlhlMeYptLYdOZKG5QT10FLzcu79fKrf9k4KbxzkJ7kmSXUjk5r76XlGHogFAaFFlREyUAagxbmj8JoeLT/HLS5CABQcfZwLWEUhLOXCefjRBcSNf9sUu2WI2t0WbogESqF1rs3ClMUrROtooM7sVb2LVoN+rfLJAeJ4gBO2kLvMTRVfDk5/7dhSROSvS0qwXNptrUxbEZURSbODhh0cSXgCRyaNIGMxMkIX2sTBUcQtREw52oHKyAioysUWDdJIHEiWJcHxlLnV9P+Z9Y9s9lRk4k4xU7A3t85ZSRm0VutM9VDTGnXKvHNHfGXZuWpxN4eoTGaTZpzspoLRcuBLyHTS5j9yD258Vlg3IQs8NNpbOOt1J2ad+oIN2NahZXj7KEI1T+HMEkAANLtM+aM+DRj+Pe18cTWOU/Z7SjiEpeX9W9aS9yRwyjCJmRkP+2ZZXVAYYoH5B3zZJQYdC9qcF8i3WE0fc72+b+CGAszuP+oxsv0maugT/q4tnMmpx3MjMBAcniCvkG0vuemaUQXTWEf2pya/R+OuEnLeTx4qBmKiqWO5u2JDqHd5JtlS9Z1C/geKf9saiHUYmIU/xiJKQEX4z/MbI1zdq3K8Dp8s2ztaIAS49jQZkmMBzyWTXkg2DDyPOFylTmn3WjqR3BzTKg4g/em/Ex2Flqi0hhbAl9Y8IX/3QRBoLMT8O3b2WlAeZbrryBSydRLzMK/BP9yRMcVef8CXqIg7Rpt5xOXk0hVIT1RtKGpoT3/p3wdQrhsH0UI+vPsaZFSciNXu8J7MpoM+eHog142XIl+g0J0mJZT5Xmex0Xh0ZO+Cszelgtcr729Xs6cFaGo93FqRk0U9uQGZYiRhXUGe87Qp1tqFM4VE+UsEg7Yb2dR8+MZVxpMuMSGVplXqYqMujBIy4YPYjGzCvk2/fenJ75a2pCYR5apMl+ffToTDEHvUZtd3qwNHxkVHcbQJGDJj4wriBQCsbvgVpF6Een4ozRRy0INFd9lzyV4wuAPn6W+yhTsjV2MyXNRxfpG7K/WMCnAcnkf/7QWUgnRdMyJL2PJisOxTf2wacHBNNWX1sFVOboPfG0P2S2IPDG3DTU/s8OjK0QX2S/T2mOLflHvLyErnaAVbzU2+rumXPSae6Wl5do0OAIUwabW7F6bCgLKtZxSBegsJgV+baD33I54TSZayBxp6/x9NzSugkBTplI3
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id:
e352db2d-243e-4ecd-9991-08db973f4423
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 12:10:18.7878
(UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName:
k1jvOfRgTgizfTn8YbsXhKKrhtLt3CKUbhinCvHfGdnqXyyWaoQKPH8PR4B6l3deBdxCb7T5VWujUP0qM543wA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6897
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,
SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1773576289953352174
X-GMAIL-MSGID: 1773576289953352174
|
| Series |
firmware: imx: scu/scu-irq: misc update
|
|
Commit Message
Peng Fan (OSS)
Aug. 7, 2023, 12:14 p.m. UTC
From: Peng Fan <peng.fan@nxp.com> Per SCFW update, update the IMX_SC_IRQ_NUM_GROUP to 9. Signed-off-by: Peng Fan <peng.fan@nxp.com> --- drivers/firmware/imx/imx-scu-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, Aug 7, 2023 at 4:11 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote: > > From: Peng Fan <peng.fan@nxp.com> > > Per SCFW update, update the IMX_SC_IRQ_NUM_GROUP to 9. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/firmware/imx/imx-scu-irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c > index 6549f3792a0f..8d902db1daf2 100644 > --- a/drivers/firmware/imx/imx-scu-irq.c > +++ b/drivers/firmware/imx/imx-scu-irq.c > @@ -14,7 +14,7 @@ > > #define IMX_SC_IRQ_FUNC_ENABLE 1 > #define IMX_SC_IRQ_FUNC_STATUS 2 > -#define IMX_SC_IRQ_NUM_GROUP 4 > +#define IMX_SC_IRQ_NUM_GROUP 9 This is tricky. Shouldn't we have some sort of versioning so that the user knows that kernel and scfw are not compatible anymore?
> Subject: Re: [PATCH V6 7/8] firmware: imx: scu-irq: enlarge the > IMX_SC_IRQ_NUM_GROUP > > On Mon, Aug 7, 2023 at 4:11 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> > wrote: > > > > From: Peng Fan <peng.fan@nxp.com> > > > > Per SCFW update, update the IMX_SC_IRQ_NUM_GROUP to 9. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > drivers/firmware/imx/imx-scu-irq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/firmware/imx/imx-scu-irq.c > > b/drivers/firmware/imx/imx-scu-irq.c > > index 6549f3792a0f..8d902db1daf2 100644 > > --- a/drivers/firmware/imx/imx-scu-irq.c > > +++ b/drivers/firmware/imx/imx-scu-irq.c > > @@ -14,7 +14,7 @@ > > > > #define IMX_SC_IRQ_FUNC_ENABLE 1 > > #define IMX_SC_IRQ_FUNC_STATUS 2 > > -#define IMX_SC_IRQ_NUM_GROUP 4 > > +#define IMX_SC_IRQ_NUM_GROUP 9 > > This is tricky. Shouldn't we have some sort of versioning so that the user > knows that kernel and scfw are not compatible anymore? It would not hurt here for scu irq num group. Newer linux could work with older scfw. But you raised a good point, we could print scfw version when probing scu firmware, and for un compatible case, version check could be used. Thanks, Peng.
diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c index 6549f3792a0f..8d902db1daf2 100644 --- a/drivers/firmware/imx/imx-scu-irq.c +++ b/drivers/firmware/imx/imx-scu-irq.c @@ -14,7 +14,7 @@ #define IMX_SC_IRQ_FUNC_ENABLE 1 #define IMX_SC_IRQ_FUNC_STATUS 2 -#define IMX_SC_IRQ_NUM_GROUP 4 +#define IMX_SC_IRQ_NUM_GROUP 9 static u32 mu_resource_id;