From patchwork Mon Aug 7 09:58:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 131914 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp1417188vqr; Mon, 7 Aug 2023 05:38:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHp4h7iUFCDLU8JFrFVuWCXNBs+xXW0jFn1U8DjZ80U7/hoGgZxkD/FRrlx8qkoQiYQkYSJ X-Received: by 2002:a17:907:a077:b0:991:c842:2ca2 with SMTP id ia23-20020a170907a07700b00991c8422ca2mr7013998ejc.15.1691411925083; Mon, 07 Aug 2023 05:38:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691411925; cv=none; d=google.com; s=arc-20160816; b=VUDZg0KQJME4E5yesHe8+hOsi7GZ0CwFajVEDLqvT3VA4criHfPgQmYlWPWBGzE1vM cy+MZWvoYp1KGnZzLKs3LIp2very3FLp4ai1FVMM6XIqQs1opKC2CLmemH8ourRefwNI P5HOTWYtDqjLTLGIFefXYkzKhADTQMkinxyVDqCGLNWX6guYIpiwZOrfSp+VFLQfznD1 LDlhMIEjw36HC86SOtKUSnaPUo56yUgIGz/D9WlNClR68xyLmmi3QxmnIM6p7YPUoz6l QguBYWP20XwBzVJ2214022+a70ICq3wtNnk5GwMKMMRKrlePIO9g2lV3mMBcv5H6zDLU Cu4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9z1nbbzqnG7axwBxzJg/LVL8HqYZ+dwcQQrkZ5g91JQ=; fh=lk4D8O+EQLRee0MqvJeMN3sGN9nm26rlH12OR7cqKyA=; b=ogiXY7gAYmjXRsbd1PeAxs5T4LS/1bv7B1A2PnMyZM+bg3Sp1JgQdrPKo+k5oXj4tp ry8MljreeHQa/OrNnR5lXQGlZi+lRVTVoVKHmqXEQYrUsM9HnSpuLQ0IP8DX4U7xiboP GX2Tu7E/JN3kBh6ktpTxNRn9hTfDN7zdt/MKhIn01+plGKAQ5wLiEIrVYg4kRfIZCAKC xxrUkbfMy4cmOGHBPAq2u9Yjn15VMD8dA8ir//d9WVIMLp0ZkqRvVtfJKHID/ezDu7I1 DoKrTLCUaeZ124ZeEDHblUXKL5DHpaJeo1nzhbzKfbkESKeSPIcF9RB0yZfPycpuSxLJ EVUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=SxhTCX7q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u9-20020a1709064ac900b0098d85fee2e2si4176079ejt.608.2023.08.07.05.38.20; Mon, 07 Aug 2023 05:38:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=SxhTCX7q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231751AbjHGJ4V (ORCPT + 99 others); Mon, 7 Aug 2023 05:56:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231733AbjHGJ4T (ORCPT ); Mon, 7 Aug 2023 05:56:19 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE447134; Mon, 7 Aug 2023 02:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691402178; x=1722938178; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=4/2va4N+yxECKU3nkj0ADpdSkYaka5HTaKbB+Q+fNQ8=; b=SxhTCX7qid47FE18BpQvk+apUGFUkV03altoT1Wb+MVzdWSlTsoOpsvX U388ylE3XXKTFptcHk1D5KTuuWYrkK9vKFdLhSmgEEYKwJYRNR/EpRlC3 P1vkqprXOJYvfyd5E8aLCrWoxJXAKNvn+wTiL2Ebe5ibQxbh0uBjTb1Hr +ZKwiYWigxLfGJm7rmicrztTfpP5cZDcPZ5iujAch/3lAg4taUchMBoMC onfiZ2bLbHfUxHP62/MPxX/R9FfUUl2/81gfAGNyTTbs3ofHkeHetyCxx RxDwUooXHCHmJdZVvnXIbT9QQcWq0Kj6fDy35wO/OtVREK4F38xuMVDb1 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10794"; a="367963811" X-IronPort-AV: E=Sophos;i="6.01,261,1684825200"; d="scan'208";a="367963811" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 02:56:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10794"; a="977379708" X-IronPort-AV: E=Sophos;i="6.01,261,1684825200"; d="scan'208";a="977379708" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga006.fm.intel.com with ESMTP; 07 Aug 2023 02:56:16 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 0C9AD17C; Mon, 7 Aug 2023 12:58:28 +0300 (EEST) From: Andy Shevchenko To: "Martin K. Petersen" , Justin Tee , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: James Smart , Dick Kennedy , "James E.J. Bottomley" , Andy Shevchenko Subject: [PATCH v1 1/1] scsi: lpfc: Do not abuse UUID APIs Date: Mon, 7 Aug 2023 12:58:23 +0300 Message-Id: <20230807095823.33902-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773568534382557154 X-GMAIL-MSGID: 1773573950948074304 The lpfc_vmid_host_uuid is not defined as uuid_t and its usage is not the same as for uuid_t operations (like exporting or importing). Hence replace call to uuid_is_null() by respective memchr_inv() without abusing casting. Signed-off-by: Andy Shevchenko --- drivers/scsi/lpfc/lpfc_els.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 2bad9954c355..14aece44cf43 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -1332,7 +1332,7 @@ lpfc_issue_els_flogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, if (phba->cfg_vmid_priority_tagging) { sp->cmn.priority_tagging = 1; /* lpfc_vmid_host_uuid is combination of wwpn and wwnn */ - if (uuid_is_null((uuid_t *)vport->lpfc_vmid_host_uuid)) { + if (memchr_inv(vport->lpfc_vmid_host_uuid, 0, LPFC_COMPRESS_VMID_SIZE)) { memcpy(vport->lpfc_vmid_host_uuid, phba->wwpn, sizeof(phba->wwpn)); memcpy(&vport->lpfc_vmid_host_uuid[8], phba->wwnn, @@ -12331,7 +12331,7 @@ lpfc_vmid_uvem(struct lpfc_vport *vport, elsiocb->vmid_tag.vmid_context = vmid_context; pcmd = (u8 *)elsiocb->cmd_dmabuf->virt; - if (uuid_is_null((uuid_t *)vport->lpfc_vmid_host_uuid)) + if (memchr_inv(vport->lpfc_vmid_host_uuid, 0, LPFC_COMPRESS_VMID_SIZE)) memcpy(vport->lpfc_vmid_host_uuid, vmid->host_vmid, LPFC_COMPRESS_VMID_SIZE);