From patchwork Mon Aug 7 09:24:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 131790 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp1361966vqr; Mon, 7 Aug 2023 03:53:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLFBLBYcytU/FucegI7RrHgo9eWwzLDFtaOFpG6mjsCvUMeExTANK+qm4P14Dxt1DDJ7kK X-Received: by 2002:a05:6512:3e16:b0:4fa:e7e5:66e0 with SMTP id i22-20020a0565123e1600b004fae7e566e0mr7533475lfv.48.1691405620436; Mon, 07 Aug 2023 03:53:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691405620; cv=none; d=google.com; s=arc-20160816; b=ge1Mk+pJZ5W1ZNp4zYkz2FZL7HN7HiwOFOhSSk+oS49vfYm6bjvg42Ce2HeXmR/KMR 6ZElEh/PbjdZhP8pnTHtVl4q90MBa+9LZ3k9OkN0IrmHIDPkCvzj+9LCAihOqyUt8Ahi 63JYza4iXH35k4A9rhLj0J6Ag9zxRMTm7EsVz9EMxGovsJBtIhUW4+neO4CRRu2a0iWB VWBBV+V7odNFNDmBSuHQ+Fl3oZbPS2AS4c+iGJPS06DKONnvpCFsdysLc/0iTjedkwgy vf62bZlgF9EEJgnqIA9Jff9s0P4qm+O0PbzJargjBEqSkND0CTuHVRQ6aOfIwy9r0tZh 9mKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=n123o8yW0UC4r/Oiw8lJSyqoS6ioNCVBJf2HFxUMh+A=; fh=BnHmLoAsuittPlboDXVahhauR+sXkoEO/Su0wRDVxEg=; b=beOM5BKxFQsFx4R6eksN4xSFQFIzIpHZqPflOh476mMwVguiWwAwrsb+CpHjO4fzEk fdDEugVCVUj5pHV+rbKrTFtNJaSBAA03z6K5zmO7mfwuyQLu3JGgS8n3NGHscL7/M2XP HRLF6OzpA74C6DgFbSUQ86eUD/2xjhqXftxQW3CJ7JH35fvnL716uK6US6l5ee4D1Ctt 5XpaBPQQ+OUtZXc584s9OMM/WPbM4Xq5pwBPgcOFUPhkz+mEbQDsX2smCGezoW1jminu UftUJbni5RPugUGIamPdOPwEbS2U8+gejk9ixTvLz7lsDzNv2Ex53QyubvZUT+qQUea8 fgdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f17-20020a056402151100b005222b88bb90si5580028edw.133.2023.08.07.03.53.17; Mon, 07 Aug 2023 03:53:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231544AbjHGJZA (ORCPT + 99 others); Mon, 7 Aug 2023 05:25:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231546AbjHGJYq (ORCPT ); Mon, 7 Aug 2023 05:24:46 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8139B173C for ; Mon, 7 Aug 2023 02:24:44 -0700 (PDT) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RK9pG4fzPzVkCV; Mon, 7 Aug 2023 17:22:46 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 7 Aug 2023 17:24:38 +0800 From: Ruan Jinjie To: , Arnd Bergmann , Greg Kroah-Hartman CC: Subject: [PATCH -next] misc: tps6594: Remove redundant dev_err_probe() for platform_get_irq_byname() Date: Mon, 7 Aug 2023 17:24:00 +0800 Message-ID: <20230807092400.2032692-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773562597036430915 X-GMAIL-MSGID: 1773567340156380186 There is no need to call the dev_err_probe() function directly to print a custom message when handling an error from platform_get_irq_byname() function as it is going to display an appropriate error message in case of a failure. Signed-off-by: Ruan Jinjie --- v2: - Update the commit title. --- drivers/misc/tps6594-esm.c | 3 +-- drivers/misc/tps6594-pfsm.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/misc/tps6594-esm.c b/drivers/misc/tps6594-esm.c index 68cc235181cc..b4d67a1a24e4 100644 --- a/drivers/misc/tps6594-esm.c +++ b/drivers/misc/tps6594-esm.c @@ -56,8 +56,7 @@ static int tps6594_esm_probe(struct platform_device *pdev) for (i = 0; i < pdev->num_resources; i++) { irq = platform_get_irq_byname(pdev, pdev->resource[i].name); if (irq < 0) - return dev_err_probe(dev, irq, "Failed to get %s irq\n", - pdev->resource[i].name); + return irq; ret = devm_request_threaded_irq(dev, irq, NULL, tps6594_esm_isr, IRQF_ONESHOT, diff --git a/drivers/misc/tps6594-pfsm.c b/drivers/misc/tps6594-pfsm.c index 0e24f8daaa9a..88dcac814892 100644 --- a/drivers/misc/tps6594-pfsm.c +++ b/drivers/misc/tps6594-pfsm.c @@ -266,8 +266,7 @@ static int tps6594_pfsm_probe(struct platform_device *pdev) for (i = 0 ; i < pdev->num_resources ; i++) { irq = platform_get_irq_byname(pdev, pdev->resource[i].name); if (irq < 0) - return dev_err_probe(dev, irq, "Failed to get %s irq\n", - pdev->resource[i].name); + return irq; ret = devm_request_threaded_irq(dev, irq, NULL, tps6594_pfsm_isr, IRQF_ONESHOT,