From patchwork Mon Aug 7 02:35:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 131660 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp1220395vqr; Sun, 6 Aug 2023 21:26:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFSSWV65xC8y21odiQ9nXxibRX89gWs59b4GuecUU4drlkehsfAK91NMQKd1XeNzUL+7prV X-Received: by 2002:a05:6a20:3d05:b0:13c:9317:ad78 with SMTP id y5-20020a056a203d0500b0013c9317ad78mr10060619pzi.46.1691382418513; Sun, 06 Aug 2023 21:26:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691382418; cv=none; d=google.com; s=arc-20160816; b=N1DVWgdLPoz751dZ3I4rTntt9O7rKz8E+agEktQeLrPb64y/0ATeONCmLyh0Ntr/fT MXjD5QJGO7zWzwrado97KofKkhJFoK2AvqVRToBWCv3mM2MZ15S3Vw5fZFp89YJKEOpq hOvv3rt3G8EOtOrRQV2jTlwDNp0/lON8siLJwpyObNaygOWMEbZfL5UO0J0VO+mObC4h QuxEIWK1svMEy4eZSmZBn/m+uPVsLj/uPqBglIrx7ZED5Eug5wORO4CznQVB14ifCJxE KQe/2mbGuTmR/q57UA2wMVv+p84j2WfN49bVVzGxBimQtoSou5kTUL6GmhkYOuogEmMB q2cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=rlJutPsbvY51rGhmnYEgexjqdDHgarVo+CQn5G/C4SY=; fh=58Vbeih7fsDE35/NICrnpvguf+48rCqJpZ2FHoxy3rE=; b=abLO94cFMDIQSIQAnQGwvT4JrMOtMR/Pa3G3aptGNd41iCATvwSOG63Vjcp5Zxhf6S AZFm2w7OyfDEZ3lQKVyug+NfB98gjLPvRKHRT0QmR1WS++aXCIAOQvure7eAca970DJh MM3AGAcidbh6CElKrlkub/7+1wz3vhjUw5n+/AmpkEYoF5f3pUYD33uYR9I8VV9kI7ER +nyEYnNpQw5dOLgKxPhxKmjoRYOu38/Wi7MBrUwQH1AI4i30914gWuJ7WR78sfmx16YU 47eE8kJa2haFd6NRcSyf9Ubstq6h73Iu1Au9wyeB49voZJgb7q+MVmvCFnvk+hlvL3+K NazA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b4-20020a170902d50400b001bc5fa2566fsi2413864plg.502.2023.08.06.21.26.45; Sun, 06 Aug 2023 21:26:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbjHGCf5 (ORCPT + 99 others); Sun, 6 Aug 2023 22:35:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229802AbjHGCfy (ORCPT ); Sun, 6 Aug 2023 22:35:54 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACAF81703 for ; Sun, 6 Aug 2023 19:35:52 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RK0kY4ttqzVk0x; Mon, 7 Aug 2023 10:33:57 +0800 (CST) Received: from huawei.com (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 7 Aug 2023 10:35:48 +0800 From: Miaohe Lin To: , CC: , , , Subject: [PATCH RESEND v2] mm/mm_init: use helper macro BITS_PER_LONG and BITS_PER_BYTE Date: Mon, 7 Aug 2023 10:35:28 +0800 Message-ID: <20230807023528.325191-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773537145366377948 X-GMAIL-MSGID: 1773543010975375645 It's more readable to use helper macro BITS_PER_LONG and BITS_PER_BYTE. No functional change intended. Signed-off-by: Miaohe Lin Reviewed-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) --- v2: use BITS_PER_BYTE per Mike. Collect Reviewed-by tag per David. Thanks both. --- mm/mm_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/mm_init.c b/mm/mm_init.c index 66aca3f6accd..93b1febd4a32 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -79,7 +79,7 @@ void __init mminit_verify_pageflags_layout(void) int shift, width; unsigned long or_mask, add_mask; - shift = 8 * sizeof(unsigned long); + shift = BITS_PER_LONG; width = shift - SECTIONS_WIDTH - NODES_WIDTH - ZONES_WIDTH - LAST_CPUPID_SHIFT - KASAN_TAG_WIDTH - LRU_GEN_WIDTH - LRU_REFS_WIDTH; mminit_dprintk(MMINIT_TRACE, "pageflags_layout_widths", @@ -1431,9 +1431,9 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l usemapsize = roundup(zonesize, pageblock_nr_pages); usemapsize = usemapsize >> pageblock_order; usemapsize *= NR_PAGEBLOCK_BITS; - usemapsize = roundup(usemapsize, 8 * sizeof(unsigned long)); + usemapsize = roundup(usemapsize, BITS_PER_LONG); - return usemapsize / 8; + return usemapsize / BITS_PER_BYTE; } static void __ref setup_usemap(struct zone *zone)