From patchwork Sat Aug 5 11:07:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 131424 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp239358vqr; Fri, 4 Aug 2023 20:16:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF+43TGSHFpM5qlpJAZOaLCORizH0PKGXSckc029WFstfmUgHRJozuDmBCikHOhNiH5Dlyt X-Received: by 2002:a17:906:32d9:b0:99b:49ac:5fc9 with SMTP id k25-20020a17090632d900b0099b49ac5fc9mr2960146ejk.30.1691205378726; Fri, 04 Aug 2023 20:16:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691205378; cv=none; d=google.com; s=arc-20160816; b=W39y14qEWoIsccdTNvhaDXU1jPSOoYntBH7Awbg0fPCjsrOYZo4O1SEEWJb8bwreRm 3r2+JUw55n9LpENAbFlSRSVuRSvlQVY3gx06Oc+WH2JscodkeOacMeIRRx5j8eGJ3cwK /Wn4TtPwtgfBZ7ipKq7W9CGIELEe84wuRRMrjO1/dx25LusU7w1YAfH6hksOSfbxfglL J6DDpDnQPdue3nT18FLROOJmtVyJdJkfTy9ap9n0ucPRS3R7M36CjmXAPnqBKNHHJSb6 SNeaXXlVhf7dVTUf7tLvLE1G9v1EUx1ReBBo4cmsJYdAISNOYWCgBvfNrQRgmSHH3u0m XM8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=TnEuM+JFuyPJEF5vsFmy3+0fVDqCpjqTmz6mI4Gk1yk=; fh=zpCCF/J8Z0sUUNZfCNdnaRvm94yhXPVxl9PzV22VU6k=; b=Cybbln76Z55wOO8w/1ZaNUGW8jPZCJKnG9jziDIdK8RY5kKxbJkmQ4djFjAAR86X21 xUNAmd90MXgHL0P2NwoVEnCB8m0zC8uR6v3htLqHNJyjio1+cdddAhiGz67+u8NgoblR 8XsK89t/0xqnwm8QPQwlHHf9mKXnudlBA8q64Wr4upb06V9swcf5gEJQ8MD03L9Wd68t sfrsTbH/7NJ0abeNCID3eibV+RBK/lrAattE3Plq1hx5ISh2As1CFzaVYaqCLt64unQQ +bJWuRc1U3tIKhJ/uIQjjrL4SPBhSdjib/YdA7okmAEcyMeFlV2Id7tXcPDpkjbHCddt pQ9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k23-20020aa7c397000000b00523271b3ee8si635991edq.199.2023.08.04.20.15.56; Fri, 04 Aug 2023 20:16:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229820AbjHEDH3 (ORCPT + 99 others); Fri, 4 Aug 2023 23:07:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229582AbjHEDHH (ORCPT ); Fri, 4 Aug 2023 23:07:07 -0400 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 020BB4EE7 for ; Fri, 4 Aug 2023 20:07:03 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4RHnYY2BzCz4f3lXB for ; Sat, 5 Aug 2023 11:06:57 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAHvrHQvM1k6A5ePg--.23962S7; Sat, 05 Aug 2023 11:07:00 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH 5/9] mm/compaction: remove repeat compact_blockskip_flush check in reset_isolation_suitable Date: Sat, 5 Aug 2023 19:07:07 +0800 Message-Id: <20230805110711.2975149-6-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230805110711.2975149-1-shikemeng@huaweicloud.com> References: <20230805110711.2975149-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAHvrHQvM1k6A5ePg--.23962S7 X-Coremail-Antispam: 1UD129KBjvdXoWruFyxur4ruw48JFyxCr15urg_yoW3Wrb_Jr n3KrsYyrW5ArykZrZrArsIyFs0gFWkAr1UWr1qqa1Yy3sIvFsYqa1DZF17Zr15XFW7Wr93 u3WrZFyYkF1fWjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDkFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJ M28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2I x0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK 6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4 xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8 JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20V AGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AK xVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr 1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sRiVbyDUU UUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773357371143565582 X-GMAIL-MSGID: 1773357371143565582 We have compact_blockskip_flush check in __reset_isolation_suitable, just remove repeat check before __reset_isolation_suitable in compact_blockskip_flush. Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang --- mm/compaction.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 8d7d38073d30..d8416d3dd445 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -434,9 +434,7 @@ void reset_isolation_suitable(pg_data_t *pgdat) if (!populated_zone(zone)) continue; - /* Only flush if a full compaction finished recently */ - if (zone->compact_blockskip_flush) - __reset_isolation_suitable(zone); + __reset_isolation_suitable(zone); } }