From patchwork Sat Aug 5 11:07:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 131422 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp238029vqr; Fri, 4 Aug 2023 20:11:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJ5QbXKms/DFRAPcljqkvuj5QcGt82QsBhCa2vdxFNyFDPC+VNy2hXOrMtoUMKhNmfp/5F X-Received: by 2002:a17:902:e74c:b0:1b6:68bb:6ad0 with SMTP id p12-20020a170902e74c00b001b668bb6ad0mr3882492plf.55.1691205119293; Fri, 04 Aug 2023 20:11:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691205119; cv=none; d=google.com; s=arc-20160816; b=gBTTlgvKKuFbaFP0NMo+LY/xsaMIFaKbTGRBkBfhMJA/TyXBOYfmDgm2lxHaLS+Sc0 IZZZxJsDFULDfZgDykBPaquWO5dMPhBDmprrPMENKgUrL1oGR81AT5KwE4BIaeKRqVRW TEy6lkp2Rpf23peQpRMHikbrIAewtSMhzK3u/Hfy9QVb8JT6Vr/bWikjyHM4IjVWubyx 7cbw8hzv1rPzXHkQts3Lah4VpP7r08Y0oTQJAx2lntRmSG3qIxXP+t1pQQlEE4gwiK6f teSM5m/RnIMNG1fYjnMxlsr04m1e3oHof1/tSeR4bG6OSMTaLC906Deui9m/aPHJmAcx b6ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Ip9YPHoUgbg2kf8BGxCk2yJU0rgMI20c0mbtH437+3M=; fh=zpCCF/J8Z0sUUNZfCNdnaRvm94yhXPVxl9PzV22VU6k=; b=lxh8jEROcdvP9e1WO899nKHaC54LTb/SRnZfGBes+naHsTjP96gGIilcAE46eqGC2+ +93GudGx5hImBGoU+IN6qSkT9dYChIuoHSlu/Q4oZOIF4AL8T2/QyKeHccrXsmxgYn4D GG+DFx4xUU7QLppPC8W0ehewnSVQJ4DPbHHrd1/foduAgL3+00fCgPNhKWaDq8EZP9Zi C2f8VdVgqsJ1KUK7ycV+ECvbEvKT1fND6N7plc4Q7Dy+73mMe3E9P9bZvO328PfvJfN/ iiT7sSh13/1STkUiYi2czZ72WcnEQ5jJoczYlYfcNSgr/TSENU95hHaXS9e1PRS8V0Om boYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q17-20020a170902dad100b001bbbfe262e2si892840plx.430.2023.08.04.20.11.46; Fri, 04 Aug 2023 20:11:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbjHEDHJ (ORCPT + 99 others); Fri, 4 Aug 2023 23:07:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjHEDHD (ORCPT ); Fri, 4 Aug 2023 23:07:03 -0400 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF5164EE1 for ; Fri, 4 Aug 2023 20:07:01 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RHnYY4hnfz4f3jM7 for ; Sat, 5 Aug 2023 11:06:57 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAHvrHQvM1k6A5ePg--.23962S3; Sat, 05 Aug 2023 11:06:58 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH 1/9] mm/compaction: use correct list in move_freelist_{head}/{tail} Date: Sat, 5 Aug 2023 19:07:03 +0800 Message-Id: <20230805110711.2975149-2-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230805110711.2975149-1-shikemeng@huaweicloud.com> References: <20230805110711.2975149-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAHvrHQvM1k6A5ePg--.23962S3 X-Coremail-Antispam: 1UD129KBjvJXoW7Gw47KFW8urWftr18Jr43Wrg_yoW8JF18pr y5Cr4UXr4UArWFyFnrXa1q9w18tF42vrWjkrZ8uFWDAFn8trW2qF9ayF4UZ3s3XrWjkrWY vrZrKF43GrW3Ar7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBE14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2jI8I6cxK62vIxIIY0VWUZVW8XwA2048vs2IY02 0E87I2jVAFwI0_Jr4l82xGYIkIc2x26xkF7I0E14v26r1I6r4UM28lY4IEw2IIxxk0rwA2 F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjx v20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2 z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0V AKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1l Ox8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErc IFxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v2 6r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2 Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_ Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMI IF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0pR3PE3UUUUU = X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773357098835629686 X-GMAIL-MSGID: 1773357098835629686 The freepage is chained with buddy_list in freelist head. Use buddy_list instead of lru to correct the list operation. Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang --- mm/compaction.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index ea61922a1619..513b1caeb4fa 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1395,8 +1395,8 @@ move_freelist_head(struct list_head *freelist, struct page *freepage) { LIST_HEAD(sublist); - if (!list_is_last(freelist, &freepage->lru)) { - list_cut_before(&sublist, freelist, &freepage->lru); + if (!list_is_last(freelist, &freepage->buddy_list)) { + list_cut_before(&sublist, freelist, &freepage->buddy_list); list_splice_tail(&sublist, freelist); } } @@ -1412,8 +1412,8 @@ move_freelist_tail(struct list_head *freelist, struct page *freepage) { LIST_HEAD(sublist); - if (!list_is_first(freelist, &freepage->lru)) { - list_cut_position(&sublist, freelist, &freepage->lru); + if (!list_is_first(freelist, &freepage->buddy_list)) { + list_cut_position(&sublist, freelist, &freepage->buddy_list); list_splice_tail(&sublist, freelist); } }