arm64: dts: qcom: sc8280xp-x13s: Add camera activity LED

Message ID 20230805-topic-x13s_cam_led-v1-1-443d752158c4@linaro.org
State New
Headers
Series arm64: dts: qcom: sc8280xp-x13s: Add camera activity LED |

Commit Message

Konrad Dybcio Aug. 5, 2023, 9:01 a.m. UTC
  Disappointigly, the camera activity LED is implemented in software.
Hook it up as a gpio-led and (until we have camera *and* a "camera on"
LED trigger) configure it as a panic indicator.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 .../boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts      | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)


---
base-commit: bdffb18b5dd8071cd25685b966f380a30b1fadaa
change-id: 20230805-topic-x13s_cam_led-e42c3f90d7c9

Best regards,
  

Comments

Bjorn Andersson Aug. 14, 2023, 3:27 a.m. UTC | #1
On Sat, 05 Aug 2023 11:01:33 +0200, Konrad Dybcio wrote:
> Disappointigly, the camera activity LED is implemented in software.
> Hook it up as a gpio-led and (until we have camera *and* a "camera on"
> LED trigger) configure it as a panic indicator.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sc8280xp-x13s: Add camera activity LED
      commit: 1c63dd1c5fdafa8854526d7d60d2b741c813678d

Best regards,
  

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index ffcca4f028e7..24e49b0e1131 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -12,6 +12,7 @@ 
 #include <dt-bindings/iio/qcom,spmi-adc7-pmr735a.h>
 #include <dt-bindings/input/gpio-keys.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 
 #include "sc8280xp.dtsi"
@@ -78,6 +79,21 @@  switch-lid {
 		};
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		led-camera-indicator {
+			label = "white:camera-indicator";
+			function = LED_FUNCTION_INDICATOR;
+			color = <LED_COLOR_ID_WHITE>;
+			gpios = <&tlmm 28 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "none";
+			default-state = "off";
+			/* Reuse as a panic indicator until we get a "camera on" trigger */
+			panic-indicator;
+		};
+	};
+
 	pmic-glink {
 		compatible = "qcom,sc8280xp-pmic-glink", "qcom,pmic-glink";