From patchwork Fri Aug 4 06:50:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 130999 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:44a:b0:3f2:4152:657d with SMTP id ez10csp96774vqb; Fri, 4 Aug 2023 00:53:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHt9DsLGyCMpp0EeQalSz/s/TBjPOn3cu0EO9IqIlydUZZO4B7wb0VwR6L8tQFU84xjG0x/ X-Received: by 2002:a05:6a20:728f:b0:12f:952:11fb with SMTP id o15-20020a056a20728f00b0012f095211fbmr953289pzk.52.1691135601848; Fri, 04 Aug 2023 00:53:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691135601; cv=none; d=google.com; s=arc-20160816; b=KcMw95L8zGSdRYjfVVEV6w3wIaqhGKQH7xRW2ofJ+h464JYfqxO0CJDNLmCQaoUN6v MS73SiW/F9kknh6jZDzZ0QJeRJlqTSffVvTtUV6WmNM+oHEHoBIl0b8XK8Mp9YjxU0pq ycfCvVX+bkp7BzixsGxHK2QB29DXUpmKsAiwDBZlMAfDbGVQA8paC/BmK7P85m7+jLSr aefQzQi8rlXiOAlsatpgS2KQAazbkPC3HvCZtpqGBceLexnd+jxR7tVoN03LApSMVZLE KLpqNu9gMcXlWX2U2/7oFL/cnuhjSQzq5tRb2UClMnvRSA7au+1QgJidbe3p7l8SGOSI XQnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6+OCmkB89lJ9QhqUH4GLLqFHcU5/CM75quLqXRzfOwY=; fh=trl8IP3/IStrfUzErWPHTQPip+nFa0aNkVvc3yxpI3E=; b=fIYAsr3WWWDDhf0fWt2PAmfZm0BOHUZgrFyLgPRu2jWw+2RiUlP2fvVKfvDRVVjHfN UnijZmDegqaK8n/JzDHRVIFVuixIBC9MvmKLZ0Wq+MjRImzcDXTPrs4JNd3vwlL+oCMd h0agdpjpNtROKwdiRIy/cO+THdprnJD5fjVcyleci2dOGjX+VcrM8SW/lAlGmxFMhBoG OV+/BQmvKY4PSZS5Sm6PHXS5PHROGZyleQpP/DpBYyYjcP+D4+vaa+OJDqYgsDd2Xu8k 4U56M3oa1EPXpy2F9pg5uo3Z8tQDOaP8QpuDPv2SAlKVlIUw25f2jEaU++Mc20sauKQo Ez5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=oH0V0+nU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f11-20020a056a0022cb00b00686e7b259fcsi1418561pfj.184.2023.08.04.00.53.09; Fri, 04 Aug 2023 00:53:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=oH0V0+nU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233746AbjHDGvv (ORCPT + 99 others); Fri, 4 Aug 2023 02:51:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233957AbjHDGvX (ORCPT ); Fri, 4 Aug 2023 02:51:23 -0400 Received: from out-106.mta1.migadu.com (out-106.mta1.migadu.com [IPv6:2001:41d0:203:375::6a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 438DAE69 for ; Thu, 3 Aug 2023 23:51:01 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691131858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6+OCmkB89lJ9QhqUH4GLLqFHcU5/CM75quLqXRzfOwY=; b=oH0V0+nUwhj+72gwRc5ePHbuqdLY/xtqB7P0DP84CcRPglVSIUiSlTqBKcH5X9gWCF69Y3 ALYeZ+iP0YR4jahdwaAvrK7vez+SbpXMeCDnYRQQ+x76r27KkBQPrwryjXUHDHBZqGsFl7 W0whfcJRbxal3QLq7RCQygin4tnNfq4= From: chengming.zhou@linux.dev To: axboe@kernel.dk, tj@kernel.org Cc: linux-kernel@vger.kernel.org, zhouchengming@bytedance.com Subject: [PATCH 3/3] iocost_monitor: improve it by adding iocg wait_ms Date: Fri, 4 Aug 2023 14:50:39 +0800 Message-ID: <20230804065039.8885-3-chengming.zhou@linux.dev> In-Reply-To: <20230804065039.8885-1-chengming.zhou@linux.dev> References: <20230804065039.8885-1-chengming.zhou@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773284204744225333 X-GMAIL-MSGID: 1773284204744225333 From: Chengming Zhou The iocg can have three throttled metrics: wait, debt, delay. This patch add missing wait_ms to IocgStat to show the latest wait_ms of iocg. As we are here, group iocg usage percents "inflt%" and "usage%" together, and group iocg throttled metrics "wait", "debt" and "delay" together. Effect after changes: nvme0n1 RUN per=50.0ms cur_per=177105.713:v1053528.587 busy= +0 vrate=135.00%:270.00% params=ssd_dfl(CQ) active weight hweight% inflt% usage% wait debt delay InterfererGroup0 * 100/ 100 54.28/ 9.09 0.34 24.07 0.00 0.00 0.00 interfered * 84/ 1000 45.72/ 90.91 0.48 41.09 0.00 0.00 0.00 Signed-off-by: Chengming Zhou Acked-by: Tejun Heo --- tools/cgroup/iocost_monitor.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/cgroup/iocost_monitor.py b/tools/cgroup/iocost_monitor.py index 52ae9d1595b2..933c750b319b 100644 --- a/tools/cgroup/iocost_monitor.py +++ b/tools/cgroup/iocost_monitor.py @@ -138,7 +138,7 @@ class IocStat: def table_header_str(self): return f'{"":25} active {"weight":>9} {"hweight%":>13} {"inflt%":>6} ' \ - f'{"debt":>7} {"delay":>7} {"usage%"}' + f'{"usage%":>6} {"wait":>7} {"debt":>7} {"delay":>7}' class IocgStat: def __init__(self, iocg): @@ -164,6 +164,8 @@ class IocgStat: self.usage = (100 * iocg.usage_delta_us.value_() / ioc.period_us.value_()) if self.active else 0 + self.wait_ms = (iocg.stat.wait_us.value_() - + iocg.last_stat.wait_us.value_()) / 1000 self.debt_ms = iocg.abs_vdebt.value_() / VTIME_PER_USEC / 1000 if blkg.use_delay.counter.value_() != 0: self.delay_ms = blkg.delay_nsec.counter.value_() / 1_000_000 @@ -180,9 +182,10 @@ class IocgStat: 'hweight_active_pct' : self.hwa_pct, 'hweight_inuse_pct' : self.hwi_pct, 'inflight_pct' : self.inflight_pct, + 'usage_pct' : self.usage, + 'wait_ms' : self.wait_ms, 'debt_ms' : self.debt_ms, 'delay_ms' : self.delay_ms, - 'usage_pct' : self.usage, 'address' : self.address } return out @@ -192,9 +195,10 @@ class IocgStat: f'{round(self.inuse):5}/{round(self.active):5} ' \ f'{self.hwi_pct:6.2f}/{self.hwa_pct:6.2f} ' \ f'{self.inflight_pct:6.2f} ' \ + f'{min(self.usage, 999):6.2f} ' \ + f'{self.wait_ms:7.2f} ' \ f'{self.debt_ms:7.2f} ' \ - f'{self.delay_ms:7.2f} '\ - f'{min(self.usage, 999):6.2f}' + f'{self.delay_ms:7.2f}' out = out.rstrip(':') return out