From patchwork Thu Aug 3 13:29:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Kuai X-Patchwork-Id: 130610 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1155547vqx; Thu, 3 Aug 2023 06:40:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlHa8BKOPZQTkkPEAJy+z/Ib6mUkAEy+Q/6AcJ5MxkNLG6MV8ZJkC6kdnmSIB/O0izQ6LUrh X-Received: by 2002:a05:6300:8086:b0:12d:ba1e:d763 with SMTP id ap6-20020a056300808600b0012dba1ed763mr17788768pzc.7.1691070027934; Thu, 03 Aug 2023 06:40:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691070027; cv=none; d=google.com; s=arc-20160816; b=l/z58XI6tsGs4ZFaB1uFk/BWd35nmSZR4Y/56S/dnU8Usxe/xJ+LlAlqlPLGnDarmh NcUn1sQkGajIBS7cJ4MBgKNLHmOCz2wWQzRUMyU6YqfXfUbkFUfIo8KTYa0idA1+QKS4 HUbLxqfWBhmfgFCxhse3K8guinODs3sYf8Aq56YSwDRw+cRO/+3YoRS/E3uI4E4lNtgy z6EsaIvKIIDoU/H5BRqPEzEu1eKjN4tS2oy3ALKXY/Hwvx106nWkQECwIyMkJN6uKX1r YJiYE8NMfY3NuXhd+KshXoh1DVORzmaeuXn+l86P+zP7zyUcRcdLw0VJi0WshnRHp1sY ye+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=OCuMk7HrW3h5GeYZZG9elcVYrkKUqBvLRQAuiy/Q2r0=; fh=Ktvf84aTmiKPjIiQsnocICsaz7FvZSNYviQ4CE4oKUo=; b=pOLQBKZSUDLqR1usKlqnO7AUsoGp+LFBnbgpyACF5TC0YtMmNdGZbFUyVibaQUM06i cyD222METXGafrQWtVwyLbu70WJihYEOWFj/d47uVG0p8qRDZ4ymGzMok1LppmrPljJZ XB4aXS2LhzmxIWjKaX09MH+d6CApqvg2aqgYAWVGP3faMwDqjkYD7iI4ii9Ubgz+WxSh XEgj7+ZKNT4SYFpuzB48FXBlLkhftZQ2dupqXKd5bxVfjMgU4yoCkWWxBmIxZ3PELENA 5imLC49aMpziPNqXsuRYCZ3fJ2oclHocMFKhR1rLhM3wPGOIxTPwyCBR3uQqlVijbqVR pyUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bg26-20020a056a02011a00b00563e0efb8f4si1739771pgb.835.2023.08.03.06.40.10; Thu, 03 Aug 2023 06:40:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236024AbjHCNec (ORCPT + 99 others); Thu, 3 Aug 2023 09:34:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235406AbjHCNdo (ORCPT ); Thu, 3 Aug 2023 09:33:44 -0400 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E99230D3; Thu, 3 Aug 2023 06:32:32 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RGqXD6ZP9z4f3lW7; Thu, 3 Aug 2023 21:32:28 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgAHuKtqrMtkWHLlPQ--.49699S11; Thu, 03 Aug 2023 21:32:29 +0800 (CST) From: Yu Kuai To: song@kernel.org, xni@redhat.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: [PATCH -next 07/29] md: use new apis to suspend array for serialize_policy_store() Date: Thu, 3 Aug 2023 21:29:08 +0800 Message-Id: <20230803132930.2742286-8-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230803132930.2742286-1-yukuai1@huaweicloud.com> References: <20230803132930.2742286-1-yukuai1@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAHuKtqrMtkWHLlPQ--.49699S11 X-Coremail-Antispam: 1UD129KBjvdXoWrZFWUZF4ftFW5XryUKF1xKrg_yoWkCwb_CF s5u3yfJr9xXry5tr1IkwsavryFyrn5WwnrXFyftFW3AFZ8tF9Ykr95CrZ0qws2vayxWa4U trya9w47Xr4DKjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbf8FF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUAVCq3wA2048vs2 IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28E F7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr 1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0D M2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjx v20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1l F7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48JMx C20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAF wI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20x vE14v26ryj6F1UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UMIIF0xvE42xK8VAv wI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I0E14 v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7VUbeMKtUUUUU== X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, MAY_BE_FORGED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773215445574424135 X-GMAIL-MSGID: 1773215445574424135 From: Yu Kuai Convert to use new apis, the old apis will be removed eventually. This is not hot path, so performance is not concerned. Signed-off-by: Yu Kuai --- drivers/md/md.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index fc1646f02ef3..765667b5fa59 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -5548,7 +5548,7 @@ serialize_policy_store(struct mddev *mddev, const char *buf, size_t len) if (value == mddev->serialize_policy) return len; - err = mddev_lock(mddev); + err = mddev_suspend_and_lock(mddev); if (err) return err; if (mddev->pers == NULL || (mddev->pers->level != 1)) { @@ -5557,15 +5557,13 @@ serialize_policy_store(struct mddev *mddev, const char *buf, size_t len) goto unlock; } - mddev_suspend(mddev); if (value) mddev_create_serial_pool(mddev, NULL, true); else mddev_destroy_serial_pool(mddev, NULL, true); mddev->serialize_policy = value; - mddev_resume(mddev); unlock: - mddev_unlock(mddev); + mddev_unlock_and_resume(mddev); return err ?: len; }