From patchwork Thu Aug 3 13:29:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Kuai X-Patchwork-Id: 130606 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1153720vqx; Thu, 3 Aug 2023 06:37:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlEUN0KLrM8rYYV5Ae8+32wyzFaR5s7i4vTzVxe3tKm5VrWayIyqsRhHUMLsSwmLqQmYqEwi X-Received: by 2002:a05:6a00:1353:b0:686:efda:76a2 with SMTP id k19-20020a056a00135300b00686efda76a2mr19475459pfu.29.1691069839025; Thu, 03 Aug 2023 06:37:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691069839; cv=none; d=google.com; s=arc-20160816; b=n91p2BVFsg+QkMvJYIW8wFnUWhKy6n7snIHrxivM5UQ6CyaKALk3oYQa+DErtE81OA ZT5Jsd+yvmSYR694ZMuN6TT6aKRPEWKp18kBqFN1hhj8k7W1Bj6I1y4SDNAjVTpz8R3A yc8EU1qRnEBjdkhC5badZ2w0BUVvG60n0ViCJE04Tna3d3zWd0QSwdxXucKuHzMxOq4l hfjwCqzALz+6cEIcx/AWaHHxcV7a3LwCjKsduJlXKTUuxnktaelJyP8I8MXrxPVqV9m4 e1dwDu0SOq+mCjyb75mDhnRLS9PcVf/+RATy5i02ZiHbx7GeDZ+Jv2R4CC4k5KaWR8AB Io0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=bdYCb3nSPMjXfgTrkcV/KohA3yWFbAfO904Q7V3Y8xk=; fh=Ktvf84aTmiKPjIiQsnocICsaz7FvZSNYviQ4CE4oKUo=; b=Z/UtKeZMx5py+jkpzBlH4+JByZhmblRiH39PJfQ1rBm/JaDH0K8OVe1Wv6rRzTKYk3 BqDnTknQx9kNE/2/6+CB1Itr7IDR7R6E1WBuZbNejDGvw3NEDo9JbGs9DmzhrG5SQo+0 pcPFVyLwFksaEf+dfZalBn0TtsFCa5OGKeUYeqOq9kmXdSReOCNKKZSYiPSoNpjpEx57 x+oGmXv1qYsH47JQTduqXqufD08SXDlxw9hfFf0iHDgGJwtRQUH21Pzr1pTTM/0AYJZL zDG5wJMXAgcdSXM7sGENtKU4Cst33CKWLOgAXDUghaczgsfJi5l3Wf6UrLpcTQSkdVc7 cDrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bg26-20020a056a02011a00b00563e0efb8f4si1739771pgb.835.2023.08.03.06.37.04; Thu, 03 Aug 2023 06:37:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236286AbjHCNeL (ORCPT + 99 others); Thu, 3 Aug 2023 09:34:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235264AbjHCNdl (ORCPT ); Thu, 3 Aug 2023 09:33:41 -0400 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9311146AA; Thu, 3 Aug 2023 06:32:32 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RGqXD3pLyz4f3lVX; Thu, 3 Aug 2023 21:32:28 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgAHuKtqrMtkWHLlPQ--.49699S10; Thu, 03 Aug 2023 21:32:29 +0800 (CST) From: Yu Kuai To: song@kernel.org, xni@redhat.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: [PATCH -next 06/29] md: use new apis to suspend array for level_store() Date: Thu, 3 Aug 2023 21:29:07 +0800 Message-Id: <20230803132930.2742286-7-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230803132930.2742286-1-yukuai1@huaweicloud.com> References: <20230803132930.2742286-1-yukuai1@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAHuKtqrMtkWHLlPQ--.49699S10 X-Coremail-Antispam: 1UD129KBjvJXoW7WF4DuF48CF1rJrykArW5Wrg_yoW8Gr17pa 1xKFWrGr1jv3ySqr1DGF4kCa45Jw1jgrWqkrZrZwn7ZF1xXr9rWw1ruFs8XFy8Ja4rArs8 Xw45Ga4rXrW8JaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBj14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYI kIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2 z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F 4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq 3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7 IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4U M4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCF04k20xvY0x0EwIxGrw CFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE 14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2 IY67AKxVW5JVW7JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwCI42IY6xAIw20E Y4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267 AKxVW8Jr0_Cr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUqiihUUUUU= X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, MAY_BE_FORGED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773215247390351648 X-GMAIL-MSGID: 1773215247390351648 From: Yu Kuai Convert to use new apis, the old apis will be removed eventually. This is not hot path, so performance is not concerned. Signed-off-by: Yu Kuai --- drivers/md/md.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index e516c5000a00..fc1646f02ef3 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -4001,7 +4001,7 @@ level_store(struct mddev *mddev, const char *buf, size_t len) if (slen == 0 || slen >= sizeof(clevel)) return -EINVAL; - rv = mddev_lock(mddev); + rv = mddev_suspend_and_lock(mddev); if (rv) return rv; @@ -4094,7 +4094,6 @@ level_store(struct mddev *mddev, const char *buf, size_t len) } /* Looks like we have a winner */ - mddev_suspend(mddev); mddev_detach(mddev); spin_lock(&mddev->lock); @@ -4180,14 +4179,13 @@ level_store(struct mddev *mddev, const char *buf, size_t len) blk_set_stacking_limits(&mddev->queue->limits); pers->run(mddev); set_bit(MD_SB_CHANGE_DEVS, &mddev->sb_flags); - mddev_resume(mddev); if (!mddev->thread) md_update_sb(mddev, 1); sysfs_notify_dirent_safe(mddev->sysfs_level); md_new_event(); rv = len; out_unlock: - mddev_unlock(mddev); + mddev_unlock_and_resume(mddev); return rv; }