From patchwork Thu Aug 3 13:29:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Kuai X-Patchwork-Id: 130651 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1175165vqx; Thu, 3 Aug 2023 07:10:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlHr874J54pWKU0kJfgBeEGIUYZ/Az6olyHrJdm1dyiMN/nA0ehR1GLX2cMb/3+inDi2wsKD X-Received: by 2002:a17:906:2ca:b0:992:13c7:563 with SMTP id 10-20020a17090602ca00b0099213c70563mr9068466ejk.75.1691071828482; Thu, 03 Aug 2023 07:10:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691071828; cv=none; d=google.com; s=arc-20160816; b=WlDnpAzCM/s11ILBv4V3kh4VGXAvKpUDvA/4tQoCI33jpQZy83hv7mF4ji7K50lsBX J/VXcFVd61USNZkctZuvXP8PtzjhRZLj50rZkyuBWPQfBSp9BCATx1J1e5y+medMq8HU +rdkOlPoJl7qdHGRfbn2JUYez8k66WOvzJFohYQSOXZHKxpajGoyBR23XUHfbRGyUvzh qVopxiLzJCTvFG8A4ooev7YFbbDvubZs1sUVWX7IbVihiUCDIJgOBdpIiit9L8erIIso sdTCArMoFG7DB8EzBEAWyBexKxpe4GzyiQnfZ8wIhWjBII2o48LIfJikikq1fcQjj7va 2EIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=5gV5li7nOHKpNLEPWesrEtbzPWaT/9ndN0BE1YDbbr8=; fh=Ktvf84aTmiKPjIiQsnocICsaz7FvZSNYviQ4CE4oKUo=; b=pJY751+FZnmX6zrXApgEg50B4iBEn9p8po+FFd9evRbzU3x+fFus4aTU5vU3o16J6P KdmrD8XctduvSokfL1XQCP1FW/w7jWqUPDVrgZxi2CYD+wieggZbu++s3XLfi2l5THcw qqgqOFK9pnAJqYdh9C+WYfJQmanERdZ4qxX1MEUaMWpQzHyTNbydD02aEDFQ98CTc4/3 iV5sf7Oq/f3gvln/CRtt+bR/C15+0SY7XH5iEPvUY6HLfu5NPnk7Vo6EVuzbT6haX384 ViMx359K5GoBOCyKdjZNJqcNNJHptpeJgT0L53ap7nuIdnmd90uU0UJ5i5Sh+jdeuEgs eNSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w27-20020a170906481b00b00992b54ad681si11452160ejq.773.2023.08.03.07.09.58; Thu, 03 Aug 2023 07:10:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235842AbjHCNeI (ORCPT + 99 others); Thu, 3 Aug 2023 09:34:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235229AbjHCNdl (ORCPT ); Thu, 3 Aug 2023 09:33:41 -0400 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0296146A1; Thu, 3 Aug 2023 06:32:32 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RGqXD2NK6z4f44xM; Thu, 3 Aug 2023 21:32:28 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgAHuKtqrMtkWHLlPQ--.49699S8; Thu, 03 Aug 2023 21:32:28 +0800 (CST) From: Yu Kuai To: song@kernel.org, xni@redhat.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: [PATCH -next 04/29] md: add new helpers to suspend/resume and lock/unlock array Date: Thu, 3 Aug 2023 21:29:05 +0800 Message-Id: <20230803132930.2742286-5-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230803132930.2742286-1-yukuai1@huaweicloud.com> References: <20230803132930.2742286-1-yukuai1@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAHuKtqrMtkWHLlPQ--.49699S8 X-Coremail-Antispam: 1UD129KBjvJXoWxJr1fGw18Gw4rKFy7GF47twb_yoW8Cr47pr 4IqFWrGr4jyFWfXrW3Aan7ua45Aw10grZFyrW3Gwn7ua47J347GF15Wr1UJrnYkayfJr1D Ja1Yq348CrWUGFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBj14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYI kIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2 z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F 4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq 3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7 IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4U M4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCF04k20xvY0x0EwIxGrw CFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE 14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2 IY67AKxVW5JVW7JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwCI42IY6xAIw20E Y4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267 AKxVW8Jr0_Cr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUqiihUUUUU= X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, MAY_BE_FORGED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773217333224951563 X-GMAIL-MSGID: 1773217333224951563 From: Yu Kuai The new helpers suspend the array first and then lock the array, Prepare to refactor from: mddev_lock/trylock/lock_nointr mddev_suspend/pers->quiesce mddev_resuem/pers->unquiesce mddev_lock With: mddev_suspend_and_lock/trylock/lock_nointr mddev_unlock_and_resume After all the use cases is refactored, mddev_suspend/resume() will be removed. And mddev_suspend_and_lock() will also replace mddev_lock() for the case that the array will be reconfigured, in order to synchronize with io to prevent problems in many corner cases. Signed-off-by: Yu Kuai --- drivers/md/md.h | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/drivers/md/md.h b/drivers/md/md.h index 32bfe0fe0d97..3a2488231fd2 100644 --- a/drivers/md/md.h +++ b/drivers/md/md.h @@ -850,6 +850,42 @@ static inline void mddev_check_write_zeroes(struct mddev *mddev, struct bio *bio mddev->queue->limits.max_write_zeroes_sectors = 0; } +static inline int mddev_suspend_and_lock(struct mddev *mddev) +{ + int ret; + + __mddev_suspend(mddev); + ret = mddev_lock(mddev); + if (ret) + __mddev_resume(mddev); + + return ret; +} + +static inline void mddev_suspend_and_lock_nointr(struct mddev *mddev) +{ + __mddev_suspend(mddev); + mutex_lock(&mddev->reconfig_mutex); +} + +static inline int mddev_suspend_and_trylock(struct mddev *mddev) +{ + int ret; + + __mddev_suspend(mddev); + ret = mutex_trylock(&mddev->reconfig_mutex); + if (ret) + __mddev_resume(mddev); + + return ret; +} + +static inline void mddev_unlock_and_resume(struct mddev *mddev) +{ + mddev_unlock(mddev); + __mddev_resume(mddev); +} + struct mdu_array_info_s; struct mdu_disk_info_s;