From patchwork Thu Aug 3 09:49:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 130251 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp861520vqx; Wed, 2 Aug 2023 19:26:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlGJ2v9Phksvdioo+aMt6bwiLps4QzZVWHDkOWoWjXQk9DXUZiO+YOEovz+hdt3TgRRoBIjF X-Received: by 2002:a05:6402:4315:b0:521:7a4b:9d1 with SMTP id m21-20020a056402431500b005217a4b09d1mr12760608edc.2.1691029602544; Wed, 02 Aug 2023 19:26:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691029602; cv=none; d=google.com; s=arc-20160816; b=WyQ/4YbBri5LnpqN+dm785Ax4miSZNajHywpqXv44U598w5DoU0V9VOzb+Om2M3fwy wnJ2bgp09Uw+XvrOzI0p+CtJnuTG2p/WUkHa9jKGqFhjUA8GcdO1ByRmAivSwzrca5N5 jWGPZ3e7LfttLfTZIG5JmSsoEgpHrYmitvtONMgSJ/aMUVud1ctIq/uSEr1kE7c2UA35 +jiupHps55ZZvRcSff2t9brCFVnd/nb1H+b27MYp3fFIlPn6k8xkWrrCjD/MbB+zo6Bj WIaYc5PpK9fh7OlVMf8+6qPUldQYh0s8eBGXsPhOplhJXip5yvxNxqLzhqOy5mt9osKj yKkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=vI4rRUi6esE6myAhM7XZL+ZaNSQFTFDk8e/xUXRBUDs=; fh=zpCCF/J8Z0sUUNZfCNdnaRvm94yhXPVxl9PzV22VU6k=; b=UMwbDYNNa+5jXTpfL5yTnxxEFwL9QA/NfOR/GScBFDGDDHAcBe/2NLVvTa73BUezYE L8dQsM80LPmJEdtdfVfYhAN7lXI4Pp5J+SpVsu3McGnaIc6brzmcxp2PaBcYrqGti5n9 NCJ4G7h2HULnXudQjlQwNAyuqRVC/NRBzph+gLUixLiAZoRkf2AoLJCcJCsXSPLU22Mr aHDwrVKsD4WsoENH9ueUOY2XzRDKlTgBLimNaA+SKFh/SzfkjjXJoohy23Wp0BkvBJQN R+RAjXWq2g88de1dto676b4DZhW3m/MX/SxMTAS9KxXdvjMuzHLujlTy0v7sTWrBGMCa wPZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e19-20020a50ec93000000b00521d28a47e5si870404edr.359.2023.08.02.19.26.19; Wed, 02 Aug 2023 19:26:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232819AbjHCBty (ORCPT + 99 others); Wed, 2 Aug 2023 21:49:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231444AbjHCBtA (ORCPT ); Wed, 2 Aug 2023 21:49:00 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A16E730F6 for ; Wed, 2 Aug 2023 18:48:49 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.169]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RGWwG2QPLz4f404C for ; Thu, 3 Aug 2023 09:48:46 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP3 (Coremail) with SMTP id _Ch0CgCXQiB7B8tkVa5vOQ--.12634S6; Thu, 03 Aug 2023 09:48:46 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH v2 4/4] mm/compaction: remove unnecessary "else continue" at end of loop in isolate_freepages_block Date: Thu, 3 Aug 2023 17:49:01 +0800 Message-Id: <20230803094901.2915942-5-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230803094901.2915942-1-shikemeng@huaweicloud.com> References: <20230803094901.2915942-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: _Ch0CgCXQiB7B8tkVa5vOQ--.12634S6 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUOb7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E 6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JF v_Gryl82xGYIkIc2x26280x7IE14v26r126s0DM28IrcIa0xkI8VCY1x0267AKxVW5JVCq 3wA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w 1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AK xVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcV AaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0E x4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI 8F5VA0II8E6IAqYI8I648v4I1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_ Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17 CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0 I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I 8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73 UjIFyTuYvjTRKfOwUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773173056520510174 X-GMAIL-MSGID: 1773173056520510174 There is no behavior change to remove "else continue" code at end of scan loop. Just remove it to make code cleaner. Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang Reviewed-by: David Hildenbrand --- mm/compaction.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index cb1dd5c5bf3f..006fc35bffa1 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -666,8 +666,6 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, isolate_fail: if (strict) break; - else - continue; }