From patchwork Thu Aug 3 09:48:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 130249 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp860504vqx; Wed, 2 Aug 2023 19:23:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlEB8iTlO5vHkOkQWDRtZHDoapHMiaz0bNjnm2JbYQS78eXU2sF/gwCcjg6987NHOVtcLv67 X-Received: by 2002:a17:906:73dd:b0:99b:d594:8f89 with SMTP id n29-20020a17090673dd00b0099bd5948f89mr11222401ejl.0.1691029434392; Wed, 02 Aug 2023 19:23:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691029434; cv=none; d=google.com; s=arc-20160816; b=r798weHG8ipWmAGKYQfgd3BXsGTHUve0YcLFEYf9iZBTUdBapjwkK+XjYgc5GVle64 qBnbv19KgHUFk/KLlDuG+rPvnuPsCEUSmwAxuHQleRbxJuSsNnjtXwor5/SdvmR9mXHO o7GjglAWbdbIMonzMj4SB3TkyqTdbvLtXqtOJkFo2aNXfXV65EYq7gzbzDXnrmeO/B1j Z5hyX3o+d9+cl7xSRMj5HYp32TZM1BBWWZU2lUEvFUTpdHqBboMMwLF837Ag6cMF2z4x v3OFQuE83V198w+KXitsG0lWPcFbJnhFvqjvoOMo1iK9kXUMVjBWiga/ijdWCW8BtEUZ XA+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mI9VqnGKPrgOQCIVIWrhqTrh/dYptfa0Js+lHVE0BII=; fh=zpCCF/J8Z0sUUNZfCNdnaRvm94yhXPVxl9PzV22VU6k=; b=dcXqeYK6GD/UR2NlSEn1DIo6uwGXfQVtd4rZvK3PQUJ5cggmbbPkLkr+Nsx4sezdXt tF9YBOWa/78A1UpLjgYtwbJWaaWHFVzFbB4qO21y+mKnKQPPKGz2GYmstaWdD5dLinXF 2g7fEMY55e2PpFKERVp2djIzyx1F17EzwFFUIS470Gqoyq+22neJgeJiRfs082ssgAnA 2PdofTU4l10oqz2v9U10pcm5LeVfZJRi3YBLWoLZDPeD9934RtZaDL/fvyyo3rM7un/p MgZxO1U43xICwOqk9JwkykH4z0e2CEqmZAN+I5+zq5ezQZ+dOEcnIyiSj/gfph408HLd kBrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lo8-20020a170906fa0800b0099bd5561245si1262427ejb.54.2023.08.02.19.23.30; Wed, 02 Aug 2023 19:23:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232768AbjHCBtK (ORCPT + 99 others); Wed, 2 Aug 2023 21:49:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230504AbjHCBs6 (ORCPT ); Wed, 2 Aug 2023 21:48:58 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E71230E9 for ; Wed, 2 Aug 2023 18:48:48 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.169]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RGWwD4nbgz4f3mJ1 for ; Thu, 3 Aug 2023 09:48:44 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP3 (Coremail) with SMTP id _Ch0CgCXQiB7B8tkVa5vOQ--.12634S3; Thu, 03 Aug 2023 09:48:45 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH v2 1/4] mm/compaction: set compact_cached_free_pfn correctly in update_pageblock_skip Date: Thu, 3 Aug 2023 17:48:58 +0800 Message-Id: <20230803094901.2915942-2-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230803094901.2915942-1-shikemeng@huaweicloud.com> References: <20230803094901.2915942-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: _Ch0CgCXQiB7B8tkVa5vOQ--.12634S3 X-Coremail-Antispam: 1UD129KBjvdXoW7Jw1kCr17WFW3KFW7KF15urg_yoWfZrX_G3 WIyFnxK34avrZ3Z3ZrAw4Skr1xKrWrCF1DWw1Yqry7Z3yqvF4kZa9rJwsxXrnIqFyDurnx Gw1kuF1vkF4agjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb6AFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUGwA2048vs2IY020Ec7CjxVAFwI0_JFI_Gr1l8cAvFVAK0II2c7xJM28C jxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI 8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E 87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64 kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm 72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYx C7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_ Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x 0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8 JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIx AIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sREgyCDUUUUU= = X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773172880224210578 X-GMAIL-MSGID: 1773172880224210578 We will set skip to page block of block_start_pfn, it's more reasonable to set compact_cached_free_pfn to page block before the block_start_pfn. Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang --- mm/compaction.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index fbf50a9e4d23..61f56cee3715 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1714,7 +1714,8 @@ static void isolate_freepages(struct compact_control *cc) /* Update the skip hint if the full pageblock was scanned */ if (isolate_start_pfn == block_end_pfn) - update_pageblock_skip(cc, page, block_start_pfn); + update_pageblock_skip(cc, page, block_start_pfn - + pageblock_nr_pages); /* Are enough freepages isolated? */ if (cc->nr_freepages >= cc->nr_migratepages) {