Message ID | 20230803080659.99071-1-jiapeng.chong@linux.alibaba.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp999721vqx; Thu, 3 Aug 2023 01:38:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlFE4L/m4EI5TGh6/6KAIdNE+21uqcQdbSof3RK3WQYCyxgI3rXjcFId7m0cFZeht3LoycZJ X-Received: by 2002:a17:902:e744:b0:1bc:1df2:4c07 with SMTP id p4-20020a170902e74400b001bc1df24c07mr7654110plf.63.1691051896288; Thu, 03 Aug 2023 01:38:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691051896; cv=none; d=google.com; s=arc-20160816; b=aVR/8f89lTCF4BYWwU/6wVC+XwoGoB7mNUMW2A8dAk1KSm7Pcr+wOzgwRu/0A8nzG2 L6gnOMJCdAPS7PTP4x48FP/kw4atuhUF0/L40s4waepN9a45LjWF2Dn9yeWZRk3JCXWa shb6tmm4lOgFxAhJxfRMMtgfFFAKwK/8xNEAgBTIjMyCvPgR9cG7fhg/5raq81AnzPKT s7lj5V4ByQw4Zm7jrb8d73I+smB3jAA7AOOrWhsWsPSEtoAR9DmBPRsREWmGmFh4ykcW tv/4kKAJmq4Z744yS22HhdTi7AepA1LqhpES4kZPL3tgUrLsgKXg5ncaEUjlVFmH+RbC 7cZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=de4uwY0bXMfsMA67aT3xXadL51X3zW9hV2bjK5AVmTU=; fh=mTzRPhC1NUrzirQv1Y9QBraPjsglRD/yhyGbKO4vrCw=; b=kydku4CgDTJ7tmQB+03kAJ572nuISp87GbiC2QOj82ge2QTc1WaDNjTfX2MTacP1+u 9HZEOzRYuOwXg0hmPuc0c/wEWpkCmz1MVHc0/bzTy9iLnOy0JkXXjwHwgW6eOdmovNyn 9Zot0SytDqNN+x9HO22QtZOcgs0bEMydgmgFGqbjnB0yxYOjRPuYGlQdVtcY5bG1xmNt EbG5iFS+0tfNnUPfS1LXkDSJddaTzo+q+7/yIL3JZsxDcqMtN42OAcQwxu+6SaE9g2yD B827iUCE0fD7086b6e4HRh8P6FVRNE9rM3Gf1qquI0v5l4j3hfaG33aK0gIeHupD2ePW nYcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id iw5-20020a170903044500b001b8aa6b6acesi11863408plb.387.2023.08.03.01.38.02; Thu, 03 Aug 2023 01:38:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234408AbjHCIPk (ORCPT <rfc822;jeff.pang.chn@gmail.com> + 99 others); Thu, 3 Aug 2023 04:15:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231343AbjHCIPD (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 3 Aug 2023 04:15:03 -0400 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EDF559FC for <linux-kernel@vger.kernel.org>; Thu, 3 Aug 2023 01:07:13 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0Voy-X9g_1691050020; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0Voy-X9g_1691050020) by smtp.aliyun-inc.com; Thu, 03 Aug 2023 16:07:09 +0800 From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> To: paulmck@kernel.org Cc: frederic@kernel.org, quic_neeraju@quicinc.com, joel@joelfernandes.org, josh@joshtriplett.org, boqun.feng@gmail.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, qiang.zhang1211@gmail.com, linux-kernel@vger.kernel.org, Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, Abaci Robot <abaci@linux.alibaba.com> Subject: [PATCH] rcu-tasks: make rcu_tasks_lazy_ms static Date: Thu, 3 Aug 2023 16:06:59 +0800 Message-Id: <20230803080659.99071-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773196433233552269 X-GMAIL-MSGID: 1773196433233552269 |
Series |
rcu-tasks: make rcu_tasks_lazy_ms static
|
|
Commit Message
Jiapeng Chong
Aug. 3, 2023, 8:06 a.m. UTC
The rcu_tasks_lazy_ms are not used outside the file tasks.h, so the
modification is defined as static.
kernel/rcu/tasks.h:1085:5: warning: symbol 'rcu_tasks_lazy_ms' was not declared. Should it be static?
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6086
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
kernel/rcu/tasks.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, Aug 3, 2023 at 4:07 AM Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > > The rcu_tasks_lazy_ms are not used outside the file tasks.h, so the > modification is defined as static. > > kernel/rcu/tasks.h:1085:5: warning: symbol 'rcu_tasks_lazy_ms' was not declared. Should it be static? > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6086 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org> - Joel > --- > kernel/rcu/tasks.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h > index 83049a893de5..ee1379671798 100644 > --- a/kernel/rcu/tasks.h > +++ b/kernel/rcu/tasks.h > @@ -1084,7 +1084,7 @@ void rcu_barrier_tasks(void) > } > EXPORT_SYMBOL_GPL(rcu_barrier_tasks); > > -int rcu_tasks_lazy_ms = -1; > +static int rcu_tasks_lazy_ms = -1; > module_param(rcu_tasks_lazy_ms, int, 0444); > > static int __init rcu_spawn_tasks_kthread(void) > -- > 2.20.1.7.g153144c >
On Thu, Aug 03, 2023 at 12:11:41PM -0400, Joel Fernandes wrote: > On Thu, Aug 3, 2023 at 4:07 AM Jiapeng Chong > <jiapeng.chong@linux.alibaba.com> wrote: > > > > The rcu_tasks_lazy_ms are not used outside the file tasks.h, so the > > modification is defined as static. > > > > kernel/rcu/tasks.h:1085:5: warning: symbol 'rcu_tasks_lazy_ms' was not declared. Should it be static? > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6086 > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org> Queued, thank you both! Thanx, Paul > - Joel > > > > --- > > kernel/rcu/tasks.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h > > index 83049a893de5..ee1379671798 100644 > > --- a/kernel/rcu/tasks.h > > +++ b/kernel/rcu/tasks.h > > @@ -1084,7 +1084,7 @@ void rcu_barrier_tasks(void) > > } > > EXPORT_SYMBOL_GPL(rcu_barrier_tasks); > > > > -int rcu_tasks_lazy_ms = -1; > > +static int rcu_tasks_lazy_ms = -1; > > module_param(rcu_tasks_lazy_ms, int, 0444); > > > > static int __init rcu_spawn_tasks_kthread(void) > > -- > > 2.20.1.7.g153144c > >
diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index 83049a893de5..ee1379671798 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -1084,7 +1084,7 @@ void rcu_barrier_tasks(void) } EXPORT_SYMBOL_GPL(rcu_barrier_tasks); -int rcu_tasks_lazy_ms = -1; +static int rcu_tasks_lazy_ms = -1; module_param(rcu_tasks_lazy_ms, int, 0444); static int __init rcu_spawn_tasks_kthread(void)