Message ID | 20230803074249.3065586-10-wenst@chromium.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1007205vqx; Thu, 3 Aug 2023 01:59:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlFfP8zGhRVRGmZEamWOvmw9a1fId7wgZ/W9gByO4hU4RiXS2T8lFdN5FvOe/RRZJw3JnY3I X-Received: by 2002:a17:906:24f:b0:96f:1f79:c0a6 with SMTP id 15-20020a170906024f00b0096f1f79c0a6mr7750360ejl.70.1691053163583; Thu, 03 Aug 2023 01:59:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691053163; cv=none; d=google.com; s=arc-20160816; b=JdTYTYTc2xdVC8K7BzOgDCt7Oh5p/0/q1fdLv+T5zGfUYMbONz0aUu0NNNO7IrbSzc kLcDjF+uwKropFYYit9ZIoGrqDhQ0QTwyo1uQiIDETlIU/P4j8db4ATm7zN3wlIUiUIS pi3QnWxh32IiI0R4Zjg8n1QLGWaPwx3KbrsupGwt5rJPauI0hqd5cfYrxfu++X/NvmxO X7S3kuYzTtn5SdfHk4zXsOU6CEQVj98Dw0zTK1kW7gDqxjkJgakj9w5DvVZTgRae8kK8 ofXIkPsdO0fa0esCfC3Cbe2rCJ7aNt2BuTSc2h1L5J9aObNCP2VFG5ZW4uS81PbScfNp MYGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vrPeOXoKc2hUZA03cIawOYELY2pxQM3mW6RdAg6oP4Q=; fh=8pjLFPk71yS0kQjQH42IjMGHfWvSFXlQQFuq588a4+Q=; b=jF+An+X4gNquK+areOzXbWdDXtRkSzFNkbkpxSKkCtnDl2lBErjvZQ5ypWb6chI0eW zSdGp4YShKzQg3nz8rZY3yMR22w/Y1V3k+WKxJ83SXWi+Nj6kiTWBgUFQtRpwf6ALkH/ 2x/nn+JVikpihoqf0Vds2QW5T55BtfVmIViyPpMIpi4Pn6xClW0KixqS9qwTrSox2UrS bFEtLJDj6AYrJstgpSt4J69sEauGHbgcWAoHo7uJI2DIb2D4XQDe7xpAn37mhjcTmbVF fd1f5ECvYy8LuoasNpW/SQ/uJpHXbjcw0Y1SZNpbamSyp6KSYSrxI6lK39bsPwjsQPlb ORlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=B64w8cCq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gz22-20020a170906f2d600b00997c44fb391si8043779ejb.401.2023.08.03.01.59.00; Thu, 03 Aug 2023 01:59:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=B64w8cCq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234129AbjHCHz2 (ORCPT <rfc822;jeff.pang.chn@gmail.com> + 99 others); Thu, 3 Aug 2023 03:55:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbjHCHyI (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 3 Aug 2023 03:54:08 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB2058A7D for <linux-kernel@vger.kernel.org>; Thu, 3 Aug 2023 00:43:42 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-563f8e8a53dso322783a12.3 for <linux-kernel@vger.kernel.org>; Thu, 03 Aug 2023 00:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1691048600; x=1691653400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vrPeOXoKc2hUZA03cIawOYELY2pxQM3mW6RdAg6oP4Q=; b=B64w8cCq99lVMCbkJggf/D7Dt6lLV5K5zg7oC1ThIFLNH3t5f1k3gSs8+jSLNo/ka8 7PcdgmMrzsxU8npBb4uQYX9e7OPVdfd6aJDYBa6wJ8Z1u0I3jU5/6hkQVS71dHVk4JrU iDZQJbm63agTlZLMmk5l7hGyemkE7pqJogmMY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691048600; x=1691653400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vrPeOXoKc2hUZA03cIawOYELY2pxQM3mW6RdAg6oP4Q=; b=FH/2xER6hodDxtv3OrYCqKDm0VbwKBjy1hqMQBjurgmx7iP75jgajfKR1FXVw/rCT6 y+VaJt+2+vpUIMMVddrZXy01eGJuDyZL3SjIVEbwEBnnKAyDKHbOtzc+0KYOvAkxy6hK IwS4QTKlpKU6rmwKHa4WJaWAAratzUCXHzP8breqTWsajNXj43DOj3apOnjOptCOX4mt 3Q0WY1ut4YgXj9n205L2Jb198kmpeGok/WhjDlkOTytyIMLhFrWmOiNKhk4sUzgd9YFE HbDZUuRvOVoC5lk4NPndQ87RPkHlANdOz1ckCLnWR1WwsiLNij2PMqbShpP+PlilS1TN OUwA== X-Gm-Message-State: ABy/qLa4u7iFAG0lLN6T9T78bRajLvE8W4C8cI4PFSQRn2lXmvSwIWod rl3YmGrHvLWdwUN0HMNwDkftww== X-Received: by 2002:a17:90a:d78d:b0:268:1f64:cefc with SMTP id z13-20020a17090ad78d00b002681f64cefcmr13321482pju.49.1691048600567; Thu, 03 Aug 2023 00:43:20 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:6f3e:66ee:db46:473b]) by smtp.gmail.com with ESMTPSA id l11-20020a17090a72cb00b00262d079720bsm2095753pjk.29.2023.08.03.00.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 00:43:20 -0700 (PDT) From: Chen-Yu Tsai <wenst@chromium.org> To: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Mark Brown <broonie@kernel.org> Cc: Chen-Yu Tsai <wenst@chromium.org>, Zhiyong Tao <zhiyong.tao@mediatek.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH 9/9] soc: mediatek: pwrap: add support for MT6366 PMIC Date: Thu, 3 Aug 2023 15:42:47 +0800 Message-ID: <20230803074249.3065586-10-wenst@chromium.org> X-Mailer: git-send-email 2.41.0.585.gd2178a4bd4-goog In-Reply-To: <20230803074249.3065586-1-wenst@chromium.org> References: <20230803074249.3065586-1-wenst@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773197762017332005 X-GMAIL-MSGID: 1773197762017332005 |
Series |
regulator: mt6366: Split out of MT6358 and cleanup
|
|
Commit Message
Chen-Yu Tsai
Aug. 3, 2023, 7:42 a.m. UTC
The MT6366 PMIC is mostly, but not fully, compatible with MT6358. It has
a different set of regulators. Specifically, it lacks the camera related
VCAM* LDOs, but has additional VM18, VMDDR, and VSRAM_CORE LDOs.
Add a separate compatible for the MT6366 PMIC.
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 2 ++
1 file changed, 2 insertions(+)
Comments
Il 03/08/23 09:42, Chen-Yu Tsai ha scritto: > The MT6366 PMIC is mostly, but not fully, compatible with MT6358. It has > a different set of regulators. Specifically, it lacks the camera related > VCAM* LDOs, but has additional VM18, VMDDR, and VSRAM_CORE LDOs. > > Add a separate compatible for the MT6366 PMIC. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> We can express the same partial-compatibility state with bindings, adding a new compatible here with the same platform data doesn't really add any value... ...also because in DT we'll have something like compatible = "mediatek,mt6366", "mediatek,mt6358"; so if any variation of platform data in mtk-pmic-wrap will ever be needed, we would still be able to do that in the future without any headache. In my opinion, this commit can be dropped. P.S.: We could add a comment in the mt6366.dtsi pmic devicetree for that, too? Cheers, Angelo > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index 11095b8de71a..e3c0e767033b 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -2257,6 +2257,8 @@ static const struct of_device_id of_slave_match_tbl[] = { > { .compatible = "mediatek,mt6357", .data = &pmic_mt6357 }, > { .compatible = "mediatek,mt6358", .data = &pmic_mt6358 }, > { .compatible = "mediatek,mt6359", .data = &pmic_mt6359 }, > + /* MT6366 is mostly compatible with MT6358, except for slightly different regulators. */ > + { .compatible = "mediatek,mt6366", .data = &pmic_mt6358 }, > > /* The MT6380 PMIC only implements a regulator, so we bind it > * directly instead of using a MFD.
On Thu, Aug 3, 2023 at 5:01 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 03/08/23 09:42, Chen-Yu Tsai ha scritto: > > The MT6366 PMIC is mostly, but not fully, compatible with MT6358. It has > > a different set of regulators. Specifically, it lacks the camera related > > VCAM* LDOs, but has additional VM18, VMDDR, and VSRAM_CORE LDOs. > > > > Add a separate compatible for the MT6366 PMIC. > > > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > > We can express the same partial-compatibility state with bindings, adding a > new compatible here with the same platform data doesn't really add any value... > > ...also because in DT we'll have something like > compatible = "mediatek,mt6366", "mediatek,mt6358"; > > so if any variation of platform data in mtk-pmic-wrap will ever be needed, we > would still be able to do that in the future without any headache. > > In my opinion, this commit can be dropped. As mentioned in my reply to the mfd patch, this might not be doable. There are limitations on both the DT bindings and mfd driver sides. ChenYu > P.S.: We could add a comment in the mt6366.dtsi pmic devicetree for that, too? > > Cheers, > Angelo > > > --- > > drivers/soc/mediatek/mtk-pmic-wrap.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > > index 11095b8de71a..e3c0e767033b 100644 > > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > > @@ -2257,6 +2257,8 @@ static const struct of_device_id of_slave_match_tbl[] = { > > { .compatible = "mediatek,mt6357", .data = &pmic_mt6357 }, > > { .compatible = "mediatek,mt6358", .data = &pmic_mt6358 }, > > { .compatible = "mediatek,mt6359", .data = &pmic_mt6359 }, > > + /* MT6366 is mostly compatible with MT6358, except for slightly different regulators. */ > > + { .compatible = "mediatek,mt6366", .data = &pmic_mt6358 }, > > > > /* The MT6380 PMIC only implements a regulator, so we bind it > > * directly instead of using a MFD. > >
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c index 11095b8de71a..e3c0e767033b 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -2257,6 +2257,8 @@ static const struct of_device_id of_slave_match_tbl[] = { { .compatible = "mediatek,mt6357", .data = &pmic_mt6357 }, { .compatible = "mediatek,mt6358", .data = &pmic_mt6358 }, { .compatible = "mediatek,mt6359", .data = &pmic_mt6359 }, + /* MT6366 is mostly compatible with MT6358, except for slightly different regulators. */ + { .compatible = "mediatek,mt6366", .data = &pmic_mt6358 }, /* The MT6380 PMIC only implements a regulator, so we bind it * directly instead of using a MFD.