| Message ID | 20230803-ub9xx-uninit-vars-v2-3-512570ecb798@ideasonboard.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1128145vqx;
Thu, 3 Aug 2023 05:59:42 -0700 (PDT)
X-Google-Smtp-Source:
APBJJlFtEU5GIc1dz5e2iCpSKcir7dmeTqRLN5VXecGQxqL3ujMFVjy6zB9hOPKRY0usq17eAF+c
X-Received: by 2002:a17:907:97d5:b0:992:13c7:560 with SMTP id
js21-20020a17090797d500b0099213c70560mr9233283ejc.38.1691067581726;
Thu, 03 Aug 2023 05:59:41 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1691067581; cv=none;
d=google.com; s=arc-20160816;
b=q64/0ptrFp2+C/rO6KBIdtXH8tSdLMvwWmNfhZbPADWhMMH/8vYFMeGISGIReOlHLJ
U8q8rijdI7yf2lJ6poWNoyS4T4Lmqfyveqg9BrMgsqF/h6Oe723YuwAVlSsTKVy0Sqn4
eeSvgjiateGhFGmidxDZJNEOvWnFyBfejHkxLGaVJCthqR/Z2TJSer6l7jF5x7SGunbe
oMHEhU/sOJXcFN5otnhhy17s8Woqd9OVpuidwCRWqORrmRaTLtBG033O7nZmcM+ru7Oy
XaYbbYtVV/0QqrQJkFO+YHwA1LKjgiB4pjK5+J/lk2MncaNjSixD38rDGutvl/ivtUmc
eH0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:cc:to:in-reply-to:references:message-id
:content-transfer-encoding:mime-version:subject:date:from
:dkim-signature;
bh=3JHocNfFIvImhguOggnzRsvrPhHlenPNGYaxVMeN9Po=;
fh=OqXResVBGmKVif32WrPB9+w/XjWhGxZKnootS83aEBI=;
b=Nc+d/n3WUbQHshQ+xzSVCvSyT9s9corYnH2lkxYa5ebBmfA7VwtiklQJbW52WQxA3k
MF3KWb2pgpYqtzqK6o+VZ5t9uZqfJiZbvvLQe7/UsFcFe5PMe5SIjbl9Vf8A8zlhnxmv
u3TLdJPR/4YFntAqmkSnToB+30sVDbO2SHI/I6NXKY0blaxOI5+AFuXERTTGO5gH3BOH
Yh8N43uaqn33W5RcRGIefwBSf/Oiw3K4wOu80tiXXNZqPjton2lLBGmBgVyj8Og4kE1P
BUOOH6HZpKvfbkjoZARKfUIq49IwRHCXHKYhDoTnNJbLVrnfOqdZGt5+N4e6tvVH8FbC
0Uww==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail
header.b=pDakRJGS;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
a24-20020a170906245800b0099367350a83si11549268ejb.898.2023.08.03.05.59.17;
Thu, 03 Aug 2023 05:59:41 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail
header.b=pDakRJGS;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S235868AbjHCMQb (ORCPT <rfc822;jeff.pang.chn@gmail.com>
+ 99 others); Thu, 3 Aug 2023 08:16:31 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34934 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S235863AbjHCMQ1 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 3 Aug 2023 08:16:27 -0400
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2CF5B1;
Thu, 3 Aug 2023 05:16:25 -0700 (PDT)
Received: from [127.0.1.1] (91-154-35-171.elisa-laajakaista.fi
[91.154.35.171])
by perceval.ideasonboard.com (Postfix) with ESMTPSA id 06090EEA;
Thu, 3 Aug 2023 14:15:17 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;
s=mail; t=1691064918;
bh=X/zAB0Jj0qtm9fUujGG3j4YnlOSerudhleIY+ZFE7Pk=;
h=From:Date:Subject:References:In-Reply-To:To:Cc:From;
b=pDakRJGS/sF3EpPJcPIuJYXGMRiWHbk47Puxtkb+cID4P0jbPwXt+fCWVbVM99tDd
zrcb22Zcbs+nG8/mXPTqdZIksgQswYnA1o6yP3mB2EYFcvqsL7tNF5bIt30Dyu2T3O
afAsozyQqTDxm5oQniH+C0rxCdRjOLlES7PuwntM=
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Date: Thu, 03 Aug 2023 15:15:47 +0300
Subject: [PATCH v2 3/3] media: i2c: ds90ub960: Fix PLL config for 1200 MHz
CSI rate
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20230803-ub9xx-uninit-vars-v2-3-512570ecb798@ideasonboard.com>
References: <20230803-ub9xx-uninit-vars-v2-0-512570ecb798@ideasonboard.com>
In-Reply-To: <20230803-ub9xx-uninit-vars-v2-0-512570ecb798@ideasonboard.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
X-Mailer: b4 0.12.3
X-Developer-Signature: v=1; a=openpgp-sha256; l=958;
i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id;
bh=X/zAB0Jj0qtm9fUujGG3j4YnlOSerudhleIY+ZFE7Pk=;
b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBky5qTlwogM7bSwQkRLy7uH14HFuTygXBUZ/UFm
RoihrGzwX+JAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZMuakwAKCRD6PaqMvJYe
9WjID/sEMMwT0p0hDZLH8aL8mh3obRi+owyf43NC174eD0THUq+pyJoTCff0+maEGVri/JvL+EA
V3NfvuysUJnQ9hbw/iNVqrEAcoRH9nbfePhp919njbqbYOEb5hTN3BdrFPpWvuOsxBdM6e/ub3J
o/kSPmhgBAv7aS+CnxUHq3gkVBgVXrVasIhrq7VugEBbmZosK1iAvkaRixzSVbjsvqkA0lI8+yD
BHGasMrR/bZtrk5OEvmNzNPOeNluC4HQxx3bCdKjqZUnYsXb9bZLrP7+C4xmuh+C4kw5Ia3qo2s
Dm6MBemKuiDkOCj5bD7yPkKowOQP2eFWjYZfMMb0fFwIk8sVgFh3YKPNWHOvztH97vHjafH721o
j5N8b1KW84wyOqTn0LxxueJOlJVIyWsdhkBS+UrMb6D+igCesY0R1CYR6wqI8AaJDuBL/DZHPe8
54X+JVz3D8Vxp0ccGUArl+pHIH/7jbZjET9TOK/2Cd50PGzNNhJ1IvHhzpgh4RQUEoxer8fDxI8
UGhfZQWAU15ryf/qsRFCfqXSj7RV+1TjyEw3DGmZeIcOwLzcPqDxjRNsvq6TAVfSh7i5t0xPh4W
Rhsef5JJjz1NyJ8z4IUWXs/qfaJzCuDEPq4ryeN9Rwwxy8UbImfWQKpQhGxMj2vyoLJGU9XkY+Z
6ujGJUociowXRIw==
X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp;
fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1773212880361207678
X-GMAIL-MSGID: 1773212880361207678
|
| Series |
media: i2c: ds90ubxxx: Fix uninitialized variable uses
|
|
Commit Message
Tomi Valkeinen
Aug. 3, 2023, 12:15 p.m. UTC
smatch reports:
drivers/media/i2c/ds90ub960.c:1788 ub960_init_tx_ports() error: uninitialized symbol 'pll_div'.
This is caused by 'pll_div' not being set for 1200 MHz CSI rate. Set the
'pll_div' correctly.
Fixes: afe267f2d368 ("media: i2c: add DS90UB960 driver")
Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Closes: https://lore.kernel.org/all/8d6daeb1-b62a-bbb2-b840-8759c84f2085@xs4all.nl/
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/media/i2c/ds90ub960.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Thu, Aug 03, 2023 at 03:15:47PM +0300, Tomi Valkeinen wrote: > smatch reports: > > drivers/media/i2c/ds90ub960.c:1788 ub960_init_tx_ports() error: uninitialized symbol 'pll_div'. > > This is caused by 'pll_div' not being set for 1200 MHz CSI rate. Set the > 'pll_div' correctly. > > Fixes: afe267f2d368 ("media: i2c: add DS90UB960 driver") > Reported-by: Hans Verkuil <hverkuil@xs4all.nl> > Closes: https://lore.kernel.org/all/8d6daeb1-b62a-bbb2-b840-8759c84f2085@xs4all.nl/ > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> My Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> from v1, send before I noticed v2 was on the list, still applies. > --- > drivers/media/i2c/ds90ub960.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c > index 4833b39b9178..4ab45e326d80 100644 > --- a/drivers/media/i2c/ds90ub960.c > +++ b/drivers/media/i2c/ds90ub960.c > @@ -1763,6 +1763,7 @@ static int ub960_init_tx_ports(struct ub960_data *priv) > break; > case MHZ(1200): > speed_select = 1; > + pll_div = 0x18; > break; > case MHZ(800): > speed_select = 2; >
diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c index 4833b39b9178..4ab45e326d80 100644 --- a/drivers/media/i2c/ds90ub960.c +++ b/drivers/media/i2c/ds90ub960.c @@ -1763,6 +1763,7 @@ static int ub960_init_tx_ports(struct ub960_data *priv) break; case MHZ(1200): speed_select = 1; + pll_div = 0x18; break; case MHZ(800): speed_select = 2;