Message ID | 20230803-ub9xx-uninit-vars-v2-1-512570ecb798@ideasonboard.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1125805vqx; Thu, 3 Aug 2023 05:54:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlGKLN7RiXLYwPGCrY77hzvZvDRbljvtuLlZahdr43vElpUuaFp9td1KMs8zIOOuFbMuSACn X-Received: by 2002:a05:6a20:9703:b0:13c:8e50:34b8 with SMTP id hr3-20020a056a20970300b0013c8e5034b8mr15240193pzc.35.1691067252791; Thu, 03 Aug 2023 05:54:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691067252; cv=none; d=google.com; s=arc-20160816; b=T2OWfk/OnJFlAgs6lrOLZuWJWpmPaJABz9kqNZ3avazImuOlcIFUA3Mw29CfbLrrZc pfW27IijuaBaXn6164FwfoSB+a8/nh38WUeE/7MfLCWCsdDTCUwIGSv9gLg9DL1Irjea HbZPCHdyhJou8K1OD90iV/X1LwbwDcYqkiYbz3MsbX+UCxQCab0KmamY0F15v42vYZNx SmzuZq02UqoYLjm0eo3ZmWvWI6G6Hpj022/V6Y+EMtydy7iUnJ5LJQK/R3lWSu5LlE7T r5R5Ytmlqx5v4+7b2AB+tOk5fhHVlWKYFJNzgjU41g6in4yPXWB9NPisn1z5MhcKugxs UetA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=uIOwGuGNjEIoP5lX3GH0e6pWBa+FHU8edsRuWoqcE/w=; fh=OqXResVBGmKVif32WrPB9+w/XjWhGxZKnootS83aEBI=; b=XQTYvDk5UfwOIeTjGcOe1rMsWCBLtq+xC+NfaSJ019pmXKZHqyjgzIK+v8iNYOChXO 5Wqiut5wHeXs9xf/PpYxP5Sz94jbrbUH6f7PZnTLYAciDYLteY/NSRmKXDcldOZiNH/Z Ma2VNM8dN3fg8RpajQqbtgrH4yDjOPHRHdmSc7sHPMRY086QvVRoT1xVtFrqVvtAM+dj h8sjAOCoeqtvFxw/KN+CFz4FTC3Z/Q24T6CKJyrzVhOAy4L549iUZNDFXGYTS/1wYHkx ZWv30fX/Loxj9IhGDnWIYtlDTt3HgwWHhlRCV+Ac6L1dXG67xxueUg2fpKuxidadLKzp PzxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=kHNnALG8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c8-20020a056a00248800b00652c20d3522si7198954pfv.303.2023.08.03.05.53.59; Thu, 03 Aug 2023 05:54:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=kHNnALG8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235866AbjHCMQ2 (ORCPT <rfc822;jeff.pang.chn@gmail.com> + 99 others); Thu, 3 Aug 2023 08:16:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235354AbjHCMQZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 3 Aug 2023 08:16:25 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1511C1716; Thu, 3 Aug 2023 05:16:23 -0700 (PDT) Received: from [127.0.1.1] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 996E7C67; Thu, 3 Aug 2023 14:15:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1691064917; bh=FUF1g+cBUsdEqKfbNzez2Hokd0GxCCbEB2o0a2KNDys=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=kHNnALG85T2UZ9jsxoPBGsCRJi8ddcr/Id9vLH7RjLzbukpEAryOpBqYfR6YF9fXO Undu76W6QJLqayq/vpNOAMFhF78Nep7yb9+U/CLZuWW5tCk0ODZbbIQffsicwZenem pHncreFTgP9wIKUIe5cJC/3yDlK7Qu6HiJUS+W1U= From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Date: Thu, 03 Aug 2023 15:15:45 +0300 Subject: [PATCH v2 1/3] media: i2c: ds90ub913: Fix use of uninitialized variables MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230803-ub9xx-uninit-vars-v2-1-512570ecb798@ideasonboard.com> References: <20230803-ub9xx-uninit-vars-v2-0-512570ecb798@ideasonboard.com> In-Reply-To: <20230803-ub9xx-uninit-vars-v2-0-512570ecb798@ideasonboard.com> To: Mauro Carvalho Chehab <mchehab@kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Hans Verkuil <hverkuil@xs4all.nl> Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1323; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=FUF1g+cBUsdEqKfbNzez2Hokd0GxCCbEB2o0a2KNDys=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBky5qSirgPH9zPThBDC93DQo5bx72emrcDGxbpv ac30JTkfx+JAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZMuakgAKCRD6PaqMvJYe 9RopEACtjE3K40xcWVdMWnD6/aLAj3cGmLF6yGhjC6N2i/GcuHm1WFBIT4zM76hgJdHt0eL/GF7 0hGtPuKBgB11Q9nP5/H0VGZwZE7Q9d+lBOsYPogkQhhz/AUFBoBXrvJ0+Sc0XZH76pR8hHF/3QS nF5fOVIs86jL5vPzbrSgpqBEEm/abJTJNX4RHv/0aZbWsNZSLIiIqWIEWzEUkwlOOSC97pd2wSh JKXgnCwaeGpbcsFn26Vx5NTS3tSV2GA7XrnK7u/cUZNjp1LBtZfGGcyxAmT9OfLlHv4wXghRuVA hmHRRxe9nU94njr+L08gjP2c47k0YjZevaJPBqUGjp3ZS4mm6Pc9kLe5DR2fjiht2SyDofK8Elm TerHWe/07ft2/eAg0swQ7C3cRVnX/jr10w5K5wGGrfVQwVI6yhSo3abgIt76cKbA/ThKlv9pIgB aS0E5XIlVXfL+lFhwcfjvS7qitY5TuBVTNWuoMMGgkz9AEyo6mIeH698fa76RLz42ak6HUBgd3L 5nz4FurbhtbB7lYzAJrbPGr7VW8PYE4x89aeBogxLq65YGsM2CpY4UdyUf5bpw9yEkpN5pbrsdq ffZkeGnOzw/XY0J4H1Qxc7UtGOmPoB7sB/7NopIkmcUp6QQS1qencSSyMPzy8X7xz3FsnMWr3iU y7BgeQ0Ihbqkq9g== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773212535802079689 X-GMAIL-MSGID: 1773212535802079689 |
Series |
media: i2c: ds90ubxxx: Fix uninitialized variable uses
|
|
Commit Message
Tomi Valkeinen
Aug. 3, 2023, 12:15 p.m. UTC
smatch reports some uninitialized variables:
drivers/media/i2c/ds90ub913.c:481 ub913_log_status() error: uninitialized symbol 'v1'.
drivers/media/i2c/ds90ub913.c:481 ub913_log_status() error: uninitialized symbol 'v2'.
These are used only for printing debug information, and the use of an
uninitialized variable only happens if an i2c transaction has failed,
which will print an error. Thus, fix the errors just by initializing the
variables to 0.
Fixes: c158d0d4ff15 ("media: i2c: add DS90UB913 driver")
Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Closes: https://lore.kernel.org/all/8d6daeb1-b62a-bbb2-b840-8759c84f2085@xs4all.nl/
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/media/i2c/ds90ub913.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c index 80d9cf6dd945..b2115e3519e2 100644 --- a/drivers/media/i2c/ds90ub913.c +++ b/drivers/media/i2c/ds90ub913.c @@ -469,7 +469,7 @@ static int ub913_log_status(struct v4l2_subdev *sd) { struct ub913_data *priv = sd_to_ub913(sd); struct device *dev = &priv->client->dev; - u8 v = 0, v1, v2; + u8 v = 0, v1 = 0, v2 = 0; ub913_read(priv, UB913_REG_MODE_SEL, &v); dev_info(dev, "MODE_SEL %#02x\n", v);