From patchwork Wed Aug 2 23:46:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 130221 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp806190vqx; Wed, 2 Aug 2023 17:05:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlGH8OL3Awdqg+d+pJ0XQklxCXAlUMi6MbG1GX9MoicqSOjx1QuqAvqtULK1B8yWEP1oKFYF X-Received: by 2002:a05:6402:2708:b0:521:f2a7:d57a with SMTP id y8-20020a056402270800b00521f2a7d57amr11402631edd.2.1691021148438; Wed, 02 Aug 2023 17:05:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691021148; cv=none; d=google.com; s=arc-20160816; b=Apd5aXXZovue6OlOhDwENuiF21EmylCqbO0HNksNi5udpYFUJaiVNAm0+6JFnaZ5Ao lQ9l+vulfOu6KMDO28RLKi9cr7EhVxXFPUdjP7LWZQ1Ft4CulX2zKt6o770mVPN7LnNS z25v7ZShcOoah/lEklsvrOEKWOOmfmmXg+Xi53VNQmHzn5HfytC3aBjGV85g+CPFy2k9 tBI4cdxkJmVNbmFF21HCQi7gFKVGh6RVdMRAe2zIWxIHLkzkq7dRcKsWOkXWaQrmH+2N 3i0qCozfkpN//MoVjwtUDX4/6BvZGoGK1db3UqNIjz0/Obj6ISxVU+SfnLjnNAVzsso6 XxWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=HOOtowhjC+WPlhacEz3hVuNXVARU431ZlDvHPZ9unu4=; fh=EtJv80ycOlibMVbz47kfFZiy1kxQBCIu8DFa34yN8O4=; b=kKT/LIQXOmZODYFKKPPgRi+0qeyd0eWW+hZrgHdPg5EbnmLvNdVSUWnSoziq2TPIhS TuDtzR1wyucOsNHm8KrCPth2yx/fm6wszk1uv6il/WLVftVWG7ntpFovxehpSrHMkchc nr9/QFGReMrfuikBKKxNmuWT+2P3sOmdSA19rGjqEZfy5NoFpNEaCtYcdNFI3Ch81itE whZGixN3QPWfnwjQQ/cwxYNQbRry7s0qiesvJusnKp7MHkbrg0tIeoSgNqLKxp2N3fYh HE79up93nCfgDD5vpz/mgOdi0yxjBqZizT3EQg9AUpRXPr9aBSfDSUJ+XtXZrdVYCXuZ p+mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AwGQtqIP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r16-20020aa7d590000000b005223f4f74a8si6884880edq.398.2023.08.02.17.05.24; Wed, 02 Aug 2023 17:05:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AwGQtqIP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232533AbjHBXrU (ORCPT + 99 others); Wed, 2 Aug 2023 19:47:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231444AbjHBXrS (ORCPT ); Wed, 2 Aug 2023 19:47:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE8161BF1; Wed, 2 Aug 2023 16:47:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A89B61B7F; Wed, 2 Aug 2023 23:47:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59BEBC433C7; Wed, 2 Aug 2023 23:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691020036; bh=/qLrq5KmhPCru0yGNrw689Q7iuDeimHvE/3JmRSDTww=; h=From:Date:Subject:To:Cc:From; b=AwGQtqIPzjbR8wMuR5jn2X71Mwj4xDLmlhgEmXwS6B3MUajRsljJLfcJoV+JWzkpB RzPxVWhsI3E/BTIFE7+Idh22k3TjJLZTFlUeLJw1YvZFYX7vmg22cAl+M2dUjKuYC0 ZSLPwBslwt6qGqlztOwGzXdAErfHGcQ6kG+/z3PtP0RsYMVGjfEgI5mGuDODF4FL/6 90DddhJfnLjAH6LEDvcwRiZ9pPGVbIK2huHwt9lvNmfl1amXfswQFM+TabHFvKrpJl 0w/BZs6N3v33CFxpF/PiWFd91eQPWJtYj/SWmMXP71Lu4Mc+pjZIgpPbEpQuIN2MUc VKLVj7VY2RgMA== From: Mark Brown Date: Thu, 03 Aug 2023 00:46:39 +0100 Subject: [PATCH] arm64/fpsimd: Clear SME state in the target task when setting the VL MIME-Version: 1.0 Message-Id: <20230803-arm64-fix-ptrace-tif-sme-v1-1-88312fd6fbfd@kernel.org> X-B4-Tracking: v=1; b=H4sIAN7qymQC/x2MywqAIBAAfyX23IKZSPUr0cF0rT30YI0IpH9PO g7MTIZEwpRgqDII3Zz42As0dQV+dftCyKEwaKVb1SmNTjZrMPKD5yXOE14cMW2Eao6hN77T1gY o+SlUrH89Tu/7AXktrpBqAAAA To: Catalin Marinas , Will Deacon Cc: David Spickett , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Brown , stable@vger.kernel.org X-Mailer: b4 0.13-dev-034f2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1382; i=broonie@kernel.org; h=from:subject:message-id; bh=/qLrq5KmhPCru0yGNrw689Q7iuDeimHvE/3JmRSDTww=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBkyusCoD1cpgdbLKtmBqNR295Gzu5KbTY2MY4nxVPB 0NnJ2mmJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZMrrAgAKCRAk1otyXVSH0B3JB/ 9WoAz7QxboWYtzDkqt8/cmsOqEMDh0uIswB63EKF0rOJZSkukmRnuVUIIt01kyH9jEh6/CfbJeIhMX COMMFmM3tzymxHyb+FQOU3sFXzx+GxDmQiB79Jvwhh9+djemFdAKmSkOjmZROUrl+cGhPiGSbfpwRl t230mvLmbkeDajUEwoCeiFjRnH8prZPX8yfCEaLWFslWxL3I+awa2jrGm0XSwkmojp5oFAueyYfrnu 2NwKEiwEjAi6pDcqqueBmmkR94EiKYlEkbk2X9rkUeTIXO/MteVFapOop7v7kuwNJRSZfRRAhDQoE+ sB21YuxIJTucBsPanLSxDuQwgrole5 X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773164191979851397 X-GMAIL-MSGID: 1773164191979851397 When setting SME vector lengths we clear TIF_SME to reenable SME traps, doing a reallocation of the backing storage on next use. We do this using clear_thread_flag() which operates on the current thread, meaning that when setting the vector length via ptrace we may both not force traps for the target task and force a spurious flush of any SME state that the tracing task may have. Clear the flag in the target task. Fixes: e12310a0d30f ("arm64/sme: Implement ptrace support for streaming mode SVE registers") Reported-by: David Spickett Signed-off-by: Mark Brown Cc: stable@vger.kernel.org --- arch/arm64/kernel/fpsimd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 5d0c230f1de8c7515b6567d9afba1f196fb4e2f4 change-id: 20230802-arm64-fix-ptrace-tif-sme-0bfd94c8266d Best regards, diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c index 520b681a07bb..a61a1fd6492d 100644 --- a/arch/arm64/kernel/fpsimd.c +++ b/arch/arm64/kernel/fpsimd.c @@ -909,7 +909,7 @@ int vec_set_vector_length(struct task_struct *task, enum vec_type type, */ task->thread.svcr &= ~(SVCR_SM_MASK | SVCR_ZA_MASK); - clear_thread_flag(TIF_SME); + clear_tsk_thread_flag(task, TIF_SME); free_sme = true; } }