diff mbox series

[RFC,v4,1/7] libtraceevent: sync state char array with the kernel

Message ID 20230802121116.324604-2-zegao@tencent.com
State New
Headers
Series fix task state report from sched tracepoint |

Commit Message

Ze Gao Aug. 2, 2023, 12:09 p.m. UTC 
  Update state char array to match the latest kernel
definitions.

Signed-off-by: Ze Gao <zegao@tencent.com>
---
 plugins/plugin_sched_switch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Steven Rostedt Aug. 2, 2023, 2:36 p.m. UTC | #1 
On Wed,  2 Aug 2023 08:09:56 -0400
Ze Gao <zegao2021@gmail.com> wrote:

> Update state char array to match the latest kernel
> definitions.

Can you send this separately to linux-trace-devel@vger.kernel.org?

Thanks,

-- Steve

> 
> Signed-off-by: Ze Gao <zegao@tencent.com>
> ---
>  plugins/plugin_sched_switch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/plugins/plugin_sched_switch.c b/plugins/plugin_sched_switch.c
> index 8752cae..e0986ac 100644
> --- a/plugins/plugin_sched_switch.c
> +++ b/plugins/plugin_sched_switch.c
> @@ -11,7 +11,7 @@
>  
>  static void write_state(struct trace_seq *s, int val)
>  {
> -	const char states[] = "SDTtZXxW";
> +	const char states[] = "SDTtXZPI";
>  	int found = 0;
>  	int i;
>
Ze Gao Aug. 3, 2023, 2:13 a.m. UTC | #2 
FYI, I‘ve already cc-ed to it.  Do you mean I need to resend this patch
to linux-trace-devel@vger.kernel.org solely and exclude this one from
this series?

Regards,
Ze

On Wed, Aug 2, 2023 at 10:36 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Wed,  2 Aug 2023 08:09:56 -0400
> Ze Gao <zegao2021@gmail.com> wrote:
>
> > Update state char array to match the latest kernel
> > definitions.
>
> Can you send this separately to linux-trace-devel@vger.kernel.org?
>
> Thanks,
>
> -- Steve
>
> >
> > Signed-off-by: Ze Gao <zegao@tencent.com>
> > ---
> >  plugins/plugin_sched_switch.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/plugins/plugin_sched_switch.c b/plugins/plugin_sched_switch.c
> > index 8752cae..e0986ac 100644
> > --- a/plugins/plugin_sched_switch.c
> > +++ b/plugins/plugin_sched_switch.c
> > @@ -11,7 +11,7 @@
> >
> >  static void write_state(struct trace_seq *s, int val)
> >  {
> > -     const char states[] = "SDTtZXxW";
> > +     const char states[] = "SDTtXZPI";
> >       int found = 0;
> >       int i;
> >
>
Steven Rostedt Aug. 3, 2023, 2:37 a.m. UTC | #3 
On Thu, 3 Aug 2023 10:13:16 +0800
Ze Gao <zegao2021@gmail.com> wrote:

> FYI, I‘ve already cc-ed to it.  Do you mean I need to resend this patch
> to linux-trace-devel@vger.kernel.org solely and exclude this one from
> this series?
> 

I searched the Cc list and missed it. Anyway, you only need to Cc the
patches that touch libtracevent, and not the rest. No biggy, I just have to
mark them as "Handled elsewhere" in patchwork.

-- Steve
Ze Gao Aug. 3, 2023, 2:49 a.m. UTC | #4 
Got it. Will send patches for libtraceevent separately, Combining
patches from 2 different trees annoys me as well ;)

Regards,
Ze

On Thu, Aug 3, 2023 at 10:37 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Thu, 3 Aug 2023 10:13:16 +0800
> Ze Gao <zegao2021@gmail.com> wrote:
>
> > FYI, I‘ve already cc-ed to it.  Do you mean I need to resend this patch
> > to linux-trace-devel@vger.kernel.org solely and exclude this one from
> > this series?
> >
>
> I searched the Cc list and missed it. Anyway, you only need to Cc the
> patches that touch libtracevent, and not the rest. No biggy, I just have to
> mark them as "Handled elsewhere" in patchwork.
>
> -- Steve
diff mbox series

Patch

diff --git a/plugins/plugin_sched_switch.c b/plugins/plugin_sched_switch.c
index 8752cae..e0986ac 100644
--- a/plugins/plugin_sched_switch.c
+++ b/plugins/plugin_sched_switch.c
@@ -11,7 +11,7 @@ 
 
 static void write_state(struct trace_seq *s, int val)
 {
-	const char states[] = "SDTtZXxW";
+	const char states[] = "SDTtXZPI";
 	int found = 0;
 	int i;