From patchwork Wed Aug 2 09:37:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 129557 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp141062vqx; Tue, 1 Aug 2023 18:53:52 -0700 (PDT) X-Google-Smtp-Source: APBJJlFBklSOFUlhoyTyKrA2faJ+b7BTDQ8op/pQtxmpDclosOnhuwETM0HFzcFvT6lwycMYeVfJ X-Received: by 2002:a67:f54a:0:b0:43f:4714:a03b with SMTP id z10-20020a67f54a000000b0043f4714a03bmr3933375vsn.17.1690941232534; Tue, 01 Aug 2023 18:53:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690941232; cv=none; d=google.com; s=arc-20160816; b=hWBk5H68vAvPYYC7ifyo6uJhoCIRohhGwYSJrqfU+fAg17B3Zx4LtC7hVn/WZh/f6M A9lHH/cP/q2TLgCUrpWeisKuqdcgySOvW7arQnvwmXtjXqk5R1GmMelPoLoPzdoFMX7q /1xhLbCMDlbmvl9O7rX0nbvLE2bUWhmYIKbXltx3U+BwnPe7jc3SBPPuoF9+FEqydaFV MhSj8koD2PlKGjNMKwugTezyUDN3kOfG6BXuEldafAuXs6iU4VlbcV31ZoxeXEwO14uL WbhDCOHZKKQMkSEoFki7P8KsXDkjqWuAPCRTVp5aCLeRzUFhSnWmbYpJirVaXZtSy7ZY 4CRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=E8Ghhfo476pomQiMg5Ny4FSukhbg2Nff++sDyzBNwac=; fh=zpCCF/J8Z0sUUNZfCNdnaRvm94yhXPVxl9PzV22VU6k=; b=0SWBqYpJ8ZGvy6KW+qEwu0ofPG19Upn2k6dLuWmzMRMMupOwFRH1S4f1GMXEo2Pr7t dzs9to6CVB4HhDQ5ObhOf+wUewXea2I8e5dqITtsX8OAZMPlSBtMrXxIEcd43jXLGDEo l9m8tdYl/mBHRwx5zfLgyKaZbUb3xC40/JShEUpmIZhFIjKZOk9ovjVLLz+zBAD52Pdf NkJoLCwD5WCzrAwh2AphWc38FyU4YKpIhK9kTV6hL9v/QN5FrLXMxF1h0yq+PDRGxEYB 73iYoMe0IZCP8XQLd2DRON8YuNa5tg3oiuUj8URpWkiHHCyyzaKVUlnrhIkuIZtZ+PyI a/cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r8-20020a17090aa08800b0025027e0ad3dsi307279pjp.81.2023.08.01.18.53.39; Tue, 01 Aug 2023 18:53:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231396AbjHBBiD (ORCPT + 99 others); Tue, 1 Aug 2023 21:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231349AbjHBBhc (ORCPT ); Tue, 1 Aug 2023 21:37:32 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0072E269A for ; Tue, 1 Aug 2023 18:37:31 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RFvjh3Zmkz4f3nbJ for ; Wed, 2 Aug 2023 09:37:28 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAXzrFTs8lkvrtvPQ--.56352S10; Wed, 02 Aug 2023 09:37:29 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH v2 8/8] mm/compaction: only set skip flag if cc->no_set_skip_hint is false Date: Wed, 2 Aug 2023 17:37:41 +0800 Message-Id: <20230802093741.2333325-9-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230802093741.2333325-1-shikemeng@huaweicloud.com> References: <20230802093741.2333325-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAXzrFTs8lkvrtvPQ--.56352S10 X-Coremail-Antispam: 1UD129KBjvdXoWrtw4ktF1DJF1Utw1kKw43trb_yoW3trc_Jr 10yF4rtw1avr93AFn8Xw47Cr1kKrWDCrnrWF1kXr4ay3yqya1vq3WDXrnrXw15XFW7ur9x GaykZF48GFya9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJ M28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2I x0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK 6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4 xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8 JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20V AGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r4j6ryUMIIF0xvE2Ix0cI8IcVCY1x0267AK xVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0pRvJPtU UUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773080393576653556 X-GMAIL-MSGID: 1773080393576653556 Keep the same logic as update_pageblock_skip, only set skip if no_set_skip_hint is false which is more reasonable. Signed-off-by: Kemeng Shi Reviewed-by: David Hildenbrand --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index a1cc327d1b32..afc31d27f1ba 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1421,7 +1421,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false); /* Skip this pageblock in the future as it's full or nearly full */ - if (start_pfn >= end_pfn) + if (start_pfn >= end_pfn && !cc->no_set_skip_hint) set_pageblock_skip(page); }