From patchwork Wed Aug 2 09:37:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 129553 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp140234vqx; Tue, 1 Aug 2023 18:51:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlFHQKmJpt2EJ7HXgIhEygO4G3NsRLolQD6iMqGTMQRH8UVSnPNW4GvKYSwV89viXcuY03Eu X-Received: by 2002:a17:903:545:b0:1b8:1e05:ed09 with SMTP id jo5-20020a170903054500b001b81e05ed09mr11473254plb.36.1690941101960; Tue, 01 Aug 2023 18:51:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690941101; cv=none; d=google.com; s=arc-20160816; b=vWfxUKQmMGXaBxlkEDnS/5hnjj20UYu8xSCzbEVSxLbnFj5hfqGQaoUvK9cURmEQi8 3+RMYOyvgNY1g7HLwtFBBQu++/FGzuwUeydp8iVIotVkBTVJygP/1IWbapsN3NrqR1Ee Wfxx9811m6MjWI5jsPlLjC+FeXA5GOeD7mzsPZ5Yb8+Jq4ffVpAw4W4TcHZwmTp48pV/ JtGoHctA9ddnOyBlAkEsYMWptd8XOpvnbNkm4ggiRqP9fFCRig2sSxWdD1HViY2bVj2U ivumCcJzsqOeo5eNUnG8I9RmrRDL0cdSpfRtkKk5smTLNkAvsgkvqu0bMjCtkYw7jQq3 NdfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ojMDeLWoj1XODyjeyi7n+gkeOl0JR/suB/pw9H0+pdg=; fh=zpCCF/J8Z0sUUNZfCNdnaRvm94yhXPVxl9PzV22VU6k=; b=Uv1fIsxYsmn5JpvSMx2HBdWYzs6XuRpi8iew8UETb9cX1l+5n2DylNlAr7N6Ngx4Hk GMEQ4Jc0k+w4V7QvnLVm7KhD8Mk2QEpChqvz3nG2CrViCPR5nApqpZ1ntMocRVxzynmJ J0bA4k9KsNeDp3/NQPms7LnAuiv8C1t9M6RXQ0On0Dx/e5sLRxl0EY4nOZ2xKinLhmg9 sbzfYHBRYSKWuUcb91w1GkhDY1MZ+AJXIagDFaRg4pWNvxW4BNm7xJW8Q09PfqWACe3v 7ALIGByOw7+X4ZTDbv+1/VpJ9ky3xJS1tf9nPdENudMlb3IB3lXEAbaSd/Pwg6y9flMk IQGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lb7-20020a170902fa4700b001b86671b3f1si9797845plb.190.2023.08.01.18.51.28; Tue, 01 Aug 2023 18:51:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231461AbjHBBh4 (ORCPT + 99 others); Tue, 1 Aug 2023 21:37:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231222AbjHBBhc (ORCPT ); Tue, 1 Aug 2023 21:37:32 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 449121B7 for ; Tue, 1 Aug 2023 18:37:31 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RFvjh1vNyz4f3pC7 for ; Wed, 2 Aug 2023 09:37:28 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAXzrFTs8lkvrtvPQ--.56352S8; Wed, 02 Aug 2023 09:37:28 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH v2 6/8] mm/compaction: correct comment to complete migration failure Date: Wed, 2 Aug 2023 17:37:39 +0800 Message-Id: <20230802093741.2333325-7-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230802093741.2333325-1-shikemeng@huaweicloud.com> References: <20230802093741.2333325-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAXzrFTs8lkvrtvPQ--.56352S8 X-Coremail-Antispam: 1UD129KBjvdXoWrZF1UKrW8Kr48JrWrWrW3Wrg_yoWfWFX_Jr 4Iyr1rWw1F9r9IyanrCayayryagr4kZr17Ww1DX3y7t34vyF4fW3WDArsrZr9YqayDW3sx C34kZr1jk3Za9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJ M28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2I x0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK 6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4 xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8 JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20V AGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AK xVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0pRvJPtU UUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773080256623643459 X-GMAIL-MSGID: 1773080256623643459 Commit cfccd2e63e7e0 ("mm, compaction: finish pageblocks on complete migration failure") convert cc->order aligned check to page block order aligned check. Correct comment relevant with it. Signed-off-by: Kemeng Shi --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index 7f01fbeb3084..5581e4cccac5 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -2512,7 +2512,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) } /* * If an ASYNC or SYNC_LIGHT fails to migrate a page - * within the current order-aligned block and + * within the pageblock_order-aligned block and * fast_find_migrateblock may be used then scan the * remainder of the pageblock. This will mark the * pageblock "skip" to avoid rescanning in the near