Message ID | 20230802093741.2333325-6-shikemeng@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp140414vqx; Tue, 1 Aug 2023 18:52:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlEcRS/WyhW/zkAPFOm+/e/+vXehEo5E1OTkF3rGOCKwsYzjkyegkx7S+X3gvt6EixTKJqg6 X-Received: by 2002:a05:6358:725:b0:139:9fc3:eade with SMTP id e37-20020a056358072500b001399fc3eademr5121367rwj.29.1690941131612; Tue, 01 Aug 2023 18:52:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690941131; cv=none; d=google.com; s=arc-20160816; b=vXV9dBh0QYZFIwMtPIzawYOcOTSvcyIwrGpXHnTtTkYsLkTCpoEkfJr8/5FhdhvKKc kvG5p52k2O3rSh90Iz2rQpAMU9Chu+qipL7+UXwsSIQgsKKKpEkN/j36tlbmNZsUTZLj YesFpbMCJYnF1axMBe7KLjEBTnd9nSi3/AGYBD8Wq/MxIjMnoReBGB6CJRFODm4SpQDx ir7MsqdPcspKP0qD5jfIPYMO4mx+I1OGWYapspwDM/HqmskqiET3fgik0EoZjhOgkv3S USjIkbgSGnhaFOPFgIEeW9kTBHZv55Y529LBnjvCB3Hhda5SbrxRlWsGz3nrnESAxkL3 4aDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Bgf3L5+1beG8C64RCCnI2PAMOD4a+B0/f237uX2C7Xk=; fh=zpCCF/J8Z0sUUNZfCNdnaRvm94yhXPVxl9PzV22VU6k=; b=MwsXCTPp/YLXmUhlDUw9+zo1sSkpUyv41M4GOrd78q3A5yiLHpN/Gw4rt0ImmofEyi c+MdP+0zHRX/yiwsadHUBpIIJHQt5uSpxkFVZkcCfEnnLZo6b5cx1onVPk52cntSRWNH cBsbspP4L1yYgPuyeEWV1c5iwMKqEMMJ8QW70oR5t+8llVfAGXHxA2W3bKP5voc3Rh+I xqrrtQ/Fp39vp6NApRUc408RJ+8dKVlC6JjLvK38mJFfWbTm2rif1d07SGVeryAUZt5e yqSTff6QcEiuaSpGCO1bVKCipV9SlTz71KDxNdZXUNVARw78/hk57tuS8ulnX1BxECBo oE4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c5-20020a6566c5000000b005645bbc8427si3168900pgw.452.2023.08.01.18.51.58; Tue, 01 Aug 2023 18:52:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231510AbjHBBhx (ORCPT <rfc822;maxi.paulin@gmail.com> + 99 others); Tue, 1 Aug 2023 21:37:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231156AbjHBBhb (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 1 Aug 2023 21:37:31 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAAA526AA for <linux-kernel@vger.kernel.org>; Tue, 1 Aug 2023 18:37:30 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RFvjg2XRXz4f3n6M for <linux-kernel@vger.kernel.org>; Wed, 2 Aug 2023 09:37:27 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAXzrFTs8lkvrtvPQ--.56352S7; Wed, 02 Aug 2023 09:37:28 +0800 (CST) From: Kemeng Shi <shikemeng@huaweicloud.com> To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH v2 5/8] mm/compaction: correct comment of cached migrate pfn update Date: Wed, 2 Aug 2023 17:37:38 +0800 Message-Id: <20230802093741.2333325-6-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230802093741.2333325-1-shikemeng@huaweicloud.com> References: <20230802093741.2333325-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: gCh0CgAXzrFTs8lkvrtvPQ--.56352S7 X-Coremail-Antispam: 1UD129KBjvJXoW7tr1Duw4UKF45WFWktFWDArb_yoW8Jw13pr 97Cw1jqw4vqa13Kas2yr1kZa18Jr4ftFy3trsrK348AF43K3ZrtF9rtFyUZFW5X3sIvrWa vF47KFW7ta1fZaUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPF14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2jI8I6cxK62vIxIIY0VWUZVW8XwA2048vs2IY02 0E87I2jVAFwI0_JF0E3s1l82xGYIkIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0 rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6x IIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xv wVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFc xC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_ Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2 IErcIFxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Cr0_Gr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJV W8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjTRKfOw UUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773080288098435808 X-GMAIL-MSGID: 1773080288098435808 |
Series |
Fixes and cleanups to compaction
|
|
Commit Message
Kemeng Shi
Aug. 2, 2023, 9:37 a.m. UTC
Commit e380bebe47715 ("mm, compaction: keep migration source private to a single compaction instance") moved update of async and sync compact_cached_migrate_pfn from update_pageblock_skip to update_cached_migrate but left the comment behind. Move the relevant comment to correct this. Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Reviewed-by: David Hildenbrand <david@redhat.com> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com> --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c index 5c9dc4049e8e..7f01fbeb3084 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -469,6 +469,7 @@ static void update_cached_migrate(struct compact_control *cc, unsigned long pfn) pfn = pageblock_end_pfn(pfn); + /* Update where async and sync compaction should restart */ if (pfn > zone->compact_cached_migrate_pfn[0]) zone->compact_cached_migrate_pfn[0] = pfn; if (cc->mode != MIGRATE_ASYNC && @@ -490,7 +491,6 @@ static void update_pageblock_skip(struct compact_control *cc, set_pageblock_skip(page); - /* Update where async and sync compaction should restart */ if (pfn < zone->compact_cached_free_pfn) zone->compact_cached_free_pfn = pfn; }