From patchwork Tue Aug 1 14:31:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 129037 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp2485700vqg; Mon, 31 Jul 2023 23:52:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlHGkyvkqt9+5Ezt3YhP1Sp/cjwroaM8ZiSGM9QyIMLvV6xDrIc42s/+aP/peVibNLGcEeOp X-Received: by 2002:a05:6a00:2316:b0:687:535f:6712 with SMTP id h22-20020a056a00231600b00687535f6712mr1105354pfh.14.1690872759868; Mon, 31 Jul 2023 23:52:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690872759; cv=none; d=google.com; s=arc-20160816; b=0ZVRSe4TXE8wW/sAC2ikUNByrZpDFjtbdMBKd1QISKTRrJfT0VqKSlZzxvzbIXxBVr yoon15+TmbGiMaPG3sLcX4N5Sj8YSvchUwdUmdDv1wOkobfIRrG5s5ngTq6KnbzPuMTv W5D10KahMZYTQufelCK41i2qBsthZ89Ru0hDBJqFWrtI2/CdtDqWsNtPxl7JE38PG0ft zSUrECMfsNNcB3MqCBjqnUAZIuVItA+NTpK174JZVIHt+fkoT8PQYh16lqcF6VGD5hnw Y9lftQYYXH2J5UsOD99+JMzlsCOExlR6o6lx+FY8U9f4iyhKUhuajoMvBvGO8Cf5em67 h4KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=4zfd6w8YDuBol5fU+o8MqqyciyXmW31rc0yklHeeYgA=; fh=MlGqaUnvBjpXmiP990bdf+mzv9VjPrVaE5OVdv29XYE=; b=hIN0/vJwMlxvrTrvKJJh7sJPmum20zaxltaFkS5E1luantM1k/iMAGru+1CyDn7Gh3 Q8nE2om0WEoB8DdN4tdLbWkjdmrlqGrnmMF9WOFjyc5czW6TSzf+rlAwHQZDLdzgDb3U /7eL3VMX+ys+FLDBHypjGRpfgLJEP2DatI0LFa4iAOpkAiJShkK5tK9UzZ6EMGzJeRhh hgPEN06kl42hqC1whTTu8bVD19lzr44uw64ZjOoh4YL2TEGinf2hJkBbGbZRvJHVFeZN OPa/8RX/72wRIuiaHQLW3J5qkiCvahogmdfWSBI96YrQSn48Ox/8mApRdx/qI8BEfTPz DrFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s76-20020a63774f000000b0056419b1dc2bsi6740714pgc.276.2023.07.31.23.52.26; Mon, 31 Jul 2023 23:52:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231720AbjHAGcI (ORCPT + 99 others); Tue, 1 Aug 2023 02:32:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231383AbjHAGbx (ORCPT ); Tue, 1 Aug 2023 02:31:53 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B1AB1BB; Mon, 31 Jul 2023 23:31:52 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RFQHl6tWSz4f3jM3; Tue, 1 Aug 2023 14:31:47 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgDnjOrQpshkMcvqPA--.21719S6; Tue, 01 Aug 2023 14:31:48 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca, ritesh.list@gmail.com, ojaswin@linux.ibm.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Cc: shikemeng@huaweicloud.com Subject: [PATCH v3 04/10] ext4: use is_power_of_2 helper in ext4_mb_regular_allocator Date: Tue, 1 Aug 2023 22:31:58 +0800 Message-Id: <20230801143204.2284343-5-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230801143204.2284343-1-shikemeng@huaweicloud.com> References: <20230801143204.2284343-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: Syh0CgDnjOrQpshkMcvqPA--.21719S6 X-Coremail-Antispam: 1UD129KBjvdXoW7GF1rJr1UurW8Jw1xGw47XFb_yoWfXFX_Ga 4jkr4xJFWfJr1Ik3ZYyayktr90qFs5AF45XFs3JrsxXF1UuFZ7Kw1qyrs3Zr48WrW7Ar9x W3ZxGFy0yasa9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDxFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJ M28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2I x0cI8IcVCY1x0267AKxVWxJr0_GcWl84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vE x4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2 IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4U McvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I64 8v4I1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AK xVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrx kI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v2 6r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJw CI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjTRKfOwUUUU U X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773008595473598174 X-GMAIL-MSGID: 1773008595473598174 Use intuitive is_power_of_2 helper in ext4_mb_regular_allocator. Signed-off-by: Kemeng Shi Reviewed-by: Ritesh Harjani (IBM) --- fs/ext4/mballoc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 4cbbe930e010..acf8e3183e47 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -2799,10 +2799,7 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) * requests upto maximum buddy size we have constructed. */ if (i >= sbi->s_mb_order2_reqs && i <= MB_NUM_ORDERS(sb)) { - /* - * This should tell if fe_len is exactly power of 2 - */ - if ((ac->ac_g_ex.fe_len & (~(1 << (i - 1)))) == 0) + if (is_power_of_2(ac->ac_g_ex.fe_len)) ac->ac_2order = array_index_nospec(i - 1, MB_NUM_ORDERS(sb)); }