From patchwork Tue Aug 1 13:24:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 129304 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp2677827vqg; Tue, 1 Aug 2023 06:43:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlHY7wBgf23ZrsZKZRWirCtvMTGjPs37V0ty+oeUM5vHOb753uxkZmstXXLxDLcqqB7/kXgP X-Received: by 2002:a17:902:ed8c:b0:1b8:28f6:20e6 with SMTP id e12-20020a170902ed8c00b001b828f620e6mr11022002plj.34.1690897394850; Tue, 01 Aug 2023 06:43:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690897394; cv=none; d=google.com; s=arc-20160816; b=SbxzRpzYKqOed4hWmunFq81ErNoS5vOkfdPXmO2bvRZ8CEMPChFetygUn8KI+whBtR Xs5nVnqaXKO9dGJbOmdl+NBX7QdElY5e1EnG96PWBkodfxD/gRY9KdD60Hdu5EQk+a7K TdXhI08xP2UnSivgVG5VWog45RKCWt6wY0RoyuyFs2tzRJw3Lg8Hgctb3IvXvvYdhn3x zg/dWShx+aZJ1AO6JvHHPG0ANq0hMAOIpZI1P9DbnSGvl+4ccqrIYLuouss54BIydrOb z0MxUvJYg6fdpvMpzV5yZR4pxnJ0v8vs4Xes0WyI+0/7FY+cADDoxSZC5jvR8VktJZhd FSUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Vjm5rqPvdxUy7Z6aUM6JkGwm74Jj3I1LYFhNzNy9bzo=; fh=JC0FP1KBPXa+8NkvIvZoCUIIa+zGdCFP1xCgvJrJBSE=; b=j9Y5oH/izDqsnslTxeDoKj9G4UTUK3BFMl8Oi2UxDrdA5xM6kQm82ocHmlkMxZAdlb 5UiTOhlPiu36i2b1P8cdy6cCndyfse9I2d+wLOUMxa5HpX7DDdhqla7DiyTWbmimzLHK 3veiMTTZ/dUoNri6+kO0VSNp1pZEcUcsTYMhwuufZxx/IhTWDYdDrVtS25kvGUwUpwn8 30rWmCgqme/w1qJlMGXRr9g6m4EJI5upT7ZS2rt5Dxy+aSFBeSzZRAEPd/uPi37k8AzI 6oxSuayS1BOqk7ZmSJLYxyQ/pxV8claGMLLJ0iJsr9Rk8klIxOMceoHSl5buPbO2QYAL x/5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oUheRgQ6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n10-20020a170902d0ca00b001b20e2ba8e1si5251398pln.23.2023.08.01.06.43.01; Tue, 01 Aug 2023 06:43:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oUheRgQ6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234093AbjHANYy (ORCPT + 99 others); Tue, 1 Aug 2023 09:24:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230315AbjHANYw (ORCPT ); Tue, 1 Aug 2023 09:24:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C1841985 for ; Tue, 1 Aug 2023 06:24:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE895615A4 for ; Tue, 1 Aug 2023 13:24:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BDFBC433C7; Tue, 1 Aug 2023 13:24:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690896290; bh=OCbZZEYY6XG+Gj++glqCcqULb++oCr0LofyrtVtyhEc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oUheRgQ6e3jTLVKzFRNeivu8xi+wx3bSs7luMToq7MPUyeMEOdFV9Z10Xwj52jGBl TsBzJKvb9b+/lHy5AF7lkLk+ev1RoQAc/mtDMsEnAswNdWKiH79GfrtjsA5DmDxD8M GFiG1ohj3mNsLa4alssdvt9LGyjknXtmPAD/p8AhgFnq34OEh2S6c0lToN5VK9gU5j kA/v7zsvQ5CTF3dGiW/7YcQBuJqvH75sOtwB2Kultu/XQULLc5jC2TOqCrm5klZUOs /brfyl+A+H/TH738p7IqIOp+65VenPfrbLtrAiSiK77m2Oh3wDfMsnvm2MzM8Luh4+ u7PdXIokymRMw== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Sebastian Andrzej Siewior , Peter Zijlstra , Thomas Gleixner , "Paul E . McKenney" , Linus Torvalds , Anna-Maria Behnsen , Eric Dumazet Subject: [RFC PATCH 1/6] softirq: Turn set_softirq_pending() to reset_softirq_pending() Date: Tue, 1 Aug 2023 15:24:36 +0200 Message-Id: <20230801132441.559222-2-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801132441.559222-1-frederic@kernel.org> References: <20230801132441.559222-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773034426743812526 X-GMAIL-MSGID: 1773034426743812526 set_softirq_pending() is only ever used to reset the pending vector's mask to 0. Make the function more specialized for that very purpose and rename it accordingly. Signed-off-by: Frederic Weisbecker --- include/linux/interrupt.h | 2 +- kernel/softirq.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h index bf82980f569d..2099fe3980bc 100644 --- a/include/linux/interrupt.h +++ b/include/linux/interrupt.h @@ -524,7 +524,7 @@ DECLARE_STATIC_KEY_FALSE(force_irqthreads_key); #endif #define local_softirq_pending() (__this_cpu_read(local_softirq_pending_ref)) -#define set_softirq_pending(x) (__this_cpu_write(local_softirq_pending_ref, (x))) +#define reset_softirq_pending() (__this_cpu_write(local_softirq_pending_ref, 0)) #define or_softirq_pending(x) (__this_cpu_or(local_softirq_pending_ref, (x))) #endif /* local_softirq_pending */ diff --git a/kernel/softirq.c b/kernel/softirq.c index 623985f18833..1a3c3fe341ea 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -532,7 +532,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void) restart: /* Reset the pending bitmask before enabling irqs */ - set_softirq_pending(0); + reset_softirq_pending(); local_irq_enable();