From patchwork Tue Aug 1 10:47:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 129271 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp2640797vqg; Tue, 1 Aug 2023 05:43:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlH1DLupRvpmjZGlgQVzqZLlCsWWXQlAKRC+n9ac5ZPWMUwipJihGudbHslnXv0o6Hw5LleD X-Received: by 2002:a05:6a00:2352:b0:687:1a86:7a78 with SMTP id j18-20020a056a00235200b006871a867a78mr11392866pfj.9.1690893826916; Tue, 01 Aug 2023 05:43:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690893826; cv=none; d=google.com; s=arc-20160816; b=aBwmSXMc3Dai+7b/F0V8BtfPJBPFuP0WFoW6wGQKbCkLuHulOqoo89tpSH8UWc2gVf iZE+s8WLR2Heo8azbPkHt2MlJmAjEK8eXFg2P09YZ+ynQ2mAT+QdB6jIQTmVQZ4aIWpY 6oszBsOJ94sKXl2cyzXjUUnQe8LBD5zEWJQWL6bOxs3d3wjYOkdcT8/y4nfvVh+zAJ7d oRlbXxyDIbpbLIIv5mWU42jn0wICdBVRotYjzt+re0sW+D5VgMyRVX3oTdsk2ydm971j uLdExXIyALPdA+vCVdKjUf6d3eMo20wq+zBm8SDR9+sVjhhh7Yiq1nMNSOUPouT3KbNa WqcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=1KrXZ6WN0UqKcYJn0Q3OLCj/xDPlvNt/2RBQorpLgnc=; fh=mE3iieUIZLcDfOLIULj9X6/p0bMDPZGFSVRsnyRUnTc=; b=ne36ErhFzjD/klRpv77fwlsHUVXJWMGPRvPY8MuKJgRpcw2AoTOOGzc9mdK7jseh1g IyvHKAp0FjOmjAM3+h3vNKX2Hce3342aNP2KxFvtz9VJCjwDJauIoHWDkpo91kvJLOzV hStE9EV6Q8E923zCA05ltoqb8+NSXtneDzNk1cnyK1GGj6lHtSD6DbcmUrgDafJJgx6S c2kVq9i3HTiJbKJdSb/eu1oV0IyGjKhvQbGrHbqJJaCn71TThBq+BtNFwXY3XvkVS0l6 5XLs0Yx7i9i0x9JJF2PA+mQA8oRxnOa0GlpYb1VVz/Ho4UDcJpWR52mO0XfhbnNAIZRp wXvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=JzZ4pvGA; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e184-20020a6369c1000000b00563e25c07c0si8832355pgc.270.2023.08.01.05.43.33; Tue, 01 Aug 2023 05:43:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=JzZ4pvGA; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234205AbjHAKtr (ORCPT + 99 others); Tue, 1 Aug 2023 06:49:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232871AbjHAKtH (ORCPT ); Tue, 1 Aug 2023 06:49:07 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C77DB3A9C for ; Tue, 1 Aug 2023 03:47:40 -0700 (PDT) Message-ID: <20230801103816.801427736@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690886838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=1KrXZ6WN0UqKcYJn0Q3OLCj/xDPlvNt/2RBQorpLgnc=; b=JzZ4pvGAdAuoWfSspvr38QPDU5lVCe4tPQePPeYxM4DMwGJ4p0eJFfnRAViLUEwgJnLolL pW8fzgMUIFqBujJlSJyr2wBiuQ4R9O0oyG1ed0c7BiCKSxAtYesC4caXt47WmMox1CROFc +USO3RNyqJqALeNXO2MUu4bgXwKImP5lDx6ox6hBDiZrh2jzjvKZWIB4Vf6NUzrdXal+n6 8kbIqpJj2EktxnxySV9XeLVFAyYWNzYQK3hawi9F4M0wHnxAiLsvZWQxb7sgEPqVYNAaAn vs9VClaXQ1Tvt5XFI1He8wK/5+cWbcvXmHXMI0EDbhDc6Q+Ag8hbhGms2daNnA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690886838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=1KrXZ6WN0UqKcYJn0Q3OLCj/xDPlvNt/2RBQorpLgnc=; b=q5LF6LwSb9xUUPmwXv0iQa39Fr3DpgZ2pvHJWEWAJn4oVPIRfA1Pnebzzid18PkmT8rQbT 2ZQSCzlPvF4UGZBw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Andrew Cooper , Tom Lendacky , Paolo Bonzini , Wei Liu , Arjan van de Ven , Juergen Gross , Michael Kelley , Peter Keresztes Schmidt , "Peter Zijlstra (Intel)" Subject: [patch V3 30/60] x86/ioapic/32: Decrapify phys_id_present_map operation References: <20230801103042.936020332@linutronix.de> MIME-Version: 1.0 Date: Tue, 1 Aug 2023 12:47:18 +0200 (CEST) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773030685160992406 X-GMAIL-MSGID: 1773030685160992406 The operation to set the IOAPIC ID in phys_id_present_map is as convoluted as it can be. 1) Allocate a bitmap of 32byte size on the stack 2) Zero the bitmap and set the IOAPIC ID bit 3) Or the temporary bitmap over phys_id_present_map The same functionality can be achieved by setting the IOAPIC ID bit directly in the phys_id_present_map. Signed-off-by: Thomas Gleixner Acked-by: Peter Zijlstra (Intel) --- arch/x86/kernel/apic/io_apic.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -1511,12 +1511,9 @@ void __init setup_ioapic_ids_from_mpc_no physid_set(i, phys_id_present_map); ioapics[ioapic_idx].mp_config.apicid = i; } else { - physid_mask_t tmp; - - physid_set_mask_of_physid(mpc_ioapic_id(ioapic_idx), &tmp); apic_printk(APIC_VERBOSE, "Setting %d in the phys_id_present_map\n", mpc_ioapic_id(ioapic_idx)); - physids_or(phys_id_present_map, phys_id_present_map, tmp); + physid_set(mpc_ioapic_id(ioapic_idx), phys_id_present_map); } /*