From patchwork Tue Aug 1 10:47:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 129249 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp2623578vqg; Tue, 1 Aug 2023 05:11:58 -0700 (PDT) X-Google-Smtp-Source: APBJJlFXh7eGqGGGwWrZ/crwtwha4u44gqncAu2V5pLUecfa3/j5aO3MuGU7Uju2SWSr5ujPln04 X-Received: by 2002:a17:907:7745:b0:992:b9f4:85db with SMTP id kx5-20020a170907774500b00992b9f485dbmr2330278ejc.39.1690891918242; Tue, 01 Aug 2023 05:11:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690891918; cv=none; d=google.com; s=arc-20160816; b=a6wgbSiRfjCrqQfrBFuxKTAMKzVwp3k+a+JUCXR2eut0ie3xzGH4jbLkJS9l75llc6 ru1N8TcMvd87ymD9BN4JK8c2xNWEUInWmOVDjxERh2DENpjZFHsaV/qfrOLY1dVL4TZk JxSkrGUSikkAhylIpG1/CFvTZZL3n1elpBb2ExPA0mHlxuUfyUaoLjfjmS4DAVBvQPpO S5/1BwmWIkYZX+QltQoKWRpSKU2gtfhW1SJyFydCq0nk9GF10zVQ7cFGQUqYPwQHNEhv cYSVrqq9ProUNlI2hBoitup4RznMtTI24XglaNvl9EgKsH7pPO4L08nzt59VFGTAW5Q1 DQEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=b8Xt5cYn7tsxj5f5GzHs5GjoZDN6ZZKDqaLjg/BbaXY=; fh=mE3iieUIZLcDfOLIULj9X6/p0bMDPZGFSVRsnyRUnTc=; b=GQLpKc9tzBYNeUWBYFmmujAwPMwNAmomqZfbiHBLriv1KTRzOeDFXRm31ZwpVTdWVa LR8dG9LOmIhRhmanQd/fg27UiI3ZkO/1ooQW37NNi8iCE8tx1Ip+uIclPmqnQx8PmIl4 zzfd87R0OE5B9KY+2qmOoJAFOtdlQy/ZsZIbqGyFs/JyhyHETMLKTKvUklsQa90lM3hY s3jY+AcZooYpnKfkouJgsm4UUUyYa4aIARedN0FuwOQaJ3Z6K57cOHfyDX/8kY30C4RD Vzs7zlkLP/tprtHYGPYfaCOTwXUpmFqcKY8WItcp4vYRRikg8Pdv0j195+5kt+a/3hWO A+Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Z00TRirB; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b="x92s/Qt/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fi1-20020a170906da0100b00991df467bafsi4626628ejb.617.2023.08.01.05.11.34; Tue, 01 Aug 2023 05:11:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Z00TRirB; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b="x92s/Qt/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231806AbjHAKsl (ORCPT + 99 others); Tue, 1 Aug 2023 06:48:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234074AbjHAKry (ORCPT ); Tue, 1 Aug 2023 06:47:54 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04873272A for ; Tue, 1 Aug 2023 03:47:11 -0700 (PDT) Message-ID: <20230801103816.422281341@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690886829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=b8Xt5cYn7tsxj5f5GzHs5GjoZDN6ZZKDqaLjg/BbaXY=; b=Z00TRirBP3clJ4LWrrqlqd2XSlyhJsOyCDy/jDfh/BGtD35moVSIcvRMUerC7isI0r73zQ AU0R1VwTdOpK4xxAVptJerlV62Enp+vxmhy17puH6hoGhqjgavCwMQLLfIPmjmTQeOe7I1 UdnA+JQHBDfd5bniCZ89vWIQqtOI1CvocSf52Zs68k51xJ/oZxyja4qzDICWN2b0wjP8EO wJxM8nVCVwMg9sGnll/YMvCMJWIlRBqaolhOJ4XOIsoVIH8jLvrG4uoUyfW1mod5BfloWq N1DKHtXn/xtaud9ZKlkTkFhmhZ+BxME4AgDDZYvA7ysoVpvca2tpsSHNHc3leg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690886829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=b8Xt5cYn7tsxj5f5GzHs5GjoZDN6ZZKDqaLjg/BbaXY=; b=x92s/Qt/CUa5tUvtaVdTn5Ajo3NM4de/qbAYRz+3phisZVO5He3972ueLdmrOByGt2p9cN VbPJLM6YQiyTrKDA== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Andrew Cooper , Tom Lendacky , Paolo Bonzini , Wei Liu , Arjan van de Ven , Juergen Gross , Michael Kelley , Peter Keresztes Schmidt , "Peter Zijlstra (Intel)" Subject: [patch V3 23/60] x86/apic/ipi: Code cleanup References: <20230801103042.936020332@linutronix.de> MIME-Version: 1.0 Date: Tue, 1 Aug 2023 12:47:09 +0200 (CEST) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773028684014695049 X-GMAIL-MSGID: 1773028684014695049 Remove completely useless and mindlessly copied comments and tidy up the code which causes eye bleed when looking at it. Signed-off-by: Thomas Gleixner Acked-by: Peter Zijlstra (Intel) --- arch/x86/kernel/apic/ipi.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) --- a/arch/x86/kernel/apic/ipi.c +++ b/arch/x86/kernel/apic/ipi.c @@ -184,18 +184,13 @@ void default_send_IPI_single_phys(int cp void default_send_IPI_mask_sequence_phys(const struct cpumask *mask, int vector) { - unsigned long query_cpu; unsigned long flags; + unsigned long cpu; - /* - * Hack. The clustered APIC addressing mode doesn't allow us to send - * to an arbitrary mask, so I do a unicast to each CPU instead. - * - mbligh - */ local_irq_save(flags); - for_each_cpu(query_cpu, mask) { + for_each_cpu(cpu, mask) { __default_send_IPI_dest_field(per_cpu(x86_cpu_to_apicid, - query_cpu), vector, APIC_DEST_PHYSICAL); + cpu), vector, APIC_DEST_PHYSICAL); } local_irq_restore(flags); } @@ -203,18 +198,15 @@ void default_send_IPI_mask_sequence_phys void default_send_IPI_mask_allbutself_phys(const struct cpumask *mask, int vector) { - unsigned int this_cpu = smp_processor_id(); - unsigned int query_cpu; + unsigned int cpu, this_cpu = smp_processor_id(); unsigned long flags; - /* See Hack comment above */ - local_irq_save(flags); - for_each_cpu(query_cpu, mask) { - if (query_cpu == this_cpu) + for_each_cpu(cpu, mask) { + if (cpu == this_cpu) continue; __default_send_IPI_dest_field(per_cpu(x86_cpu_to_apicid, - query_cpu), vector, APIC_DEST_PHYSICAL); + cpu), vector, APIC_DEST_PHYSICAL); } local_irq_restore(flags); } @@ -283,7 +275,6 @@ void default_send_IPI_mask_logical(const local_irq_restore(flags); } -/* must come after the send_IPI functions above for inlining */ static int convert_apicid_to_cpu(int apic_id) { int i;