From patchwork Tue Aug 1 08:32:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Xin3" X-Patchwork-Id: 129120 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp2563169vqg; Tue, 1 Aug 2023 03:07:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlF8Ok+hgDt0gNGslmoAzLNB+LhNnVxS+nE0UV1gL38yG6zDx/RPd+qn/9zbYj1fhCJEQtID X-Received: by 2002:a05:6a21:778c:b0:131:dd92:4805 with SMTP id bd12-20020a056a21778c00b00131dd924805mr12535021pzc.57.1690884467013; Tue, 01 Aug 2023 03:07:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690884466; cv=none; d=google.com; s=arc-20160816; b=H7t/myDmbeIYJwJ54SQFcbMb9xbyyvsJw650mkzUtpvUKhyz8F+RTj8KwTUtVPLKOQ wLXca6vlIjy1BHoKAiqWpdyYG80gl0aRv376cVodF/RF0pdiF0JXo+YFR1QKooO4CqlN z6oRU45uIiHauXy5RWFgdUNECLjYK2ncExGFXSVZkM2ZvQbxYaZzS5fLPztKsqHFpZFa Qfan4o43iR8P2qzSr9cRyWvFqrbJL89xMayiaSrGqpcN6fhn2M+xg8ZdYXb7Y1RzhOOZ Ay7ZNOWHvsfMf9AWUPSSfMCd09m+0bfvrvAtVdQijrkyr6iI9uzHLWTLwMmYLtCKcqt/ IuBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=84HoV3iae/0CF7aC54iu6oPl8xtvmBXvhZ7K2Rg80CE=; fh=nYO9ukkM7JnAAJZcChGC8UWBlCLXeJxIDT82cxoIaf0=; b=AkgA0pMYBbJnqBlSEGbflGkhFp5DjAUsrzaHbw+5pCbBqXDQsPUrjqEn8qsHoQwGu4 wtPa70xwfoSYF7rsnBQV3gc+ZFhNnijrICXDSOeT7wy+9jQWSZs4c734iF4H5HazBXh2 4Hz5CZxuxpkWIp8tYYfRtSuPl45KLBVFou/yIVi8rLmX1+u71RIoI+ZYdPlKU4RV0ZoF vg9ZBdN4Ory3F8wHkBHy7uFNo1wi+RR3BcPGsO7vZ0UTj94wLmxdTlAQLp+tYVucoEHC OsV+uDvJUfv+6Gpfp152bJ0iHCfS/rB+o2NnT8htL/+aSgPPzrgW7WJ9l7AeOEUdCjiC srBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Qva8HElM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r22-20020a638f56000000b0054fdc588111si8148173pgn.438.2023.08.01.03.07.34; Tue, 01 Aug 2023 03:07:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Qva8HElM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232603AbjHAJF0 (ORCPT + 99 others); Tue, 1 Aug 2023 05:05:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232560AbjHAJEp (ORCPT ); Tue, 1 Aug 2023 05:04:45 -0400 Received: from mgamail.intel.com (unknown [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64CA92D60; Tue, 1 Aug 2023 02:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880606; x=1722416606; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=R/F68dINSJ894CWgsWAeNvE3sYeHzSDBLZY+Pavzuys=; b=Qva8HElMSGwHJahSqMun0fMgkEFq8RGIDrQJUFGTiCCtc5FLtEryDEYr nF9ZcFaiuGn6Ra/oOFZRYVLyOASmHBzqO+mHqiAXWkuVnG29KNUaC/lZB OsaeDEHqwjbJ8MbE1aVIKCHBsLzUwqkXRX5wZB3KqdoksiKpvWQubaW0p UwxBjgrLGpBBgX2H/9cMeT0PuLsJiec5wCmWIVPB9L75iWzJ4+A6PaRcn MUWzKmMaGBhzJgP5P+d9HRsleuyl++vrEuXkk7oSK0x+k9xhOL87sxtCT HIfbkL0B5cntC9RpRPxOWMZgyAeFjGycDcdgVpbHe8OIms0G+4AcFR8ht A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082571" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082571" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217053" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217053" Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:05 -0700 From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 16/36] x86/fred: Allow single-step trap and NMI when starting a new task Date: Tue, 1 Aug 2023 01:32:58 -0700 Message-Id: <20230801083318.8363-17-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773020870767279171 X-GMAIL-MSGID: 1773020870767279171 From: "H. Peter Anvin (Intel)" Entering a new task is logically speaking a return from a system call (exec, fork, clone, etc.). As such, if ptrace enables single stepping a single step exception should be allowed to trigger immediately upon entering user space. This is not optional. NMI should *never* be disabled in user space. As such, this is an optional, opportunistic way to catch errors. Allow single-step trap and NMI when starting a new task, thus once the new task enters user space, single-step trap and NMI are both enabled immediately. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v8: * Use high-order 48 bits above the lowest 16 bit SS only when FRED is enabled (Thomas Gleixner). --- arch/x86/kernel/process_64.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 6d5fed29f552..0b47871a6141 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c @@ -56,6 +56,7 @@ #include #include #include +#include #ifdef CONFIG_IA32_EMULATION /* Not included via unistd.h */ #include @@ -507,8 +508,18 @@ void x86_gsbase_write_task(struct task_struct *task, unsigned long gsbase) static void start_thread_common(struct pt_regs *regs, unsigned long new_ip, unsigned long new_sp, - unsigned int _cs, unsigned int _ss, unsigned int _ds) + u16 _cs, u16 _ss, u16 _ds) { + /* + * Paranoia: High-order 48 bits above the lowest 16 bit SS are + * discarded by the legacy IRET instruction on all Intel, AMD, + * and Cyrix/Centaur/VIA CPUs, thus can be set unconditionally, + * even when FRED is not enabled. But we choose the safer side + * to use these bits only when FRED is enabled. + */ + const unsigned long ssx_flags = cpu_feature_enabled(X86_FEATURE_FRED) ? + (FRED_SSX_SOFTWARE_INITIATED | FRED_SSX_NMI) : 0; + WARN_ON_ONCE(regs != current_pt_regs()); if (static_cpu_has(X86_BUG_NULL_SEG)) { @@ -522,11 +533,11 @@ start_thread_common(struct pt_regs *regs, unsigned long new_ip, loadsegment(ds, _ds); load_gs_index(0); - regs->ip = new_ip; - regs->sp = new_sp; - regs->cs = _cs; - regs->ss = _ss; - regs->flags = X86_EFLAGS_IF; + regs->ip = new_ip; + regs->sp = new_sp; + regs->csx = _cs; + regs->ssx = _ss | ssx_flags; + regs->flags = X86_EFLAGS_IF | X86_EFLAGS_FIXED; } void