diff mbox series

[net-next] net: Remove duplicated include in mac.c

Message ID 20230801005041.74111-1-yang.lee@linux.alibaba.com
State New
Headers
Series [net-next] net: Remove duplicated include in mac.c |

Commit Message

Yang Li Aug. 1, 2023, 12:50 a.m. UTC 
  ./drivers/net/ethernet/freescale/fman/mac.c: linux/of_platform.h is included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6039
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/net/ethernet/freescale/fman/mac.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Simon Horman Aug. 1, 2023, 10:06 a.m. UTC | #1 
On Tue, Aug 01, 2023 at 08:50:41AM +0800, Yang Li wrote:
> ./drivers/net/ethernet/freescale/fman/mac.c: linux/of_platform.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6039
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Looking at git history, I think that a slightly better prefix would be
'net: fman: '.

	Subject: [PATCH net-next] net: fman: ...

But other than that, this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>
patchwork-bot+netdevbpf@kernel.org Aug. 2, 2023, 10:50 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Tue,  1 Aug 2023 08:50:41 +0800 you wrote:
> ./drivers/net/ethernet/freescale/fman/mac.c: linux/of_platform.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6039
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/net/ethernet/freescale/fman/mac.c | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - [net-next] net: Remove duplicated include in mac.c
    https://git.kernel.org/netdev/net-next/c/34093c9fa05d

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
index b6c7c4c0b367..9767586b4eb3 100644
--- a/drivers/net/ethernet/freescale/fman/mac.c
+++ b/drivers/net/ethernet/freescale/fman/mac.c
@@ -12,7 +12,6 @@ 
 #include <linux/of_net.h>
 #include <linux/of_mdio.h>
 #include <linux/device.h>
-#include <linux/of_platform.h>
 #include <linux/phy.h>
 #include <linux/netdevice.h>
 #include <linux/phy_fixed.h>