Message ID | 20230731083806.453036-5-hch@lst.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp1902618vqg; Mon, 31 Jul 2023 02:49:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlEhJPnJtUpWnT8Drxxm6okkIv+xLaRUrSJPsvus11SS2uQjOouV84MsFJ1fF7yPgyLzZF8x X-Received: by 2002:a05:6358:52cc:b0:135:99fa:a125 with SMTP id z12-20020a05635852cc00b0013599faa125mr7096787rwz.1.1690796941453; Mon, 31 Jul 2023 02:49:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690796941; cv=none; d=google.com; s=arc-20160816; b=e/SbQiQXe6XzIXKkq0DkTqYd22/q334rpWLTM0yEecD2GC8M3YmHN5omuXjm+xDxKh Gtx/n45+ioxxCBsW/dLa6HkTAw/5PEh+50qHsaFwQzO3enhfS7uOJc9ZQ7ITpK97qn4q yn0DMUV2q+R0YWtCGaa71pIP4PX+gMEUvmZv3F18stbTwWi5fUZgh+2C+U3z2v5Unkpv Chen01ejgBInHgRBq8W6Do6jlz9KcKdLSfSsdTyk5O5qbDkPt2GU6R85AndhJGhM1uW3 7bHft5Ja0uYr3t3s6hLjlh0GvVxdPa1I53DYFU4iA5LTcjVog5TLVflyoJnN7mFTtE3+ wzVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ttl1JAg1w0mUKTBhkaN+L9fgEa5IyTTOyMQJJhARt48=; fh=Jf3M7ygXb8W1KLUVtb0UJCFyg9JtKT8TxO5XgFASIj0=; b=0zSL39qx4yERB8wa6sp4YVaCyBgR9p49dQJ1Hc42lsSd4A+R8bnA+cjuT2T24ZyJZI 1slkjkafcgsZnQ+CjFkhUfVakKiKV1Q/D/EWH3nWVXiefp/0HuqXnbmy1IfyTsqJvbSJ mI13tl8VjpEoZz7NTjiLIhw+LItehk9peAZGpmxeJ82dr/TYzVn6dUjrog9LR1lvywQu 7J8NDJ26ZK0fIS62c519y9eWR4YwTlthNM2ShhSZRZy9Mf86zriw/G3NN8rKsepzneBW IiL6V9POGZf+9ukZ9x7Hda2Y+qCPS/CTC0E7qCWfojmaz+GvQgiSK4V5iCKCuvQekbc4 f2iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="ZKOLTQ7/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y23-20020a63de57000000b0055c8fd5fe00si6864057pgi.886.2023.07.31.02.48.48; Mon, 31 Jul 2023 02:49:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="ZKOLTQ7/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232036AbjGaIj4 (ORCPT <rfc822;dengxinlin2429@gmail.com> + 99 others); Mon, 31 Jul 2023 04:39:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231496AbjGaIjR (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 31 Jul 2023 04:39:17 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3568C1B1; Mon, 31 Jul 2023 01:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=ttl1JAg1w0mUKTBhkaN+L9fgEa5IyTTOyMQJJhARt48=; b=ZKOLTQ7/+rcUK0EpU6hve6kJL6 wTqCJ2MolH4dNgL2RVKI9J/ebwyT2G4mWUm1VNsizEh2IZIqvgCkzkNR4q3KQfL8gqSN0D8CtSCv8 OZivql69XooHTy+GdS53nm32KE3hn30JsS3X+M9lHv/tCSYZeqbUpJFSWANl2MgqqBvPTdpnvhRSx igVxJcs5tXGObcUoBVBF/07eZFaecIo7p5HOrBWZgQfT3cqWRaZdoIcvEN9K6j7La0iSSTcOZ2zlw GWPzEuZIkcSiJryzCEG9hWLjYaEXtEq7FMwDpzplAnE0A2Nja4AQOwoVLzdORpQlSiLhLTVccJOCP Vra16I6A==; Received: from 2a02-8389-2341-5b80-39d3-4735-9a3c-88d8.cable.dynamic.v6.surfer.at ([2a02:8389:2341:5b80:39d3:4735:9a3c:88d8] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qQOQ3-00EYtG-2z; Mon, 31 Jul 2023 08:38:24 +0000 From: Christoph Hellwig <hch@lst.de> To: Luis Chamberlain <mcgrof@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Daniel Mack <daniel@zonque.org>, Haojian Zhuang <haojian.zhuang@gmail.com>, Robert Jarzmik <robert.jarzmik@free.fr>, Ulf Hansson <ulf.hansson@linaro.org>, Yangbo Lu <yangbo.lu@nxp.com>, Joshua Kinard <kumba@gentoo.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org (open list), linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org Subject: [PATCH 4/5] mmc: use EXPORT_SYMBOL_GPL for mmc_detect_change Date: Mon, 31 Jul 2023 10:38:05 +0200 Message-Id: <20230731083806.453036-5-hch@lst.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230731083806.453036-1-hch@lst.de> References: <20230731083806.453036-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772929094055886937 X-GMAIL-MSGID: 1772929094055886937 |
Series |
[1/5] ARM/pxa: use EXPORT_SYMBOL_GPL for sharpsl_battery_kick
|
|
Commit Message
Christoph Hellwig
July 31, 2023, 8:38 a.m. UTC
mmc_detect_change is used via symbol_get, which was only ever intended
for very internal symbols like this one. Use EXPORT_SYMBOL_GPL
for it so that symbol_get can enforce only being used on
EXPORT_SYMBOL_GPL symbols.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/mmc/core/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, Jul 31, 2023 at 10:38:05AM +0200, Christoph Hellwig wrote: > mmc_detect_change is used via symbol_get, which was only ever intended > for very internal symbols like this one. Use EXPORT_SYMBOL_GPL > for it so that symbol_get can enforce only being used on > EXPORT_SYMBOL_GPL symbols. Btw, I really wonder if this should actually be used through symbol_get. It seems like the MIPS/alchemy boards should simply require MMC to be built in and not modular, or the IRQ handlers should move into a driver. That would be a much less mechanical change, but this use really looks a bit odd. And makes me wonder if we should only allow symbol_get on symbols specifically marked to supported it, but that would be another incremental step.
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 3d3e0ca5261481..8ffd78fae1e7b9 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -1433,7 +1433,7 @@ void mmc_detect_change(struct mmc_host *host, unsigned long delay) { _mmc_detect_change(host, delay, true); } -EXPORT_SYMBOL(mmc_detect_change); +EXPORT_SYMBOL_GPL(mmc_detect_change); void mmc_init_erase(struct mmc_card *card) {