Message ID | 20230731083806.453036-2-hch@lst.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp1902347vqg; Mon, 31 Jul 2023 02:48:17 -0700 (PDT) X-Google-Smtp-Source: APBJJlGAFzHc0TK318QSHYczmyjgrySbX479zfS697oXxjo96FSHJgSQywCrryW6/ds64rn1ArOH X-Received: by 2002:a17:903:2450:b0:1b7:e49f:1d with SMTP id l16-20020a170903245000b001b7e49f001dmr9660898pls.62.1690796897548; Mon, 31 Jul 2023 02:48:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690796897; cv=none; d=google.com; s=arc-20160816; b=q5hTNTuAJhCD36JnJV+uLcH7qi7dcZJdvFXGgBYzVedbdAsCNh4LV2jN3Wo6X6wjLZ 25VO4wWy/1Fop7WR5UJN2oItnqQzKfxTgBJ3VfqAGvSteQ6MHZZodVOJPQJiLzB3vh+g LOI+Tyt8SXyJHPni8FZq7o6xAnqFmSFstu/BS1l+6kKbUIBXZYO5iHqZwNQThlGavCC8 2ddgj53HmjmKYL+oKENaZVLfKVHP2nOhY/MoY2H6HowDFDA7Zn71gMWVvCb+9HbBgY/Q QQH0l5JNEIeDL4emGs8bhylDi+c8ZaJiaHlS83JPH+KlNRnQWOdBzRdFkjBcDfM1N/x6 qm8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NogRc+PV5Ggqg3zuB9ufDe2OOc/ycxdytdzIcHbUmmE=; fh=Jf3M7ygXb8W1KLUVtb0UJCFyg9JtKT8TxO5XgFASIj0=; b=JjlpeQ1QOBsV0OKSWZfpidBYuq41a4rJs5gnUFVtDzYA4cF9kQ6E9zoR8rPA82Dq6g 1EUIKmBIHkHDEMV0AQ3a9fzrzzlDDYrrhSKd8SgMsHyafpd01dDMQTmauoVMDsf0OPPR baGC2KfLxZWQ835QHSwe3wUGmFpe/dhYaZxq/I/Ajowtg6hsP1wfCpesRcr/Gt6ukyF7 d85lEEa8QGK7Hp+35yTf+iIbDOH/G4UGp5Vj9OQUSMPIPSEIPAxmnfGsz6ynKzRKYGQz RcXVajqqE8nU6Nz2Xi+CHAofq6GeymC9YPPsN0zPqOVDXwIJwyoVmbNrmqI/1NWVi5ri UEEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=LnBJRrWL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q5-20020a170902dac500b001b8ae5d825bsi7253153plx.612.2023.07.31.02.48.04; Mon, 31 Jul 2023 02:48:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=LnBJRrWL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232034AbjGaIjb (ORCPT <rfc822;maxi.paulin@gmail.com> + 99 others); Mon, 31 Jul 2023 04:39:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232023AbjGaIjA (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 31 Jul 2023 04:39:00 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D4ACE5B; Mon, 31 Jul 2023 01:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=NogRc+PV5Ggqg3zuB9ufDe2OOc/ycxdytdzIcHbUmmE=; b=LnBJRrWLCidFZOfw/o0WLM6JbO a5PqWi1N1j5x3vvveGCItTRyv+xxUvBqQcPc44Y4kGy0bFdMyxp2Nc4ZsbNhzBa0ijkoTFO5NJga9 1QwdoNnOQO8JKPHZ7ATsJSdpMrnl7629LUiyiWPdrI6/UVssAOYdRi/Ncg2FbkF4+t/aiCgLWIYzS W9x2f6EVNUpU/iuvwos6YmYMdJmRcdi5Ov3Kc7aa55xLGItypOxn7JPt1sCxoxknytEEbkW3ZQTt8 2YudLQf4mgBxSPBjoWnNGKIIiuBkeE698M9f3Qw5xIYicWrIQJF1amInOj3GDbUE2//dGJT7eA2KY clnLosvA==; Received: from 2a02-8389-2341-5b80-39d3-4735-9a3c-88d8.cable.dynamic.v6.surfer.at ([2a02:8389:2341:5b80:39d3:4735:9a3c:88d8] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qQOPt-00EYrF-2B; Mon, 31 Jul 2023 08:38:14 +0000 From: Christoph Hellwig <hch@lst.de> To: Luis Chamberlain <mcgrof@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Daniel Mack <daniel@zonque.org>, Haojian Zhuang <haojian.zhuang@gmail.com>, Robert Jarzmik <robert.jarzmik@free.fr>, Ulf Hansson <ulf.hansson@linaro.org>, Yangbo Lu <yangbo.lu@nxp.com>, Joshua Kinard <kumba@gentoo.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org (open list), linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org Subject: [PATCH 1/5] ARM/pxa: use EXPORT_SYMBOL_GPL for sharpsl_battery_kick Date: Mon, 31 Jul 2023 10:38:02 +0200 Message-Id: <20230731083806.453036-2-hch@lst.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230731083806.453036-1-hch@lst.de> References: <20230731083806.453036-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772929047749838650 X-GMAIL-MSGID: 1772929047749838650 |
Series |
[1/5] ARM/pxa: use EXPORT_SYMBOL_GPL for sharpsl_battery_kick
|
|
Commit Message
Christoph Hellwig
July 31, 2023, 8:38 a.m. UTC
sharpsl_battery_kick is only used via symbol_get, which was only ever
intended for very internal symbols like this one. Use EXPORT_SYMBOL_GPL
for it so that symbol_get can enforce only being used on
EXPORT_SYMBOL_GPL symbols.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
arch/arm/mach-pxa/sharpsl_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, Jul 31, 2023, at 10:38, Christoph Hellwig wrote: > sharpsl_battery_kick is only used via symbol_get, which was only ever > intended for very internal symbols like this one. Use EXPORT_SYMBOL_GPL > for it so that symbol_get can enforce only being used on > EXPORT_SYMBOL_GPL symbols. > > Signed-off-by: Christoph Hellwig <hch@lst.de> The reasoning makes sense, and the patch looks good, so feel free to take this through your tree. Acked-by: Arnd Bergmann <arnd@arndb.de> Or let me know if you want a better fix. Since sharpsl_pm.c and spitz.c are no longer loadable modules and just get linked together these days, I think the variant below would be simpler (this could be cleanup up further, endlessly, of course): --- a/arch/arm/mach-pxa/spitz.c +++ b/arch/arm/mach-pxa/spitz.c @@ -518,17 +518,6 @@ static struct gpiod_lookup_table spitz_ads7846_gpio_table = { }, }; -static void spitz_bl_kick_battery(void) -{ - void (*kick_batt)(void); - - kick_batt = symbol_get(sharpsl_battery_kick); - if (kick_batt) { - kick_batt(); - symbol_put(sharpsl_battery_kick); - } -} - static struct gpiod_lookup_table spitz_lcdcon_gpio_table = { .dev_id = "spi2.1", .table = { @@ -556,7 +545,7 @@ static struct corgi_lcd_platform_data spitz_lcdcon_info = { .max_intensity = 0x2f, .default_intensity = 0x1f, .limit_mask = 0x0b, - .kick_battery = spitz_bl_kick_battery, + .kick_battery = sharpsl_battery_kick, }; static struct spi_board_info spitz_spi_devices[] = {
On Mon, Jul 31, 2023 at 06:12:22PM +0200, Arnd Bergmann wrote: > Or let me know if you want a better fix. Since sharpsl_pm.c and > spitz.c are no longer loadable modules and just get linked together > these days, I think the variant below would be simpler (this could > be cleanup up further, endlessly, of course): That actually looks way nicer, thanks! If you give me a singoff I'll add it to the next version.
diff --git a/arch/arm/mach-pxa/sharpsl_pm.c b/arch/arm/mach-pxa/sharpsl_pm.c index d29bdcd5270e0f..08eec58632c988 100644 --- a/arch/arm/mach-pxa/sharpsl_pm.c +++ b/arch/arm/mach-pxa/sharpsl_pm.c @@ -216,7 +216,7 @@ void sharpsl_battery_kick(void) { schedule_delayed_work(&sharpsl_bat, msecs_to_jiffies(125)); } -EXPORT_SYMBOL(sharpsl_battery_kick); +EXPORT_SYMBOL_GPL(sharpsl_battery_kick); static void sharpsl_battery_thread(struct work_struct *private_)