| Message ID | 20230731073613.10394-5-clamor95@gmail.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp1883508vqg;
Mon, 31 Jul 2023 01:58:57 -0700 (PDT)
X-Google-Smtp-Source:
APBJJlE2pCHGMEKX98L8Hq32gFAf7milQ+Dg5LgxnrJpRbFlN7mQQy2LHO5h6U0aycvNrIFYfFc1
X-Received: by 2002:a05:6a21:7889:b0:117:3c00:77ea with SMTP id
bf9-20020a056a21788900b001173c0077eamr11573777pzc.0.1690793937019;
Mon, 31 Jul 2023 01:58:57 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1690793937; cv=none;
d=google.com; s=arc-20160816;
b=qzAcTilIDtG6DoBKFK+Ceh1EUuxoOOTDWGRPhUWH8/nhrT5V8hwQhHt3y4Y73f9uvb
nQ8kkJ9AYBg3qx/75ME41EF2VSx803sWuKAaxpj7Hf2dhcrvzK7zp/3g34gt6Xxde4NT
KklXL8GMEP8PuVNa/Tr9QWvHcFSoHJtc26doyoYJpjBu0Iz8BXfpEFmNbFD5HJilt7u8
FG8V7gAxIZs+X8WO5oD5pTooGb/n9G/hh7X15qSjD1pv+JpAn6ocwL5Xu+qd+eq/4cvr
HLBOQSJG1huqi8Ky7S7C5eF7bKTGS6idaY0zxpH2beZkc4dV1UNRItTFPzXe0AvwT0Pf
56HQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=6j0RW75STEI+5ZneQ+EaoJsYheY8+d1jwea7sk4EPgA=;
fh=BYYxYocqtJiC/MlqHuXF0UZXhvoN/4a0Xtp0KZwYhQ0=;
b=KZfckRUEHvaQSrjtOtrl1TPl0kuxECJ3BrVSCp6emVB5Xo6UcIfqKc4Y/xALzeR69L
Zr8SNUGTx4nVNb7ik+7ITQMzI3PVEecGhOSTFBC8rS3HpvnmMAPzppmhtHDpxgaQpJ8r
q22ZlwxTc+xPCROwiGjyJ0rbKdhZZ1lo12UgrD9A8sIdn+d981uCZ/Bq+sYcLNDvSDGR
XSX6yi3HcpiIOLTdDnDyPVF52bTxySdCl4ttNGK3ggvjoTuAM6K+i9cYzz4nQfYlqb9D
3xzAC2woYMdB/pgdjHTo3nsWjLVH0p5281z387NuQRMDc+f+NuXMHMG0YyGX9ISwTsoL
nRVw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@gmail.com header.s=20221208 header.b="T/MFohop";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
cw23-20020a056a00451700b006824e0fdcb0si3449366pfb.98.2023.07.31.01.58.44;
Mon, 31 Jul 2023 01:58:56 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@gmail.com header.s=20221208 header.b="T/MFohop";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229962AbjGaHhM (ORCPT <rfc822;dengxinlin2429@gmail.com>
+ 99 others); Mon, 31 Jul 2023 03:37:12 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44546 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229813AbjGaHgt (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 31 Jul 2023 03:36:49 -0400
Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com
[IPv6:2a00:1450:4864:20::12a])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A259EE;
Mon, 31 Jul 2023 00:36:48 -0700 (PDT)
Received: by mail-lf1-x12a.google.com with SMTP id
2adb3069b0e04-4fe0e34f498so6319506e87.2;
Mon, 31 Jul 2023 00:36:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1690789006; x=1691393806;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=6j0RW75STEI+5ZneQ+EaoJsYheY8+d1jwea7sk4EPgA=;
b=T/MFohopS/BeXcEOIKcI+cKbio9xHJw754uW1T4iafV4Cpc+VMjI32RZqanKyS0c3u
ClVlopqABlN0fqoAfTJQ1PEq2enBvzqMS1t65L3ynFlWX6m7Sq2zHmP0XKqYL/rEtfw8
DgZV22HlJaGMpLTaP9J+NixAUS71c+zIIQZ6o/8q/Cfdw1jPi1TAusj14G50cQHwGxcE
C8NgkGO3B1UUKEMSgrPrL4wLGz43APbpoLnUIKnSbs4Uz0eVw5CU91pz7c5JnFMscf6B
5ZUrxnGap4NaiA5LuXs+0koOCjymRdigu1CsB4Kg/AHFVaSpftWmMQ504YBe4WpnuuiU
sHOA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1690789006; x=1691393806;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=6j0RW75STEI+5ZneQ+EaoJsYheY8+d1jwea7sk4EPgA=;
b=b5RX22qso+PF+kbtNK7KlW/f2wIj+2J978XV8Dx4+2rMgkNrl759oDU2PU8fi6LXWq
0J3Qx/Rgjrxl58hFeMuh0/BcYhEHh7zSYtqE/Zn9V/RfNsxKRtdgeTAd+Ob9zpW8B14J
KAG55c9uUuUjYXuTN2dYA4W7QlF/HbrcGuR+ROXpOoP2rtpgfmveBP3f3FxrwjTGP4mn
M+H09ri9zywRLyonz6yE0ogLUpLflkjTbRV+qgdtTS51JytJUsy0sTxeoiIYFPkePZQc
XmMGEfkahK1MURX5/Ur7gy+BQMGctJ/qCty3Xofze6C/dmM1la9yW6uUC+QcPl0MxHlx
ztmA==
X-Gm-Message-State: ABy/qLYlF1wuJsX3yM6eXYJL+ADu6dL99Nr1sCpBVeiqIVA+y/ufK6Mn
OAzMP0PIOlhsYe6rQXtHtW1Pfs6rdvmI8A==
X-Received: by 2002:ac2:5df3:0:b0:4fb:89b3:3373 with SMTP id
z19-20020ac25df3000000b004fb89b33373mr4822337lfq.43.1690789006542;
Mon, 31 Jul 2023 00:36:46 -0700 (PDT)
Received: from xeon.. ([188.163.112.48])
by smtp.gmail.com with ESMTPSA id
m14-20020a056512014e00b004fe3229e584sm586898lfo.270.2023.07.31.00.36.45
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 31 Jul 2023 00:36:46 -0700 (PDT)
From: Svyatoslav Ryhel <clamor95@gmail.com>
To: Iskren Chernev <me@iskren.info>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Matheus Castello <matheus@castello.eng.br>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Alim Akhtar <alim.akhtar@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Svyatoslav Ryhel <clamor95@gmail.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Stefan Hansson <newbie13xd@gmail.com>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH v3 4/4] ARM: configs: s5pv210_defconfig: enable IIO required
by MAX17040
Date: Mon, 31 Jul 2023 10:36:13 +0300
Message-Id: <20230731073613.10394-5-clamor95@gmail.com>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20230731073613.10394-1-clamor95@gmail.com>
References: <20230731073613.10394-1-clamor95@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,
FREEMAIL_FROM,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,
T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1772925943396007461
X-GMAIL-MSGID: 1772925943396007461
|
| Series |
Add optional properties to MAX17040
|
|
Commit Message
Svyatoslav Ryhel
July 31, 2023, 7:36 a.m. UTC
After adding support for passing temperature data from thermal sensor
to MAX17040 it got dependency on CONFIG_IIO. From all defconfigs
using MAX17040 only s5pv210_defconfig did not have IIO already enabled
so let's enable it to avoid regression.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
arch/arm/configs/s5pv210_defconfig | 1 +
1 file changed, 1 insertion(+)
Comments
Hi Svyatoslav, On Mon, Jul 31, 2023 at 10:36:13AM +0300, Svyatoslav Ryhel wrote: > After adding support for passing temperature data from thermal sensor > to MAX17040 it got dependency on CONFIG_IIO. From all defconfigs > using MAX17040 only s5pv210_defconfig did not have IIO already enabled > so let's enable it to avoid regression. > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > --- > arch/arm/configs/s5pv210_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/s5pv210_defconfig b/arch/arm/configs/s5pv210_defconfig > index 4c1e480b5bbd..24070ee3d43e 100644 > --- a/arch/arm/configs/s5pv210_defconfig > +++ b/arch/arm/configs/s5pv210_defconfig > @@ -97,6 +97,7 @@ CONFIG_MMC_SDHCI_S3C_DMA=y > CONFIG_RTC_CLASS=y > CONFIG_RTC_DRV_MAX8998=m > CONFIG_DMADEVICES=y > +CONFIG_IIO=y > CONFIG_PWM=y > CONFIG_PWM_SAMSUNG=y > CONFIG_PHY_SAMSUNG_USB2=m Should this patch be squashed to the previous patch? I think you break bisectability for this board if you enable iio only here. Andi
On 06/08/2023 00:42, Andi Shyti wrote: > Hi Svyatoslav, > > On Mon, Jul 31, 2023 at 10:36:13AM +0300, Svyatoslav Ryhel wrote: >> After adding support for passing temperature data from thermal sensor >> to MAX17040 it got dependency on CONFIG_IIO. From all defconfigs >> using MAX17040 only s5pv210_defconfig did not have IIO already enabled >> so let's enable it to avoid regression. >> >> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> >> --- >> arch/arm/configs/s5pv210_defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/configs/s5pv210_defconfig b/arch/arm/configs/s5pv210_defconfig >> index 4c1e480b5bbd..24070ee3d43e 100644 >> --- a/arch/arm/configs/s5pv210_defconfig >> +++ b/arch/arm/configs/s5pv210_defconfig >> @@ -97,6 +97,7 @@ CONFIG_MMC_SDHCI_S3C_DMA=y >> CONFIG_RTC_CLASS=y >> CONFIG_RTC_DRV_MAX8998=m >> CONFIG_DMADEVICES=y >> +CONFIG_IIO=y >> CONFIG_PWM=y >> CONFIG_PWM_SAMSUNG=y >> CONFIG_PHY_SAMSUNG_USB2=m > > Should this patch be squashed to the previous patch? I think you > break bisectability for this board if you enable iio only here. The defconfig change matters less - distros don't use them - so this points to the fact that patchset affected the users. All existing users of max17040 drivers, who do not enable IIO, will have their setups broken. Best regards, Krzysztof
Hi, On Sun, Aug 06, 2023 at 10:29:04AM +0200, Krzysztof Kozlowski wrote: > On 06/08/2023 00:42, Andi Shyti wrote: > > Hi Svyatoslav, > > > > On Mon, Jul 31, 2023 at 10:36:13AM +0300, Svyatoslav Ryhel wrote: > >> After adding support for passing temperature data from thermal sensor > >> to MAX17040 it got dependency on CONFIG_IIO. From all defconfigs > >> using MAX17040 only s5pv210_defconfig did not have IIO already enabled > >> so let's enable it to avoid regression. > >> > >> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > >> --- > >> arch/arm/configs/s5pv210_defconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm/configs/s5pv210_defconfig b/arch/arm/configs/s5pv210_defconfig > >> index 4c1e480b5bbd..24070ee3d43e 100644 > >> --- a/arch/arm/configs/s5pv210_defconfig > >> +++ b/arch/arm/configs/s5pv210_defconfig > >> @@ -97,6 +97,7 @@ CONFIG_MMC_SDHCI_S3C_DMA=y > >> CONFIG_RTC_CLASS=y > >> CONFIG_RTC_DRV_MAX8998=m > >> CONFIG_DMADEVICES=y > >> +CONFIG_IIO=y > >> CONFIG_PWM=y > >> CONFIG_PWM_SAMSUNG=y > >> CONFIG_PHY_SAMSUNG_USB2=m > > > > Should this patch be squashed to the previous patch? I think you > > break bisectability for this board if you enable iio only here. > > The defconfig change matters less - distros don't use them - so this > points to the fact that patchset affected the users. All existing users > of max17040 drivers, who do not enable IIO, will have their setups broken. That's why I'm suggesting to squash this patch with the previous. Anyway, up to you... except of this note everything looks fine in the series. Andi
On 07/08/2023 10:55, Andi Shyti wrote: > Hi, > > On Sun, Aug 06, 2023 at 10:29:04AM +0200, Krzysztof Kozlowski wrote: >> On 06/08/2023 00:42, Andi Shyti wrote: >>> Hi Svyatoslav, >>> >>> On Mon, Jul 31, 2023 at 10:36:13AM +0300, Svyatoslav Ryhel wrote: >>>> After adding support for passing temperature data from thermal sensor >>>> to MAX17040 it got dependency on CONFIG_IIO. From all defconfigs >>>> using MAX17040 only s5pv210_defconfig did not have IIO already enabled >>>> so let's enable it to avoid regression. >>>> >>>> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> >>>> --- >>>> arch/arm/configs/s5pv210_defconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/arch/arm/configs/s5pv210_defconfig b/arch/arm/configs/s5pv210_defconfig >>>> index 4c1e480b5bbd..24070ee3d43e 100644 >>>> --- a/arch/arm/configs/s5pv210_defconfig >>>> +++ b/arch/arm/configs/s5pv210_defconfig >>>> @@ -97,6 +97,7 @@ CONFIG_MMC_SDHCI_S3C_DMA=y >>>> CONFIG_RTC_CLASS=y >>>> CONFIG_RTC_DRV_MAX8998=m >>>> CONFIG_DMADEVICES=y >>>> +CONFIG_IIO=y >>>> CONFIG_PWM=y >>>> CONFIG_PWM_SAMSUNG=y >>>> CONFIG_PHY_SAMSUNG_USB2=m >>> >>> Should this patch be squashed to the previous patch? I think you >>> break bisectability for this board if you enable iio only here. >> >> The defconfig change matters less - distros don't use them - so this >> points to the fact that patchset affected the users. All existing users >> of max17040 drivers, who do not enable IIO, will have their setups broken. > > That's why I'm suggesting to squash this patch with the previous. It would not solve much. All existing users will be still broken. > > Anyway, up to you... except of this note everything looks fine in > the series. I would actually prefer not to depend on IIO, but this would require stubs for missing IIO functions. Best regards, Krzysztof
diff --git a/arch/arm/configs/s5pv210_defconfig b/arch/arm/configs/s5pv210_defconfig index 4c1e480b5bbd..24070ee3d43e 100644 --- a/arch/arm/configs/s5pv210_defconfig +++ b/arch/arm/configs/s5pv210_defconfig @@ -97,6 +97,7 @@ CONFIG_MMC_SDHCI_S3C_DMA=y CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_MAX8998=m CONFIG_DMADEVICES=y +CONFIG_IIO=y CONFIG_PWM=y CONFIG_PWM_SAMSUNG=y CONFIG_PHY_SAMSUNG_USB2=m