From patchwork Sun Jul 30 21:57:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 128310 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp1743184vqg; Sun, 30 Jul 2023 18:36:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlFQY7xBJUrnwtYiluflgOkYnmpXPyvIasyDc62ZRLFbQBvE7rfynx/MKDL6HvsFirVDA89G X-Received: by 2002:a17:902:f547:b0:1b8:6987:de84 with SMTP id h7-20020a170902f54700b001b86987de84mr9970587plf.48.1690767362639; Sun, 30 Jul 2023 18:36:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690767362; cv=none; d=google.com; s=arc-20160816; b=LRbH/yoc3cx7gIyWjUTb7vdWvS6cjlWT1xYzXej1uZm5q5G4M6uKJ0Kh59NKobcSVb XDRl/tkxSNDnX1nfRO0MW5W2Njl5uCk4h2EsAc6tsgcv22BXFltsWKiFNwyOkDoW/OOf s4/MaoPkoXwE3R3YdibQbF0qCs5KZvLsm91i7g34t10/jniBWaSlOhY7FIqatXtJSm44 VsWH2bexO2u8fC52dFiZhQ7/15s7cU1GT+lxTo1mlQYjDniO0QagmN2UzI8krOaAhhDm Vuw5DZGPHWixoocYCyjtgNvE1u/4vJvepubxvSw2Tq3EpxJoN52RIB5x1YdBuagsmcOI oVtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=emw84RlF3bNbcIqSZRMxOIrvwHQ8jc+o13j5yyfv6Es=; fh=V7Gv//DT1ExUcHx/AfKbw/yPQtf2eE3NARpQwlGP93A=; b=VA6YPfbIpR053E0eVZqeoXLp2empmauPfcd58VJNkFrTN9snYVpQQO4ydjPEG+ZrSL 1R8xF4vHxuEvDOiZ4v/xT1sDHx6YJYTSkrAno6BYvUSGzbT7o5dNoeahQaMG1hCfPLRz u6H/Q3qNP1Pk72cBdbbs0ly24diR+7vVR9fc5kTFNPWIgJ/yGtuGqaXHhAwdpk5RaZ4L iUMM5+zVgqu22c/KYJgbdjmaVid/4FoG9cp9pSFXFmPDMCk3264Y3l/pmCHOotiWwLBc I9PLna56PW6rN1Ef/UM6GytU/igKeWZI2+WdqNVaSYP4czxlAhES38wIsX7/evLI+t8T 2Gmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=XzBrK3fi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x17-20020a1709027c1100b001b89fd6bec4si6306411pll.144.2023.07.30.18.35.49; Sun, 30 Jul 2023 18:36:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=XzBrK3fi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229780AbjG3V6R (ORCPT + 99 others); Sun, 30 Jul 2023 17:58:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbjG3V6P (ORCPT ); Sun, 30 Jul 2023 17:58:15 -0400 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71052BB for ; Sun, 30 Jul 2023 14:58:14 -0700 (PDT) Received: by mail-il1-x136.google.com with SMTP id e9e14a558f8ab-3490a1f8ba4so6246815ab.3 for ; Sun, 30 Jul 2023 14:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690754294; x=1691359094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=emw84RlF3bNbcIqSZRMxOIrvwHQ8jc+o13j5yyfv6Es=; b=XzBrK3fiUVV+Qw4FCBmhAFwh1M0BxMpb4QGOJCxG7oDqhsffTtg/qFqxOVRqkaqopU MLw7n8YGvbNiZ6khvhNn+Jt/Z3E+WMCbucPJv2IQ4lolvyur+F5jlnJarCaSME/UkEku 9F6Ja5BmoEkjw3Wr2+chJjJaBE+ONMPflSSvi2Tl+Gqmb2+wSbGpHDqUbJUPKdMr4rdh 5qBAI6BIgkp+++m+RHQShsg9LkzNA2p44oaJDMiOGM8bkXK6SO7+lWEEo2a/ncPoyRfX XB9cWkYe2V2JmnCJ5S5jV0DVJLrbsFyJVNuO4xx2K88BM0faTo0inK4m4XzVUR4czgsv rykQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690754294; x=1691359094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=emw84RlF3bNbcIqSZRMxOIrvwHQ8jc+o13j5yyfv6Es=; b=PpK3hBCYwN8l9Vb+Nc7EkBTLUklLlms8x7/HDFluPFx/WCu2nlk53SFRIjthW2mqk6 yo9M7vcVe2EV/sBW0Om3BTjfjV0KxBPQqAWNheJ10F6vXMz21pWBJ2/8K1HwfA5jJQ6z ib0qpvgPZNnBLR0+Lg4UQaEDPfw2RbKfz6ws3OfKpYYTrsKUvxlUBDqnjepkdwDWmcfV h3c44P5iN/nY2rOXJCqYoD8jIcqIlZlCXhQubrwRebq/foLrd00alMDw6oOoP/Ur3v1M odgUkG1y/DqhjO1EpTIUZxhbX3hR1GRywAg9jhXOhKikMvWNqbQV7zhnpjGyHksLCqUY 0S9w== X-Gm-Message-State: ABy/qLYz2uGqJzu3qxvxPRcy7ONcCxVjD2LZ350CFY9cn0R03tnwWgti 7cJ9RCuVW3NjL7ZAcCCV2/A= X-Received: by 2002:a05:6e02:931:b0:348:c57f:b016 with SMTP id o17-20020a056e02093100b00348c57fb016mr5734702ilt.3.1690754293582; Sun, 30 Jul 2023 14:58:13 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id e18-20020a92de52000000b003424b3d6d37sm2747520ilr.24.2023.07.30.14.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jul 2023 14:58:13 -0700 (PDT) From: Jim Cromie To: daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Jim Cromie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Anitha Chrisanthus , Edmund Dea Subject: [PATCH 1/5] drm_dbg: add trailing newlines to remaining callsites Date: Sun, 30 Jul 2023 15:57:50 -0600 Message-ID: <20230730215758.54010-2-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230730215758.54010-1-jim.cromie@gmail.com> References: <20230730215758.54010-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772898078276199386 X-GMAIL-MSGID: 1772898078276199386 All callers should uniformly include a trailing newline, the vast majority already do: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in this and next commits (split for easy acks). No functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/kmb/kmb_crtc.c | 10 +++++----- drivers/gpu/drm/kmb/kmb_plane.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crtc.c index 647872f65bff..a58baf25322d 100644 --- a/drivers/gpu/drm/kmb/kmb_crtc.c +++ b/drivers/gpu/drm/kmb/kmb_crtc.c @@ -94,7 +94,7 @@ static void kmb_crtc_set_mode(struct drm_crtc *crtc, vm.hback_porch = 0; vm.hsync_len = 28; - drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d h-active=%d h-bp=%d h-fp=%d hsync-l=%d", + drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d h-active=%d h-bp=%d h-fp=%d hsync-l=%d\n", __func__, __LINE__, m->crtc_vdisplay, vm.vback_porch, vm.vfront_porch, vm.vsync_len, m->crtc_hdisplay, vm.hback_porch, @@ -194,24 +194,24 @@ static enum drm_mode_status int vfp = mode->vsync_start - mode->vdisplay; if (mode->vdisplay < KMB_CRTC_MAX_HEIGHT) { - drm_dbg(dev, "height = %d less than %d", + drm_dbg(dev, "height = %d less than %d\n", mode->vdisplay, KMB_CRTC_MAX_HEIGHT); return MODE_BAD_VVALUE; } if (mode->hdisplay < KMB_CRTC_MAX_WIDTH) { - drm_dbg(dev, "width = %d less than %d", + drm_dbg(dev, "width = %d less than %d\n", mode->hdisplay, KMB_CRTC_MAX_WIDTH); return MODE_BAD_HVALUE; } refresh = drm_mode_vrefresh(mode); if (refresh < KMB_MIN_VREFRESH || refresh > KMB_MAX_VREFRESH) { - drm_dbg(dev, "refresh = %d less than %d or greater than %d", + drm_dbg(dev, "refresh = %d less than %d or greater than %d\n", refresh, KMB_MIN_VREFRESH, KMB_MAX_VREFRESH); return MODE_BAD; } if (vfp < KMB_CRTC_MIN_VFP) { - drm_dbg(dev, "vfp = %d less than %d", vfp, KMB_CRTC_MIN_VFP); + drm_dbg(dev, "vfp = %d less than %d\n", vfp, KMB_CRTC_MIN_VFP); return MODE_BAD; } diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plane.c index 9e0562aa2bcb..308bd1cb50c8 100644 --- a/drivers/gpu/drm/kmb/kmb_plane.c +++ b/drivers/gpu/drm/kmb/kmb_plane.c @@ -78,7 +78,7 @@ static unsigned int check_pixel_format(struct drm_plane *plane, u32 format) * plane configuration is not supported. */ if (init_disp_cfg.format && init_disp_cfg.format != format) { - drm_dbg(&kmb->drm, "Cannot change format after initial plane configuration"); + drm_dbg(&kmb->drm, "Cannot change format after initial plane configuration\n"); return -EINVAL; } for (i = 0; i < plane->format_count; i++) { @@ -124,7 +124,7 @@ static int kmb_plane_atomic_check(struct drm_plane *plane, if ((init_disp_cfg.width && init_disp_cfg.height) && (init_disp_cfg.width != fb->width || init_disp_cfg.height != fb->height)) { - drm_dbg(&kmb->drm, "Cannot change plane height or width after initial configuration"); + drm_dbg(&kmb->drm, "Cannot change plane height or width after initial configuration\n"); return -EINVAL; } can_position = (plane->type == DRM_PLANE_TYPE_OVERLAY); @@ -375,7 +375,7 @@ static void kmb_plane_atomic_update(struct drm_plane *plane, spin_lock_irq(&kmb->irq_lock); if (kmb->kmb_under_flow || kmb->kmb_flush_done) { spin_unlock_irq(&kmb->irq_lock); - drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning"); + drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning\n"); return; } spin_unlock_irq(&kmb->irq_lock);