Message ID | 20230730142552.3918623-1-chao@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp1546544vqg; Sun, 30 Jul 2023 08:12:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlH6u34cx7nl/DGYMBS2UT5VCab8JqK1IceHgQL62K63cWuC7fP+jBfiCp4LDHuEtPTZsgO6 X-Received: by 2002:a05:6a20:9192:b0:133:6219:15e2 with SMTP id v18-20020a056a20919200b00133621915e2mr9362798pzd.21.1690729963098; Sun, 30 Jul 2023 08:12:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690729963; cv=none; d=google.com; s=arc-20160816; b=Stsyh9kTeIzVJxSp+ATx1I5HLAuHFFRyH+DoZD4XI/5lAb9245PwcJDp0xcpBpxQpN YbDh/nIn/sf2/6rc4XwbIZjWLQicIhmlzJZpH+Dtcq0opOTlYjYpIWuBciNcavJDQVSG K37KhGZGdz1U13u3rNojWuz5LG86TDGx1K2quQ/unTw/aYh5quZukOvfA+flneYqfwTa X2yKbhgs7q1hgenkPHiAEOCysXZ+WuWH0+dsTcpxuR/V+oqgbiVgViIlFrgO10BTUsi7 b6dQwjM9Szs3N0NnbYVJ7X1u3KXXsmG20a7BurxDR5+hpjS3sS6iPeEVkmD/vGlwa44J OrBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=YbMBmeWMEOJmsklkaGJnWiQaOCUvKxP8nHbvTZhok64=; fh=5/tJX5opFV5w1frY3pTlI79vDLVOntPbYwD9w+dLvhs=; b=uMx7GYr9jWODMptwnv5NBXewHoRoU+iGaIYzx/I0Qut58oOek0BMsw6A0CB8PLnUQg 3VfRJ0ZkPhMQDKSIgacGJfM3xV0q3V+BuFnIjMc29GWb/kNnD/6KjmldlYdYq4oL9oHD XDJsf/9YZP+P3uGiBAtoPSyZhCcVd0CNXEyqhWxICdXNIeh7ewm4XsLZsffGCL0OyPV7 wxl/h68nT9u18woumKAO4zAb6Us2rqs2whKwzUKzfa9LYTeVfO56eNwk7C79Q1mqSkGM lBwmlGmgfDqX/fChXfv4Gpo8fps5C6zVXcrGOS8bnJ9NX4fqU1dJtnSxsy7/o21i0Ie8 9M4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r9uankZ7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r20-20020a6560d4000000b00564333541aasi1867576pgv.1.2023.07.30.08.12.29; Sun, 30 Jul 2023 08:12:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r9uankZ7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbjG3O0C (ORCPT <rfc822;dengxinlin2429@gmail.com> + 99 others); Sun, 30 Jul 2023 10:26:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjG3O0A (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 30 Jul 2023 10:26:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A54A7199 for <linux-kernel@vger.kernel.org>; Sun, 30 Jul 2023 07:25:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4055D60B66 for <linux-kernel@vger.kernel.org>; Sun, 30 Jul 2023 14:25:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66557C433C8; Sun, 30 Jul 2023 14:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690727158; bh=d8GF2nj75dcAK/W9xm27IQOlnskgBpm9dOo8ZbtueO0=; h=From:To:Cc:Subject:Date:From; b=r9uankZ7WV2NH7kxQVR4E7GJxfRrmfeRRSEqY/T7MMQISryAIPzyvqDkEa2xmTo4J ikfUr1rRYoSiu5NxCTcB/TRvOPB9i+m4A0hlZ226R4O7WWkzseocgfREbAGn+sj8UL yMW3+YJv2BfVCROnAZZ9HYJ8GS1v4Db3VKEN7xunZBJ0ekWRgqX+/YW4VdhyZzl+PM A0jx57OnYvlrBMHubevOAIUOfKRDBu8OqKyLr056BOsw5ECuHdU1kfRp0a+UbUfyUs TGrE07RgEul+Bc3Y8IldPVdY/imRuPEtyKmu7DbnQfjXEGltpByd+Fid+67Se+X1m5 S4o6UGtMR43Wg== From: Chao Yu <chao@kernel.org> To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu <chao@kernel.org> Subject: [PATCH 1/2] f2fs: doc: fix description of max_small_discards Date: Sun, 30 Jul 2023 22:25:51 +0800 Message-Id: <20230730142552.3918623-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772858861932621951 X-GMAIL-MSGID: 1772858861932621951 |
Series |
[1/2] f2fs: doc: fix description of max_small_discards
|
|
Commit Message
Chao Yu
July 30, 2023, 2:25 p.m. UTC
The description of max_small_discards is out-of-update in below two
aspects, fix it.
- it is disabled by default
- small discards will be issued during checkpoint
Signed-off-by: Chao Yu <chao@kernel.org>
---
Documentation/ABI/testing/sysfs-fs-f2fs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
Ping, On 2023/7/30 22:25, Chao Yu wrote: > The description of max_small_discards is out-of-update in below two > aspects, fix it. > - it is disabled by default > - small discards will be issued during checkpoint > > Signed-off-by: Chao Yu <chao@kernel.org> > --- > Documentation/ABI/testing/sysfs-fs-f2fs | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs > index ad3d76d37c8b..36c3cb547901 100644 > --- a/Documentation/ABI/testing/sysfs-fs-f2fs > +++ b/Documentation/ABI/testing/sysfs-fs-f2fs > @@ -102,9 +102,9 @@ What: /sys/fs/f2fs/<disk>/max_small_discards > Date: November 2013 > Contact: "Jaegeuk Kim" <jaegeuk.kim@samsung.com> > Description: Controls the issue rate of discard commands that consist of small > - blocks less than 2MB. The candidates to be discarded are cached until > - checkpoint is triggered, and issued during the checkpoint. > - By default, it is disabled with 0. > + blocks less than 2MB. The candidates to be discarded are cached during > + checkpoint, and issued by issue_discard thread after checkpoint. > + It is enabled by default. > > What: /sys/fs/f2fs/<disk>/max_ordered_discard > Date: October 2022
Let me apply this and see what'll happen later, since no luck to reproduce. On 08/17, Chao Yu wrote: > Ping, > > On 2023/7/30 22:25, Chao Yu wrote: > > The description of max_small_discards is out-of-update in below two > > aspects, fix it. > > - it is disabled by default > > - small discards will be issued during checkpoint > > > > Signed-off-by: Chao Yu <chao@kernel.org> > > --- > > Documentation/ABI/testing/sysfs-fs-f2fs | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs > > index ad3d76d37c8b..36c3cb547901 100644 > > --- a/Documentation/ABI/testing/sysfs-fs-f2fs > > +++ b/Documentation/ABI/testing/sysfs-fs-f2fs > > @@ -102,9 +102,9 @@ What: /sys/fs/f2fs/<disk>/max_small_discards > > Date: November 2013 > > Contact: "Jaegeuk Kim" <jaegeuk.kim@samsung.com> > > Description: Controls the issue rate of discard commands that consist of small > > - blocks less than 2MB. The candidates to be discarded are cached until > > - checkpoint is triggered, and issued during the checkpoint. > > - By default, it is disabled with 0. > > + blocks less than 2MB. The candidates to be discarded are cached during > > + checkpoint, and issued by issue_discard thread after checkpoint. > > + It is enabled by default. > > What: /sys/fs/f2fs/<disk>/max_ordered_discard > > Date: October 2022
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Sun, 30 Jul 2023 22:25:51 +0800 you wrote: > The description of max_small_discards is out-of-update in below two > aspects, fix it. > - it is disabled by default > - small discards will be issued during checkpoint > > Signed-off-by: Chao Yu <chao@kernel.org> > > [...] Here is the summary with links: - [f2fs-dev,1/2] f2fs: doc: fix description of max_small_discards https://git.kernel.org/jaegeuk/f2fs/c/726865e69aa3 - [f2fs-dev,2/2] Revert "f2fs: do not issue small discard commands during checkpoint" https://git.kernel.org/jaegeuk/f2fs/c/005abf9e5e0d You are awesome, thank you!
diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs index ad3d76d37c8b..36c3cb547901 100644 --- a/Documentation/ABI/testing/sysfs-fs-f2fs +++ b/Documentation/ABI/testing/sysfs-fs-f2fs @@ -102,9 +102,9 @@ What: /sys/fs/f2fs/<disk>/max_small_discards Date: November 2013 Contact: "Jaegeuk Kim" <jaegeuk.kim@samsung.com> Description: Controls the issue rate of discard commands that consist of small - blocks less than 2MB. The candidates to be discarded are cached until - checkpoint is triggered, and issued during the checkpoint. - By default, it is disabled with 0. + blocks less than 2MB. The candidates to be discarded are cached during + checkpoint, and issued by issue_discard thread after checkpoint. + It is enabled by default. What: /sys/fs/f2fs/<disk>/max_ordered_discard Date: October 2022