From patchwork Sat Jul 29 17:43:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 128096 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp952985vqg; Sat, 29 Jul 2023 03:25:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlE3EwXAvDHV+pKSvyu4AO+GyoS7TDsYxurZw4/kHJn4WS6C78tvuEwNy4qt7PJhh6j8HYcb X-Received: by 2002:a17:907:7895:b0:99b:ef56:935 with SMTP id ku21-20020a170907789500b0099bef560935mr1987625ejc.65.1690626304558; Sat, 29 Jul 2023 03:25:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690626304; cv=none; d=google.com; s=arc-20160816; b=exK9IYwnK7JJt/YPJwYWgm4wlgJJsTIcEFzmgZdcL10r3SzDyQzJqqTdxwSXdC4zRy xVgvPBcr/usYuaeJqybiS/eUKN+ydLCRG7Xn2wXuMu1S3geJbsk69Aq5Pn7M5Xyu1zCU lGA0r+XYzI+T5GyR0l/tcmKdEgWxT0pZvNzZwjS4YcUd0SchpqrOfkiONiDOfTgk8zIW 6J1f6eaHCiuEBgHmSfgwIQTDabmE0G5sq93cFAdhRtnm6PHdmuilwd/mPb21SD28LmX0 EF7iJNt14kRZ9aVBfMpec5TNwLePncoqN6KseTJ/vSJBtcAiWGvsZTDXAq3O2lS0gz84 +hTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=bkhKZF0Hkri+kaq1HSuOKHk5DQCqZxLUUZ1GDcCrDQQ=; fh=62l4Cw9qWcpYrK61xUehDvMiFjGrQXJUwd3X3H+4A88=; b=QZhAwPMDKFg9O2hCJoGRZB8Pmho/G7hIiVIppq1mSHS4YY8+FuwtwXhDwuJpjOSoEe U3JN12SWTXxMuN+BdI1ssUF80VHrn0bPcNFMPZSFwOryBvdaIELBrqPo5JxQs5JxAZ+1 mJlSmX3JTHS3JODXXJh2ifMeOTY2h8TizSAIu+in2s2gun9MwM+3Ju0DnY1MzRXmAXbK i0J+AIat0DYx71mIoZdOnMhl3lD1e4p3j/vckarMUHyCBe9PHWnXxbVLk5AlxAR5kcwg G9+JFaP2dm7hDJAOPQadedunnYxJ7haxN+5sJ7R9wbJ+WUq/9FDIXvYNpyjiIzFZIdwo S3lA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i9-20020a170906a28900b0098d52a2bc16si4407633ejz.438.2023.07.29.03.24.40; Sat, 29 Jul 2023 03:25:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231791AbjG2Jns (ORCPT + 99 others); Sat, 29 Jul 2023 05:43:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231686AbjG2Jnk (ORCPT ); Sat, 29 Jul 2023 05:43:40 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A22C35A8 for ; Sat, 29 Jul 2023 02:43:39 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RCfhR2rb2z4f3pJP for ; Sat, 29 Jul 2023 17:43:35 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP1 (Coremail) with SMTP id cCh0CgDHMy5D38RkAQcpOQ--.25635S7; Sat, 29 Jul 2023 17:43:36 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, willy@infradead.org, david@redhat.com, shikemeng@huaweicloud.com Subject: [PATCH 5/5] mm/compaction: remove unnecessary "else continue" at end of loop in isolate_freepages_block Date: Sun, 30 Jul 2023 01:43:54 +0800 Message-Id: <20230729174354.2239980-6-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230729174354.2239980-1-shikemeng@huaweicloud.com> References: <20230729174354.2239980-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: cCh0CgDHMy5D38RkAQcpOQ--.25635S7 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUOb7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E 6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JF v_Gryl82xGYIkIc2x26280x7IE14v26r126s0DM28IrcIa0xkI8VCY1x0267AKxVW5JVCq 3wA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26F 1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AK xVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcV AaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0E x4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI 8F5VA0II8E6IAqYI8I648v4I1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_ Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17 CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_JFI_Gr1lIxAIcVC0 I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I 8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73 UjIFyTuYvjTRKfOwUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772750168248168412 X-GMAIL-MSGID: 1772750168248168412 There is no behavior change to remove "else continue" code at end of scan loop. Just remove it to make code cleaner. Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang --- mm/compaction.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index cfb661f4ce23..d38297018077 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -670,9 +670,6 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, isolate_fail: if (strict) break; - else - continue; - } compact_unlock_irqrestore(&locked, flags);