[2/5] mm/compaction: set compact_cached_free_pfn correctly in update_pageblock_skip
Message ID | 20230729174354.2239980-3-shikemeng@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp945895vqg; Sat, 29 Jul 2023 03:05:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlH/aJY6GePLTUMB/kMnXmlbfvMKAlXmG8hlMRyBevQUZT3XqeZ30enx6x0w4O2RSKMDueNp X-Received: by 2002:a05:6a20:9155:b0:122:ff52:7331 with SMTP id x21-20020a056a20915500b00122ff527331mr4267377pzc.52.1690625109114; Sat, 29 Jul 2023 03:05:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690625109; cv=none; d=google.com; s=arc-20160816; b=S+HMK/qRE6qusr3IwBPz5AyD8AByHqDBCdbKpUdB+ZhqFWb2YIPCh+lG6W51ntPRLa CyGCxfC0SMRi/laYREpgN0P7GUxHZtlfu4dLWgiSCiFTW9EaplWEgaHWrTcMHpmnh9S/ L2hbATQGTG+Wjfop5HYydPObyrJbQLXj7t0DGPmYS1KW8vQVT4/+sGfWP0E/peqpDwsN KtBtk8Ib2itD3MsuOoi9OfHhNwZnfigZ4Esj5Wblk7zUWuVqq/OV/YyUVDwfZfan9ruZ J96KS2YY6gdjLLAwIUyPYP8gocWZT+x9qBbZtgo3X0e8Dz0jD/d3AsMCKroWZ6EIuFUN NJ5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Z1HTIYk7VPg3eMqbi2GpDAqyLJa9v08gSasDici92kw=; fh=62l4Cw9qWcpYrK61xUehDvMiFjGrQXJUwd3X3H+4A88=; b=aH/3R3sfXcUFOTCyoTnRLjkHyl8En26d4wbyrFF8dWLm9A9GZbHiRaJdWJ7Nbh0Cjc VtZu59jRtCTHXzVlU8CYQ1PSKMHiILtlDhGQh2TXvMRg6VODZTjj5nzzdN8DzlSBSpLZ qyENxDW6htRMz1SdsekZJ/S5hni55Ugl5PIa2Fp59wyxf7QH8CJKOQKHIWT1NE4M6aob L9pZAuscMEV8M9IZYnaLgZp5g4ibeHDidh+diRcfNZkVsMBBVJMywHs6HT7tHR9n67W2 ZoDeiSLNrIU6/k0fwNIa+yhikmHhzYxvZlTVXdQH7MmxioOwpSI8LSNI8+s+sXt09a1O BHqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bv7-20020a056a00414700b00686d854cb0dsi1303200pfb.23.2023.07.29.03.04.48; Sat, 29 Jul 2023 03:05:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231781AbjG2Jnq (ORCPT <rfc822;hanasaki@gmail.com> + 99 others); Sat, 29 Jul 2023 05:43:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229997AbjG2Jnk (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 29 Jul 2023 05:43:40 -0400 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F1E52728 for <linux-kernel@vger.kernel.org>; Sat, 29 Jul 2023 02:43:39 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4RCfhN4Fwsz4f3nwR for <linux-kernel@vger.kernel.org>; Sat, 29 Jul 2023 17:43:32 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP1 (Coremail) with SMTP id cCh0CgDHMy5D38RkAQcpOQ--.25635S4; Sat, 29 Jul 2023 17:43:35 +0800 (CST) From: Kemeng Shi <shikemeng@huaweicloud.com> To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, willy@infradead.org, david@redhat.com, shikemeng@huaweicloud.com Subject: [PATCH 2/5] mm/compaction: set compact_cached_free_pfn correctly in update_pageblock_skip Date: Sun, 30 Jul 2023 01:43:51 +0800 Message-Id: <20230729174354.2239980-3-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230729174354.2239980-1-shikemeng@huaweicloud.com> References: <20230729174354.2239980-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: cCh0CgDHMy5D38RkAQcpOQ--.25635S4 X-Coremail-Antispam: 1UD129KBjvdXoW7Jw1kCr17WFW3KFWxWrykXwb_yoWfGrb_GF 1IyFn8K3W2v39xZ3ZrJw4Syry7Kr48Crn5Ww15Jry7Z3yqvF4kXanrJwnxXrn8XFZrurnx Gw1kuF18Gr4a9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbqAYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r15M28IrcIa0xkI8VCY1x0267AKxVW8JVW5JwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6I AqYI8I648v4I1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAq x4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r 43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF 7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxV WUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjTR QNVDUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772748914385250835 X-GMAIL-MSGID: 1772748914385250835 |
Series |
Fixes and cleanups to compaction
|
|
Commit Message
Kemeng Shi
July 29, 2023, 5:43 p.m. UTC
We will set skip to page block of block_start_pfn, it's more reasonable
to set compact_cached_free_pfn to page block before the block_start_pfn.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
mm/compaction.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On 7/30/2023 1:43 AM, Kemeng Shi wrote: > We will set skip to page block of block_start_pfn, it's more reasonable > to set compact_cached_free_pfn to page block before the block_start_pfn. Looks reasonable to me. Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com> > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> > --- > mm/compaction.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index d1d28d57e5bd..4a784872565a 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1690,7 +1690,8 @@ static void isolate_freepages(struct compact_control *cc) > > /* Update the skip hint if the full pageblock was scanned */ > if (isolate_start_pfn >= block_end_pfn) > - update_pageblock_skip(cc, page, block_start_pfn); > + update_pageblock_skip(cc, page, block_start_pfn - > + pageblock_nr_pages); > > /* Are enough freepages isolated? */ > if (cc->nr_freepages >= cc->nr_migratepages) {
diff --git a/mm/compaction.c b/mm/compaction.c index d1d28d57e5bd..4a784872565a 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1690,7 +1690,8 @@ static void isolate_freepages(struct compact_control *cc) /* Update the skip hint if the full pageblock was scanned */ if (isolate_start_pfn >= block_end_pfn) - update_pageblock_skip(cc, page, block_start_pfn); + update_pageblock_skip(cc, page, block_start_pfn - + pageblock_nr_pages); /* Are enough freepages isolated? */ if (cc->nr_freepages >= cc->nr_migratepages) {